[SOLVED] login error message

[squiblo]

hi, im quite a noob to php and i need some help with login, what i want is, an error message to appear on the same page as the login page saying something like "Wrong username or password" when someone has made a mistake logging in.

 

 

"session_register("myusername");

session_register("mypassword");

header("location:profile.php");

}

else {

echo "Wrong Username or Password";

}"

 

this script i have directs me to another page while i want the error message to appear on the same page, does anyone have a solution?

[waynew]

Hi. The script you've given seems to redirect ONLY is the login is correct. Otherwise, it seems to just echo out "Wrong Username or Password". Also, session_register has been depreciated.

[squiblo]

will i have to change my script completly?

[waynew]

What is the problem with it exactly? It seems to be doing what you want it to be doing?

[squiblo]

when an incorrect username or password is entered it directs me to a DIFFERENT page showing "Incorrect username or password", but what i want is "Incorrect username or password" to show on the same page next to the "login" button

[mmarif4u]

Would you like to share your code, we better analyze it.

[squiblo]

<?php

$host="localhost"; // Host name

$username=""; // Mysql username

$password=""; // Mysql password

$db_name=""; // Database name

$tbl_name="members"; // Table name

 

// Connect to server and select databse.

mysql_connect("$host", "$username", "$password")or die("cannot connect");

mysql_select_db("$db_name")or die("cannot select DB");

 

// username and password sent from form

$myusername=$_POST['myusername'];

$mypassword=$_POST['mypassword'];

 

// To protect MySQL injection (more detail about MySQL injection)

$myusername = stripslashes($myusername);

$mypassword = stripslashes($mypassword);

$myusername = mysql_real_escape_string($myusername);

$mypassword = mysql_real_escape_string($mypassword);

 

$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";

$result=mysql_query($sql);

 

// Mysql_num_row is counting table row

$count=mysql_num_rows($result);

// If result matched $myusername and $mypassword, table row must be 1 row

 

if($count==1){

// Register $myusername, $mypassword and redirect to file "profile.php"

session_register("myusername");

session_register("mypassword");

header("location:profile.php");

}

else {

echo "Wrong Username or Password";

}

?>

[waynew]

Post the code from the file with the actual login form on it.

[mmarif4u]

If you input wrong username or pass. it should not pass u to another page.

Can you post the form code too.

[squiblo]

<form name="form1" method="post" action="checklogin.php">

<input type="text" id="myusername" style="position:absolute;left:651px;top:59px;width:174px;font-family:Arial;font-size:13px;z-index:4" size="29" name="myusername" value="" title="username">

<input type="password" id="mypassword" style="position:absolute;left:651px;top:86px;width:174px;font-family:Arial;font-size:13px;z-index:5" size="29" name="mypassword" value="" tabindex="password" title="password">

<input type="checkbox" id="Checkbox1" name="Checkbox1" value="on" style="position:absolute;left:648px;top:113px;font-family:Arial;font-size:13px;z-index:6">

<input type="submit" id="Button1" name="Login" value="Login" style="position:absolute;left:778px;top:117px;width:50px;height:43px;font-family:Arial;font-size:13px;z-index:8" title="Login">

</form>

[mmarif4u]

Try this:

 

<?php
$host="localhost"; // Host name 
$username=""; // Mysql username 
$password=""; // Mysql password 
$db_name=""; // Database name 
$tbl_name="members"; // Table name 

// Connect to server and select databse.
mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db("$db_name")or die("cannot select DB");

if(isset($_POST['Login'])){
// username and password sent from form 
$myusername=$_POST['myusername']; 
$mypassword=$_POST['mypassword']; 

// To protect MySQL injection (more detail about MySQL injection)
$myusername = stripslashes($myusername);
$mypassword = stripslashes($mypassword);
$myusername = mysql_real_escape_string($myusername);
$mypassword = mysql_real_escape_string($mypassword);

$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$result=mysql_query($sql);

// Mysql_num_row is counting table row
$count=mysql_num_rows($result);
// If result matched $myusername and $mypassword, table row must be 1 row

if($count==1){
// Register $myusername, $mypassword and redirect to file "profile.php"
session_register("myusername");
session_register("mypassword"); 
header("location:profile.php");
}
else {
$error= "Wrong Username or Password";
}
}
?>

 

And:

<form name="form1" method="post" action="checklogin.php">
   <input type="text" id="myusername" style="position:absolute;left:651px;top:59px;width:174px;font-family:Arial;font-size:13px;z-index:4" size="29" name="myusername" value="" title="username">
   <input type="password" id="mypassword" style="position:absolute;left:651px;top:86px;width:174px;font-family:Arial;font-size:13px;z-index:5" size="29" name="mypassword" value="" tabindex="password" title="password">
   <input type="checkbox" id="Checkbox1" name="Checkbox1" value="on" style="position:absolute;left:648px;top:113px;font-family:Arial;font-size:13px;z-index:6">
   <input type="submit" id="Button1" name="Login" value="Login" style="position:absolute;left:778px;top:117px;width:50px;height:43px;font-family:Arial;font-size:13px;z-index:8" title="Login">
</form>
<?php echo $error ?>

[squiblo]

it directs me to a blank page, view for yourself go to www.squiblo.com. the page is protected because its not finished, the password to view the site is "allsaints".

[mmarif4u]

If you enter username and pass correctly, what it do?

[squiblo]

it goes to this

// Check if session is not registered , redirect back to main page.

// Put this code in first line of web page.

<?

session_start();

if(!session_is_registered(myusername)){

header("location:index.php");

}

?>

 

<html>

<body>

Login Successful

</body>

</html>

[mmarif4u]

So it mean, it is working properly for correct username and pass.

As i see from ur code. You are using checklogin.php to check username and pass. After successful login i will go to profile page. Am i correct?

So u need to redirect the user again to index page upon wrong input.

Just put header in your else statement for index page and see, what it doing...

[squiblo]

i change my else to:

 

else {

header("location: http://www.google.com");

}

}

?>

 

i used google just to test and it works, so i will just create a new page with another login form

[mmarif4u]

You can create a page for wrong input and show a login page to key in again.