looping help -> works on one but not the other

jeffshen · August 6, 2006

Hey,

I have a previous snippet of code which I have been using for ages now,

[code]<?PHP
include("login.php");
mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");
$query="SELECT * FROM people";
$result=mysql_query($query);
$num=mysql_numrows($result);

mysql_close();

echo "<center>2005-2006</center> ";

?>
<table border="1" cellspacing="2" cellpadding="2">
<tr>
<th>Name</th>
<th>Nickname</th>
<th>Class</th>
<th>E-Mail</th>
</tr>

<?PHP
$i=0;
while ($i < $num) {
$surname=mysql_result($result,$i,"surname");
$name=mysql_result($result,$i,"name");
$nickname=mysql_result($result,$i,"nickname");
$class=mysql_result($result,$i,"class");
$email=mysql_result($result,$i,"e_mail");
?>

<tr>
<td><? echo "$name"; echo" $surname"; ?></td>
<td><? echo "$nickname"; ?></td>
<td><? echo "$class"; ?></td>
<td><a href="mailto:<? echo "$email"; ?>"><? echo "$email"; ?></a></td>
</tr>
<?
++$i;
}
echo "</table>";?>[/code]

but however when I port the whole thing to another environment it dosent work... the MySQL query only returns the first line in this case rather than all the database entries as specified in the code...

[code]<table border="1" cellspacing="2" cellpadding="2">
<tr>
<th>Symbol</th>
<th>Name</th>
<th>Time</th>
<th>Date</th>
<th>Last</th>
<th>Change</th>
<th>High</th>
<th>Low</th>
</tr>

<?php
include("login.php");
mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "Unable to select database");
$query="SELECT * FROM stocks";
$result=mysql_query($query);
$num=mysql_numrows($result);
mysql_close();
$i=0;
while ($i < $num) {
$quote = mysql_result($result,$i,"symbol");
$standard = ".hk";
$findquote = "$quote$standard";

Class yahoo
{
function get_stock_quote($symbol)
{
$url = sprintf("http://finance.yahoo.com/d/quotes.csv?s=%s&f=snl1d1t1c1ohgv" ,$symbol);
$fp = fopen($url, "r");
if(!fp)
{
echo "error : cannot recieve stock quote information";
}
else
{
$array = fgetcsv($fp , 4096 , ', ');
fclose($fp);
$this->symbol = $array[0];
$this->name = $array[1];
$this->last = $array[2];
$this->date = $array[3];
$this->time = $array[4];
$this->change = $array[5];
$this->open = $array[6];
$this->high = $array[7];
$this->low = $array[8];
$this->volume = $array[9];
}
}
}
$quote = new yahoo;
$quote->get_stock_quote("$findquote");
?>

<tr>
<td><? echo "$quote->symbol"; ?></td>
<td><? echo "$quote->name"; ?></td>
<td><? echo "$quote->time"; ?></td>
<td><? echo "$quote->date"; ?></td>
<td><? echo "$quote->last"; ?></td>
<td><? echo "$quote->change"; ?></td>
<td><? echo "$quote->high"; ?></td>
<td><? echo "$quote->low"; ?></td>
</tr>
<?
++$i;
}
?>
</table>[/code]

Can someone please help?

Thanks a lot,

Jeff

ignace · August 6, 2006

this now should work,

fixed localhost to "localhost"
removed the mysql_numrows() function, misspelled must be mysql_num_rows()
changed the loop from while($i < $num) to while ($row = mysql_fetch_array($result))
removed mysql_result();
changed all variables inside the while loop
fixed some unneccessary typing echo $name; echo $surname;
mysql_close() now executes before php is closed instead of behind the mysql_num_rows() function

[code]
<?PHP
include("login.php");
mysql_connect("localhost",$username,$password);
@mysql_select_db($database) or die( "Unable to select database");
$query="SELECT * FROM people";
$result=mysql_query($query);

echo "<center>2005-2006</center> ";

?>
<table border="1" cellspacing="2" cellpadding="2">
<tr>
<th>Name</th>
<th>Nickname</th>
<th>Class</th>
<th>E-Mail</th>
</tr>

<?PHP
$i=0;
while ($row = mysql_fetch_array($result)) {
$surname=$row['surname'];
$name=$row['name'];
$nickname=$row['nickname'];
$class=$row['class'];
$email=$row['e_mail'];
?>

<tr>
<td><? echo "$name" . " $surname"; ?></td>
<td><? echo "$nickname"; ?></td>
<td><? echo "$class"; ?></td>
<td><a href="mailto:<? echo "$email"; ?>"><? echo "$email"; ?></a></td>
</tr>
<?
++$i;
}
echo "</table>";

mysql_close();
?>
[/code]

ignace · August 6, 2006

[code]
<table border="1" cellspacing="2" cellpadding="2">
<tr>
<th>Symbol</th>
<th>Name</th>
<th>Time</th>
<th>Date</th>
<th>Last</th>
<th>Change</th>
<th>High</th>
<th>Low</th>
</tr>

<?php
include("login.php");
mysql_connect("localhost",$username,$password);
@mysql_select_db($database) or die( "Unable to select database");
$query="SELECT * FROM stocks";
$result=mysql_query($query);
$i=0;
while ($row = mysql_fetch_array($result)) {
$quote = $row['symbol'];
$standard = ".hk";
$findquote = "$quote$standard";

Class yahoo
{
function get_stock_quote($symbol)
{
$url = sprintf("http://finance.yahoo.com/d/quotes.csv?s=%s&f=snl1d1t1c1ohgv" ,$symbol);
$fp = fopen($url, "r");
if(!$fp)
{
echo "error : cannot recieve stock quote information";
}
else
{
$array = fgetcsv($fp , 4096 , ', ');
fclose($fp);
$this->symbol = $array[0];
$this->name = $array[1];
$this->last = $array[2];
$this->date = $array[3];
$this->time = $array[4];
$this->change = $array[5];
$this->open = $array[6];
$this->high = $array[7];
$this->low = $array[8];
$this->volume = $array[9];
}
}
}
$quote = new yahoo;
$quote->get_stock_quote("$findquote");
?>

<tr>
<td><? echo "$quote->symbol"; ?></td>
<td><? echo "$quote->name"; ?></td>
<td><? echo "$quote->time"; ?></td>
<td><? echo "$quote->date"; ?></td>
<td><? echo "$quote->last"; ?></td>
<td><? echo "$quote->change"; ?></td>
<td><? echo "$quote->high"; ?></td>
<td><? echo "$quote->low"; ?></td>
</tr>
<?
++$i;
}
?>
</table>
[/code]

Sign In

looping help -> works on one but not the other

Recommended Posts

jeffshen

Link to comment

Share on other sites

ignace

Link to comment

Share on other sites

ignace

Link to comment

Share on other sites

Join the conversation

Browse

Activity

Important Information