[SOLVED] Simple IF ELSE statement in conjunction with ISSET and EMPTY

[jarvis]

Hi all,

 

I'm creating an article CMS system.

Each article can have it's own meta keywords and meta description, otherwise default ones are used which can be set via the CMS.

The main article page itself calls in a global header with the following code:

if(!isset($meta_keywords) || empty($meta_keywords)) { 

   $meta_key = "SELECT keywords FROM meta_content"; 
   $meta_key_result = mysql_query ($meta_key) or die( "Could not execute SQL query" );
   while ($row = mysql_fetch_array ($meta_key_result, MYSQL_ASSOC)) 
      { 
        $meta_keywords =$row['keywords']; 
      }        	
}

if(!isset($meta_description) || empty($meta_description)) {

   $meta_des = "SELECT description FROM meta_content"; 
   $meta_des_result = mysql_query ($meta_des) or die( "Could not execute SQL query" );
   while ($row = mysql_fetch_array ($meta_des_result, MYSQL_ASSOC)) 
      { 
        $meta_description =$row['description']; 
      }        
}

I then call this in using:

<meta name="keywords" content="<?php echo $meta_keywords; ?>" />
<meta name="description" content="<?php echo $meta_description; ?>" />

So in theory, if $meta_keywords and $meta_description are empty from the article, it will use the default!

 

This is the code I use on the article page to create the main page query & obtain the values for $meta_keywords and $meta_decription:

$query = "SELECT articles.article_id, articles.description, articles.status, articles.meta_keywords, articles.meta_description, articles.title, article_categories.category, article_categories.article_category_id FROM articles INNER JOIN (article_categories INNER JOIN article_associations ON article_categories.article_category_id = article_associations.article_category_id) ON articles.article_id = article_associations.article_id WHERE articles.article_id = $aid AND status = '1'";

#$result = mysql_query($query) or die( "Could not execute SQL query" );
$result =  mysql_query($query) or die(mysql_error());		

if (mysql_num_rows($result) == 1) { // if the query ran ok continue...

	// Retrieve the info from the db
	$row = mysql_fetch_array ($result, MYSQL_ASSOC);

	# Include Page Title and Call to header here for dynamic pages #
	$page_title = $row['title'] .', '. $row['category'];
	#$meta_keywords = $row['meta_keywords'];  //debug
	#$meta_description = $row['meta_description']; //debug

	if (($row['meta_keywords']) !=""){
		$meta_keywords = $row['meta_keywords'];
		echo $meta_keywords;
	} else {
		$meta_keywords = FALSE;	
		echo $meta_keywords;
	}

	if (($row['meta_description']) !=""){
		$meta_description = $row['meta_description'];
		echo $meta_description;
	} else {
		$meta_description = FALSE;
		echo $meta_description;
	}

	include ('./includes/header.html');
	# Include Page Title and Call to header here for dynamic pages #

All good so far, or so I thought! If the article has the meta keywords and description set, the page loads fine. If they're blank, the default should show, instead, my page has the following:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

I cannot work out this simple piece of code & it's now driving me mad! Any help is very much appreciated!!!

 

Thanks in Advanced!

[waynew]

Why not do it the easy way and output the default keywords and description if the ones for that article don't exist in the database?

[jarvis]

Thanks waynewex for the reply, can you explain?

 

Sorry am massively recovering from a stag weekend and think all brain cells were killed off!

[tommyda]

  $query = "SELECT articles.article_id, articles.description, articles.status, articles.meta_keywords, articles.meta_description, articles.title, article_categories.category, article_categories.article_category_id FROM articles INNER JOIN (article_categories INNER JOIN article_associations ON article_categories.article_category_id = article_associations.article_category_id) ON articles.article_id = article_associations.article_id WHERE articles.article_id = $aid AND status = '1'";

 

If (mysql_num_rows($query) == '0')

 

{

$meta_desc = 'Standard meta desc';

$meta_key = 'Standard meta key';

}

else

{

$row = mysql_fetch_array($query);

$meta_desc = $row['meta_desc'];

$meta_key = $row['meta_desc'];

};

 

 

[jarvis]

Thanks Tommyda, however, the standard/default keywords are pulled from the CMS as it allows them to be updated at any point. Hence why I push the values into the header via isset and then use if else.

 

The issue seems to be with this block of code:

$query = "SELECT articles.article_id, articles.description, articles.status, articles.meta_keywords, articles.meta_description, articles.title, article_categories.category, article_categories.article_category_id FROM articles INNER JOIN (article_categories INNER JOIN article_associations ON article_categories.article_category_id = article_associations.article_category_id) ON articles.article_id = article_associations.article_id WHERE articles.article_id = $aid AND status = '1'";	

$result = mysql_query($query) or die( "Could not execute SQL query" );

if (mysql_num_rows($result) > 0) { // if the query ran ok continue...

	// Retrieve the info from the db
	$row = mysql_fetch_array ($result, MYSQL_ASSOC);

	# Include Page Title and Call to header here for dynamic pages #
	$page_title = $row['title'] .', '. $row['category'] .', LP Gas';
	$meta_keywords = $row['meta_keywords'];
	$meta_description = $row['meta_description'];

	if (($row['meta_keywords']) !=""){
		$meta_keywords = $row['meta_keywords'];
		echo $meta_keywords;
	} else {
		$meta_keywords = FALSE;	
		echo $meta_keywords;
	}

	if (($row['meta_description']) !=""){
		$meta_description = $row['meta_description'];
		echo $meta_description;
	} else {
		$meta_description = FALSE;
		echo $meta_description;
	}

	include ('./includes/header.html');
	# Include Page Title and Call to header here for dynamic pages #

	# Create Breadcrumb #
	echo'<p><a href="index.php">Home</a> > <a href="article_list.php?id=' . $row['article_category_id'] . '">' . stripslashes($row['category']) . '</a> > ' . stripslashes($row['title']) . '</p>';
	# /Create Breadcrumb #

I believe it's because if the meta_keywords/description are empty when it retrieves the info for a given id, I need to make sure that either keywords/description are set to empty and use should then work in the header code i.e.

if(!isset($meta_keywords) || empty($meta_keywords)) { 

Although am no whizz at PHP by any means!

 

 

Cheers