Having problems with php/mysql login

[Hashman]

I got a login script from a site and its works good until you go to login. Its shows just a blank screen, and i tried putting the form on the top and i got thi error

 

Warning: mysql_query(): supplied argument is not a valid MySQL-Link resource in /home/a9194245/public_html/login.php on line 32

 

Heres the code

 

<?

 

/**

* Checks whether or not the given username is in the

* database, if so it checks if the given password is

* the same password in the database for that user.

* If the user doesn't exist or if the passwords don't

* match up, it returns an error code (1 or 2).

* On success it returns 0.

*/

function confirmUser($username, $password){

  global $conn;

  /* Add slashes if necessary (for query) */

  if(!get_magic_quotes_gpc()) {

$username = addslashes($username);

  }

 

  /* Verify that user is in database */

  $q = "select password from users where username = '$username'";

  $result = mysql_query($q,$conn);

  if(!$result || (mysql_numrows($result) < 1)){

      return 1; //Indicates username failure

  }

 

  /* Retrieve password from result, strip slashes */

  $dbarray = mysql_fetch_array($result);

  $dbarray['password']  = stripslashes($dbarray['password']);

  $password = stripslashes($password);

 

  /* Validate that password is correct */

  if($password == $dbarray['password']){

      return 0; //Success! Username and password confirmed

  }

  else{

      return 2; //Indicates password failure

  }

}

 

/**

* checkLogin - Checks if the user has already previously

* logged in, and a session with the user has already been

* established. Also checks to see if user has been remembered.

* If so, the database is queried to make sure of the user's

* authenticity. Returns true if the user has logged in.

*/

function checkLogin(){

  /* Check if user has been remembered */

  if(isset($_COOKIE['cookname']) && isset($_COOKIE['cookpass'])){

      $_SESSION['username'] = $_COOKIE['cookname'];

      $_SESSION['password'] = $_COOKIE['cookpass'];

  }

 

  /* Username and password have been set */

  if(isset($_SESSION['username']) && isset($_SESSION['password'])){

      /* Confirm that username and password are valid */

      if(confirmUser($_SESSION['username'], $_SESSION['password']) != 0){

        /* Variables are incorrect, user not logged in */

        unset($_SESSION['username']);

        unset($_SESSION['password']);

        return false;

      }

      return true;

  }

  /* User not logged in */

  else{

      return false;

  }

}

 

/**

* Determines whether or not to display the login

* form or to show the user that he is logged in

* based on if the session variables are set.

*/

function displayLogin(){

  global $logged_in;

  if($logged_in){

      echo "<h1>Logged In!</h1>";

      echo "Welcome <b>$_SESSION[username]</b>, you are logged in. <a href=\"logout.php\">Logout</a>";

  }

  else{

?>

 

<h1>Login</h1>

<form action="" method="post">

<table align="left" border="0" cellspacing="0" cellpadding="3">

<tr><td>Username:</td><td><input type="text" name="user" maxlength="30"></td></tr>

<tr><td>Password:</td><td><input type="password" name="pass" maxlength="30"></td></tr>

<tr><td colspan="2" align="left"><input type="checkbox" name="remember">

<font size="2">Remember me next time</td></tr>

<tr><td colspan="2" align="right"><input type="submit" name="sublogin" value="Login"></td></tr>

<tr><td colspan="2" align="left"><a href="register.php">Join</a></td></tr>

</table>

</form>

 

<?

  }

}

 

 

/**

* Checks to see if the user has submitted his

* username and password through the login form,

* if so, checks authenticity in database and

* creates session.

*/

if(isset($_POST['sublogin'])){

  /* Check that all fields were typed in */

  if(!$_POST['user'] || !$_POST['pass']){

      die('You didn\'t fill in a required field.');

  }

  /* Spruce up username, check length */

  $_POST['user'] = trim($_POST['user']);

  if(strlen($_POST['user']) > 30){

      die("Sorry, the username is longer than 30 characters, please shorten it.");

  }

 

  /* Checks that username is in database and password is correct */

  $md5pass = md5($_POST['pass']);

  $result = confirmUser($_POST['user'], $md5pass);

 

  /* Check error codes */

  if($result == 1){

      die('That username doesn\'t exist in our database.');

  }

  else if($result == 2){

      die('Incorrect password, please try again.');

  }

 

  /* Username and password correct, register session variables */

  $_POST['user'] = stripslashes($_POST['user']);

  $_SESSION['username'] = $_POST['user'];

  $_SESSION['password'] = $md5pass;

 

  /**

    * This is the cool part: the user has requested that we remember that

    * he's logged in, so we set two cookies. One to hold his username,

    * and one to hold his md5 encrypted password. We set them both to

    * expire in 100 days. Now, next time he comes to our site, we will

    * log him in automatically.

    */

  if(isset($_POST['remember'])){

      setcookie("cookname", $_SESSION['username'], time()+60*60*24*100, "/");

      setcookie("cookpass", $_SESSION['password'], time()+60*60*24*100, "/");

  }

 

  /* Quick self-redirect to avoid resending data on refresh */

  echo "<meta http-equiv=\"Refresh\" content=\"0;url=$HTTP_SERVER_VARS[php_SELF]\">";

  return;

}

 

/* Sets the value of the logged_in variable, which can be used in your code */

$logged_in = checkLogin();

 

?>

 

[DaiLaughing]

The script only logs you in.  You have to create the page which calls those functions and the content which displays afterwards.  You would be better off searching for a tutorial on creating a log in system and doing your own step-by-step.  then you would know how to change it later.

[Hashman]

I know the script only longs me in. I wanna know whats wrong with the script and why its giving that error, because the records are in the database

[DaiLaughing]

You said it works well until you changed it.  So unchange it.

[Hashman]

no it works well until you go to login. You go to register and tell you weather the name is taken or itll register  and after that itll say your registered you can now login but once you go to login thats where the problem is. If you want to see the problem for yourself <a href="http://gamezandstuff.hoztzi.com/">Click here</a>. The errors at the very bottom now

[PFMaBiSmAd]

not a valid MySQL-Link resource

The error means that $conn (used in the mysql_query() statement) is not a valid connection to a database server. In fact I don't see any code that is attempting to connect to a database server or any include/require statement that would be doing that either.

[Hashman]

Heres what connects to the database. I took out some of the database info for obvious reasons

 

 

<?

 

/**

* Connect to the mysql database.

*/

$conn = mysql_connect("mysql11", "a9194245", "s") or die(mysql_error());

mysql_select_db('a9194245', $conn) or die(mysql_error());

 

?>

 

[PFMaBiSmAd]

Where exactly in the code was that last bit of code at?

 

The error is not being generated and output for no reason. At the time the mysql_query() statement was executed, $conn was not a valid link resource.

 

And please post any code between

tags.

 

Edit: The posted code also has no session_start() statement so none of the session variables will be working. Where did you get this code from?

[Hashman]

Hey thanks for saying that you didn't see anything to connect to the database. I put

 

<?

include("database.php");

 

at the top and now all its saying is Incorrect password, please try again.

[PFMaBiSmAd]

Ok, so troubleshoot why your code on your server with your database would output that message. We don't have access to things like your database, so the only person here that can actually troubleshoot what your code is doing it you.

 

Find where that message is being produced in the code and backtrack through the logic and data and find you why that message would be output.

 

I'll give you a hand. Here is where that message is being output. Find out where $result is being set and then find out what would cause it to have a value of 2 -

   else if($result == 2){
      die('Incorrect password, please try again.');

[Hashman]

I sent you a  message...