file creation

[onthespot]

Hey, I am trying to get an email activation working.

The idea is that when the database is added to (new registration), the following will occur.

 

  $num = rand(1, 9999999999);
  $file = "activation/".$num.".".$subuser.".php";
          $content = "<?php\n\n"
                    . 'require_once \'../include/constants.php\';' . "\n\n"
                    . '$link = mysql_connect(DB_SERVER,DB_USER,DB_PASS) or die(mysql_error());' . "\n\n"
                    . 'mysql_select_db(DB_NAME,$link) or die(mysql_error());' . "\n\n"
                    . '$q = "UPDATE `users` SET `userlevel` = 1 WHERE `username` = \'' . $subuser  . "'\";\n\n"
                    . 'mysql_query($q, $link);' . "\n\n"
                    . '?>';



  if($fp = fopen($file, 'a')){
    fwrite($fp, $content."\n");
    fclose($fp);
  }

 

Any idea why the file isn't being created?

[WolfRage]

Include an else statement and see if it is due to a file error. Also use fileputcontents it will save you some time and code.

 

Edit: Make sure you have error reporting on to catch the error in your code. E_ALL...

[onthespot]

Can you alter the code for that function you spoke about? please?

[WolfRage]

<?php
error_reporting(E_ALL); 
ini_set("display_errors", 1);   
$num = rand(1, 9999999999);
  $file = "activation/".$num.".".$subuser.".php";
          $content = "<?phpnn"
                    . 'require_once \'../include/constants.php\';' . "nn"
                    . '$link = mysql_connect(DB_SERVER,DB_USER,DB_PASS) or die(mysql_error());' . "nn"
                    . 'mysql_select_db(DB_NAME,$link) or die(mysql_error());' . "nn"
                    . '$q = "UPDATE `users` SET `userlevel` = 1 WHERE `username` = '' . $subuser  . "'\";\n\n"
                    . 'mysql_query($q, $link);' . "\n\n"
                    . ?>';



  if($fp = fopen($file, 'a')){
    fwrite($fp, $content."\n");
    fclose($fp);
  }
?>

[onthespot]

      else{
         if($database->addNewUser($subuser, md5($subpass), $subemail, $subname1, $sublocation, $subx360gt, $subps3gt, $subpcgt)){
  error_reporting(E_ALL); 
ini_set("display_errors", 1);   
  $num = rand(1, 9999999999);
  $file = "activation/".$num.".".$subuser.".php";
          $content = "<?php\n\n"
                    . 'require_once \'../include/constants.php\';' . "\n\n"
                    . '$link = mysql_connect(DB_SERVER,DB_USER,DB_PASS) or die(mysql_error());' . "\n\n"
                    . 'mysql_select_db(DB_NAME,$link) or die(mysql_error());' . "\n\n"
                    . '$q = "UPDATE `users` SET `userlevel` = 1 WHERE `username` = \'' . $subuser  . "'\";\n\n"
                    . 'mysql_query($q, $link);' . "\n\n"
                    . '?>';



  if($fp = fopen($file, 'a')){
    fwrite($fp, $content."\n");
    fclose($fp);
  }
  


  if(EMAIL_WELCOME){
      $mailer->sendWelcome($subuser,$subemail,$subpass,$file);
  }
  return 0;  //New user added succesfully
}else{
  return 2;  //Registration attempt failed
}
      }

 

That just wont make the file? Its just not there!

[WolfRage]

What? ???? What kind of error did you get?

Remove the if statement around your file creation and just create the file.

<?php
if($fp = fopen($file, 'a')){
    fwrite($fp, $content."\n");
    fclose($fp);
  }

?>

Should just be:

<?php
$fp = fopen($file, 'a');
fwrite($fp, $content."\n");
fclose($fp);
?>

If you want to test for the failure of the fopen check to see if $fp is equal to FALSE.

[mattal999]

      else{
         if($database->addNewUser($subuser, md5($subpass), $subemail, $subname1, $sublocation, $subx360gt, $subps3gt, $subpcgt)){
  error_reporting(E_ALL); 
ini_set("display_errors", 1);   
  $num = rand(1, 9999999999);
  $file = "activation/".$num.".".$subuser.".php";
          $content = "<?php\n\n"
                    . 'require_once \'../include/constants.php\';' . "\n\n"
                    . '$link = mysql_connect(DB_SERVER,DB_USER,DB_PASS) or die(mysql_error());' . "\n\n"
                    . 'mysql_select_db(DB_NAME,$link) or die(mysql_error());' . "\n\n"
                    . '$q = "UPDATE `users` SET `userlevel` = 1 WHERE `username` = \'' . $subuser  . "'\";\n\n"
                    . 'mysql_query($q, $link);' . "\n\n"
                    . '?>';



  if($fp = fopen($file, 'a')){
    fwrite($fp, $content."\n");
    fclose($fp);
  }
  


  if(EMAIL_WELCOME){
      $mailer->sendWelcome($subuser,$subemail,$subpass,$file);
  }
  return 0;  //New user added succesfully
}else{
  return 2;  //Registration attempt failed
}
      }

 

That just wont make the file? Its just not there!

 

It doesn't create the file because PHP ends on that ?> tag you have in contents. It's not properly escaped.

 

if($database->addNewUser($subuser, md5($subpass), $subemail, $subname1, $sublocation, $subx360gt, $subps3gt, $subpcgt)) {
    error_reporting(E_ALL); 
    ini_set("display_errors", 1);   
    $num = rand(1, 9999999999);
    $file = "activation/".$num.".".$subuser.".php";
    $content = '<' . "?php\n\n"
    . 'require_once \'../include/constants.php\';' . "\n\n"
    . '$link = mysql_connect(DB_SERVER,DB_USER,DB_PASS) or die(mysql_error());' . "\n\n"
    . 'mysql_select_db(DB_NAME,$link) or die(mysql_error());' . "\n\n"
    . '$q = "UPDATE `users` SET `userlevel` = 1 WHERE `username` = \'' . $subuser  . "'\";\n\n"
    . 'mysql_query($q, $link);' . "\n\n"
    . '?' . '>';

    if($fp = fopen($file, 'a')){
    fwrite($fp, $content."\n");
    fclose($fp);
    }

    if(EMAIL_WELCOME){
        $mailer->sendWelcome($subuser,$subemail,$subpass,$file);
    }
    return 0;  //New user added succesfully
} else {
    return 2;  //Registration attempt failed
}