[SOLVED] unwanted notice

[squiblo]

with this code, if the user is not logged in, i get this notice...

Notice: Undefined index: mycompany in /customers/squiblo.com/squiblo.com/httpd.www/index.php on line 245

 

this is the code...

<?php

include("checklogin.php");

$company = $_SESSION['mycompany'];

$query = mysql_query("SELECT * FROM members WHERE username='$company'");
if (mysql_num_rows($query)==0){
   die;
}else{
   $row = mysql_fetch_assoc($query);
   $location = $row['image'];
   if($location == ""){
      echo "<img src ='/profileimages/box.png' width='110' height='110' border='0'></a>";
   }else{
      echo "<img src ='$location' width='110' height='110' border='0'>";
   }
}


?>

[bubbasheeko]

$_SESSION['mycompany'];

 

Have you "started the session" in this file? (ie.  <?php session_start(); ?> )

[squiblo]

yes, i have session_start(); at the beginning of each page

[thebadbad]

You can eliminate the notice by checking if the element is set:

 

$company = isset($_SESSION['mycompany']) ? $_SESSION['mycompany'] : 'default_value';

Just decide what you want to do if it's not set.

[squiblo]

ok now im a little confused 

[thebadbad]

In my snippet I set $company to $_SESSION['mycompany'] if it's set, else to default_value. Do you still want to query the database if the user isn't logged in?

[squiblo]

sorry im new to php and i have not come across default_value yet and dont really understand, if im not logged in the image does not appear, but when i log in an image appears correctly.

[thebadbad]

Okay, default_value was just a string I typed in. You could then substitute it with your own default value for $company if you had one. But if the script is working as intended, and you just want to get rid of the notice, change

 

$company = $_SESSION['mycompany'];

to

 

$company = isset($_SESSION['mycompany']) ? $_SESSION['mycompany'] : '';

or if you prefer the regular syntax:

 

if (isset($_SESSION['mycompany'])) {
$company = $_SESSION['mycompany'];
} else {
$company = '';
}

[squiblo]

that has worked perfect thanks