[SOLVED] Help with for loop

[denoteone]

I am getting a "Error, insert query failed"  anyone see what I am doing wrong?

<?PHP

 

mysql_connect("#", "#", "#") or die(mysql_error());

mysql_select_db("#") or die(mysql_error());

 

$zone = "4";

 

for ( $counter = 1; $counter < 239; $counter += 1) {

 

echo $counter;

 

$query= "INSERT INTO zones_to_geo_zones (association_id,zone_country_id,zone_id,geo_zone_id,last_modified,date_added) VALUES ('$counter','$counter', '0' ,'$zone','0', '0')";

 

mysql_query($query) or die('Error, insert query failed');

}

 

?>

[MatthewJ]

Are your id's integers?

[mattal999]

Add a mysql_error and tell us the output:

 

<?php

mysql_connect("#", "#", "#") or die(mysql_error());
mysql_select_db("#") or die(mysql_error());

$zone = "4";

for ( $counter = 1; $counter < 239; $counter += 1) {

echo $counter;

$query= "INSERT INTO zones_to_geo_zones (association_id,zone_country_id,zone_id,geo_zone_id,last_modified,date_added) VALUES ('$counter','$counter', '0' ,'$zone','0', '0')"; 

mysql_query($query) or die('Error, insert query failed because: '.mysql_error());
}

?>

[mikesta707]

change your die to

die('Error, insert query failed: ' . mysql_error());

 

and see what error you get. If some of those columns are integer or other numeric types of columns, I don't think you can have single quotes around their insert values

 

 

[denoteone]

I didn't need the single quotes around the integers that I was inserting. Thanks everyone!  I will use . mysql_error()); for now on.