$_GET not working

[AStrangerWCandy]

Is $_POST required prior to using $_GET?

 

I have a hyperlink which is index.php?action=logout

 

When that link is clicked Im trying to get it to unset the logged in session variable.

 

I have this code:

 

if ($_GET['action'] = logout)

 

which unsets the variable if its true, however $_GET['action'] does not ever seen to equal anything. I've been trying to print it to see what the problem is as no error is generated and I get nothing. Am I going about this the wrong way?

[mikesta707]

you have to surround strings with quotation marks. that will try to find a constant logout and since there is none, that will always run false

 

if ($_GET['action'] = "logout")

[MartinGr]

What you are currently doing is assigning value 'logout' to $_GET['action'].

Actually the solution is really easy

if ($_GET['action'] == "logout")

[AStrangerWCandy]

Indeed you guys are awesome I'm still a beginner. Finally made a system of logging in that works great, validates and crypts but some simple stuff like this still trips me up. I am now returning the proper value however I have a feeling im using unset improperly. the rest of the code is as follows:

 

if ($_GET['action'] == "logout")

{

unset ($_SESSION['loggedin']);

 

It dosnt seem to actually unset that variable when the link is clicked or page refreshed.

[mikesta707]

unset pretty much just creates a whole in your session array. It will take out the value of the array at that key, but the key is still preserved. You also want to do session_destroy() to completely destroy the session

[AStrangerWCandy]

Hrm I switched it to session_destoy() and had both the unset and session destroy and neither one logged the person out. It removed the variables indicating username and whatnot but the logged in session variable remains. I even had it print the session variable right after session_destroy and that variable remains

[AStrangerWCandy]

Might be better if I post the whole code of what I'm trying to do:

 

<?php
require("header.php"); // The banner logo and ad app. Also begins the overall page table.

if ($_GET['action'] == "logout")
{
unset ($_SESSION['loggedin'];
session_destroy();
require("sidebar.php"); // The app that determines if you're logged in, if logged in displays sidebar menu, if not offers login/signup
require("announcements.php"); // Gives main page with announcements
require("footer.php"); // Copyright info and ties up the overall page table.
}
else
{
require("sidebar.php"); // The app that determines if you're logged in, if logged in displays sidebar menu, if not offers login/signup
require("announcements.php"); // Gives main page with announcements
require("footer.php"); // Copyright info and ties up the overall page table.
}

 

sidebar.php is where the login box is and it starts off with:

 

if ($_SESSION[loggedin] = yes)

{

 

and on from there

[MartinGr]

Hrm I switched it to session_destoy() and had both the unset and session destroy and neither one logged the person out. It removed the variables indicating username and whatnot but the logged in session variable remains. I even had it print the session variable right after session_destroy and that variable remains

Do you have session_start() at the beginning of the file you are using this code at?

 

Edited: Apparently not. Add it and both, unset and session_destroy() should work.

[AStrangerWCandy]

of index.php? no I dont

 

session_start() is the first line of the header.php that I require on all pages

[MartinGr]

Try using session_unset() before session_destroy()

[AStrangerWCandy]

Added that in and the variable is still not going away

[AStrangerWCandy]

I also should probably add the loggedin session variable is being set within a function