[SOLVED] Problem using while() to get unique number

[shamuraq]

hi all,

 

I've been trying to source for script to produce unique for digit number as in getting php to randomise 4 digits with no digit having same value.

 

So i tried this code i got from

http://forums.digitalpoint.com/showthread.php?t=9048

and modified it a bit into:

<?
error_reporting(E_ALL);
ini_set('display_errors', 1);

$arr = array();
$i=0;
$result = array();

while ( count($arr) < 6 ) {
    $x = mt_rand(1,10);
    if ( !in_array($x,$arr) ) {
	$result[$i] = $x;
	$i+=1;
}
}
print_r($x);
?>

This is the output that i got:

Fatal error: Maximum execution time of 30 seconds exceeded in D:\Apache Group\Apache2\htdocs\..... on line 11

Any suggestions?

[Garethp]

Change $result[$i] to $arr[$i]

 

See, your adding to the result array, but your saying, while the arr array is less than 6 things, keep going, but your never making the arr array longer than 0

[shamuraq]

maybe its just sleepless nights trying to get this thing working...

i made the change "$result[$i] to $arr[$i]"

and only 1 number came out instead of 6 numbers...

<?
error_reporting(E_ALL);
ini_set('display_errors', 1);

$arr = array();
$i=0;
$result = array();

while ( count($arr) < 6 ) {
    $x = mt_rand(1,10);
    if ( !in_array($x,$arr) ) {
	$arr[$i] = $x;
	$i+=1;
}
}
print_r($x);
?>

[TeNDoLLA]

print_r($arr); <-- holds your results.

[shamuraq]

Your're sooooooooooooooo right!!!! Thanx mate!!!

[thebadbad]

You don't have to use a loop:

 

<?php
$numbers = range(1, 10);
shuffle($numbers);
echo implode('', array_slice($numbers, 0, 4));
?>

 

Should be faster.