this code works sporadically so i'm guessing its not right

[blue-genie]

don't laugh but i figured i want to get the autoincrement value of what i just inserted and repeat it in another field.

so i do the insert , then mysql_insert_id(); then another update.

 

can someone clean this up for me so it works all the time (currently i get a null sometimes though the insert does happen)

 

<?php

session_start();
include 'config.php';
include 'opendb.php';

$gameID= $_REQUEST['gameID'];
$gameRNG= $_REQUEST['gameRNG'];

$insert = mysql_query("INSERT INTO gameinstance (gameID, gameRNGResult, gameDateTime) VALUES ('$gameID', '$gameRNG', now())");
if(!$insert){
	echo '<?xml version="1.0"?>';
        echo '<dataxml>';
	die("There's little problem: ".mysql_error());
	$MyError = "An error occured while saving data. Please try again later." + mysql_error();
	echo "<sqlError>".$MyError."</sqlError>";
	echo '</dataxml>';
} else {
	   $gameInstanceNo = mysql_insert_id();
	   mysql_query("UPDATE gameInstance SET gameInstance_No='$gameInstanceNo' WHERE USN_Gameinstance='$gameInstanceNo'"); 
	   echo '<?xml version="1.0"?>';
           echo '<dataxml>';
	   $success = mysql_insert_id();
	   echo "<success>".$success."</success>";
	   echo '</dataxml>';
}

?> 

[Dtonlinegames]

Try

<?php

session_start();
include 'config.php';
include 'opendb.php';

$gameID= $_REQUEST['gameID'];
$gameRNG= $_REQUEST['gameRNG'];

$insert = mysql_query("INSERT INTO gameinstance (gameID, gameRNGResult, gameDateTime) VALUES ('$gameID', '$gameRNG', now())");
if(!$insert){
	echo <?xml version="1.0"?>';
        echo '<dataxml>';
	die("There's little problem: ".mysql_error());
	$MyError = "An error occured while saving data. Please try again later." + mysql_error();
	echo "<sqlError>".$MyError."</sqlError>";
	echo '</dataxml>';
} else {
	   $gameInstanceNo = $insert;
	   mysql_query("UPDATE gameInstance SET gameInstance_No='$gameInstanceNo' WHERE USN_Gameinstance='$gameInstanceNo'"); 
	   echo '<?xml version="1.0"?>';
           echo '<dataxml>';
	   $success = mysql_insert_id();
	   echo "<success>".$success."</success>";
	   echo '</dataxml>';
}

?> 

[PFMaBiSmAd]

Dtonlinegames, the change you made to the code is meaningless because the value returned by an insert query is only a TRUE or FALSE value, depending on if the query succeeded or failed. mysql_insert_id() exists and was being used for a very specific purpose in the code.

 

blue-genie, what operating system are you using because the table names gameinstance and gameInstance are not the same on operating systems that are case-sensitive.

[blue-genie]

i'm using a linux server in my final thing.

testing on xampp on XP in localhost.

 

maybe that's the problem will test it this evening and let you know.

 

[PFMaBiSmAd]

I'll guess that on the live server the UPDATE query is failing because the table by that name/capitalization does not exist. You are looking in the first/only table for a value as the result of the UPDATE query that will never be present because it was attempted on a different table.