Select and Delete from Guestbook

[Draakje]

Hi all ,

 

After google it many times , i came here to ask something. I'm currently busy with an admin page to modify my guestbook etc etc.

 

I look 100 times in my code but can't find the error . I have an radiobuttion lists with an select from my guest book , if check box checked and i put on delete button the message must be deleted. But i'ts not working. 

 

I have database connection i can see all rows only thing that is NOT working is the delete button.

 

Here is my code :

 

// Connect to server and select databse.
mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db("$db_name")or die("cannot select DB");

$sql="SELECT * FROM $tbl_name";
$result=mysql_query($sql);

$count=mysql_num_rows($result);

?>
<table width="100%" border="0" cellspacing="1" cellpadding="0">
<tr>
<td><form name="form1" method="post" action="">
<table width="100%" border="0" cellpadding="3" cellspacing="1" bgcolor="#CCCCCC">
<tr>
<td bgcolor="#FFFFFF"> </td>
<td colspan="4" bgcolor="#FFFFFF"><strong>Huidige gastenboek berichten</strong> </td>
</tr>
<tr>
<td align="center" bgcolor="#FFFFFF">#</td>
<td align="center" bgcolor="#FFFFFF"><strong>Id</strong></td>
<td align="center" bgcolor="#FFFFFF"><strong>Naam</strong></td>
<td align="center" bgcolor="#FFFFFF"><strong>Email Adres</strong></td>
<td align="center" bgcolor="#FFFFFF"><strong>Bericht</strong></td>
<td align="center" bgcolor="#FFFFFF"><strong>Datum Plaatsing</strong></td>
</tr>
<?php
while($rows=mysql_fetch_array($result)){
?>
<tr>
<td align="center" bgcolor="#FFFFFF"><input name="checkbox[]" type="checkbox" id="checkbox[]" value="<? echo $rows['id']; ?>"></td>
<td bgcolor="#FFFFFF"><? echo $rows['id']; ?></td>
<td bgcolor="#FFFFFF"><? echo $rows['naam']; ?></td>
<td bgcolor="#FFFFFF"><? echo $rows['email']; ?></td>
<td bgcolor="#FFFFFF"><? echo $rows['bericht']; ?></td>
<td bgcolor="#FFFFFF"><? echo $rows['datum']; ?></td>
</tr>
<?php
}
?>
<tr>
<td colspan="5" align="center" bgcolor="#FFFFFF"><input name="delete" type="submit" id="delete" value="Delete"></td>
</tr>
<?
// Check if delete button active, start this 
if($delete){
for($i=0;$i<$count;$i++){
$del_id = $checkbox[$i];
$sql = "DELETE FROM $tbl_name WHERE id='$del_id'";
$result = mysql_query($sql);
}

// Wanneer succes vol opnieuw pagina laden.
if($result){
echo "<meta http-equiv=\"refresh\"content=\"0;URL=member-index.php\">";
}
}
mysql_close();
?>
</table>
</form>
</td>
</tr>
</table>
[\code]

thx for help.

Kind regards,

[jon23d]

$checkbox[$i] does not exist, $_POST['checkbox'][$i] perhaps?

[Draakje]

$checkbox[$i] does not exist, $_POST['checkbox'][$i] perhaps?

 

not working.

[jon23d]

I'm sorry, I should be more explicit.  $checkbox was never set anywhere, so....; however, $_POST['checkbox'][$i] will loosely evaluate to a boolean.  In other words:

 

if ($_POST['checkbox'][$i]) {

  // then perform your action here

}

 

But that isn't your only problem, you are also checking for ($delete), this is another variable you aren't setting.

 

Furthermore, not to be too picky, you are starting your form in a <TD>, instead consider wrapping your form around your table.  But really, $delete is causing it to never be evaluated anyway.

[Draakje]

I'm sorry, I should be more explicit.  $checkbox was never set anywhere, so....; however, $_POST['checkbox'][$i] will loosely evaluate to a boolean.  In other words:

 

if ($_POST['checkbox'][$i]) {

  // then perform your action here

}

 

But that isn't your only problem, you are also checking for ($delete), this is another variable you aren't setting.

 

Furthermore, not to be too picky, you are starting your form in a <TD>, instead consider wrapping your form around your table.  But really, $delete is causing it to never be evaluated anyway.

 

Can Someone Help me please to code that my knowledge is basic . Thx in advance

[RichardRotterdam]

I have database connection i can see all rows only thing that is NOT working is the delete button.

It's not as simple as that. A button doesn't delete records a query does.

I advice you to not mix your logic with your html try to separate those. To be honest I would start over again your code is a mess.

 

Also I don't see $_POST, $_GET or $_REQUEST anywhere in your code you are not using register globals are you?