Simplify My Code

[jkkenzie]

Do I have to use the Do....While Twice within each other??

An error shows up after some time like this: Fatal error: Maximum execution time of 60 seconds exceeded in C:\xampp\htdocs\INVESTMENTS\reports\test.php on line 60.

 

<?php
mysql_select_db($database_app_conn, $app_conn);
$query_rs_x = "SELECT DISTINCT Id FROM shares ORDER BY Amount DESC";
$rs_x = mysql_query($query_rs_x, $app_conn) or die(mysql_error());

do{





$query_rs_events = "SELECT DISTINCT Id, Pk,  SUM(Amount) as Total FROM shares WHERE NOT(Description='Safaricom Corporate') AND shares.Amount>'19999' AND Id='".$row_rs_x['Id']."'";

$rs_events = mysql_query($query_rs_events, $app_conn) or die(mysql_error());

//$totalRows_rs_events = mysql_num_rows($rs_events);
do{
if($row_rs_events['Total']>19900){



$query_rs_mem = "SELECT RecID, ID_Number, Emo_Number, First_Name, Middle_Name, Last_Name, Address FROM members WHERE  ID_Number='".$row_rs_events['Id']."'";
$rs_mem = mysql_query($query_rs_mem, $app_conn) or die(mysql_error());
$row_rs_mem = mysql_fetch_assoc($rs_mem);


$perval=floor($row_rs_events['Total']/20000);
$val= floor($row_rs_events['Total']);

//Split into Number Positioning = tens, hundreds....
$parts = array();
    $div = pow(10, strlen($perval) - 1);
    $n = $perval;

    while ($div >= 1) {
$parts[$div] = (int) ($n / $div) * $div;
$n = $n % $div;
$div /= 10;



  $count==0;  
  $count++;
  $m=$count%2;

  if ($m==0)
  { 
  echo '<tr class="cms_cont1">';
  }
  else{
  echo '<tr class="cms_cont">';
  }
   }

     ?>
                        <td valign="top" class="content"><?php echo date('d-m-Y');?></td>
                        <td valign="top" class="content"><?php echo $row_rs_mem['ID_Number'];?></td>
                        <td valign="top" class="content"><?php echo $row_rs_mem['Emo_Number']; ?></td>
                        <td valign="top" class="content"><?php echo $row_rs_mem['First_Name']; ?></td>
                        <td valign="top" class="content"><?php echo $row_rs_mem['Middle_Name']; ?></td>
                        <td valign="top" class="content"><?php echo $row_rs_mem['Last_Name']; ?></td>
                        <td valign="top" class="content"><?php echo $row_rs_mem['Address'];?></td>
                        <td valign="top" class="content"><?php echo $row_rs_events['Pk']; ?></td>
                        <td valign="top" class="content"><?php echo $row_rs_events['Total']; ?></td>
                        <td valign="top" class="content"><?php echo convert_number($val); ?></td>
                        <td valign="top" class="content"><?php echo $row_rs_events['Total']/20000; ?></td>
                        <td valign="top" class="content"><?php echo floor($row_rs_events['Total']/20000); ?></td>
                        <td valign="top" class="content"><?php echo convert_number($parts[1]); ?></td>
                        <td valign="top" class="content"><?php echo convert_number($parts[10]); ?></td>
                        <td valign="top" class="content"><?php echo convert_number($parts[100]); ?></td>
                        <td valign="top" class="content"><?php echo convert_number($parts[1000]); ?></td>
                        <td valign="top" class="content"><?php echo convert_number($parts[10000]); ?></td>
                        <td valign="top" class="content"><?php echo convert_number($parts[100000]); ?></td>
                        <td valign="top" class="content"><?php echo convert_number($parts[1000000]); ?></td>
                        <td valign="top" class="content"><?php echo convert_number($parts[10000000]); ?></td>
                      
                      <td align="center" valign="top" class="content"><div align="center"><a href="preview.php?id=<?php echo $row_rs_events['RecID']; ?>">
                        <?php  

			  $var3=$row_rs_events['RecID'];
			  if ($var3=="")
			  {
			  echo "";
			  }
			  else{
			 echo "<img src=\"pix/view.gif\"  align=\"middle\" border=\"0\">";
			  }
			  ?>
                      </a></div></td>
                      <td align="center" valign="top" class="content"><div align="center"><a href="cert.php?id=<?php echo $row_rs_events['RecID']; ?>">
                        <?php  

			  $var3=$row_rs_events['RecID'];
			  if ($var3=="")
			  {
			  echo "";
			  }
			  else{
			 echo "<img src=\"pix/remove.gif\"  align=\"middle\" border=\"0\">";
			  }
			  ?>
                      </a></div></td>
                    </tr>
                    <?php 

                    








}
}while($row_rs_events = mysql_fetch_assoc($rs_events));







}while($row_rs_x = mysql_fetch_assoc($rs_x));


?>

[jkkenzie]

I had tried this for mysql but it gave me FEW results as compared to above:

 

$query_rs_events = "SELECT a.RecID, a.ID_Number, a.Emo_Number, a.First_Name,a.Middle_Name, a.Last_Name, a.Address, b.ShareValue, b.Id, b.Pk, b.Type FROM members a INNER JOIN (SELECT Id, Type, Pk, SUM(Amount) AS ShareValue FROM shares WHERE NOT(Description='Safaricom Corporate') GROUP BY Amount DESC) b ON a.ID_Number = b.Id";