[SOLVED] sql error

[purencool]

I have been looking at this code for 20mins and can't work out what I am doing wrong. There is something wrong with my sql statement below is the error and the code. what I am trying to do is to

edit some information that is already in the database

 

Any help would be great.

 

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'active=1 content='dafasdsdfasgbvfgf gasd' at line 3

 

    private function insertq() {

        if  ( !empty($this->pageName) && !empty($this->position) && !empty($this->content) ) {
                                                echo $this->pageName ."   pn<br>";
                        echo $this->position ."   pos<br>";
                        echo $this->content."  con<br>";
                        echo $this->active."   act<br>";

                $query = "UPDATE webContent SET
                                      myOrder =$this->position
                                      active=$this->active 
                                      content='$this->content'
                                      WHERE pageName = '$this->pageName'";

                  if (mysql_query($query)) {
                      echo("<P>Your update has been added.</P>");
                  } else {
                      echo("<P>Error adding submitted update: " .
                          mysql_error() . "</P>");
                  }
                         

            }
        
        return $returnValue;

    }

[Mchl]

Please change

echo("<P>Error adding submitted update: " .
                          mysql_error() . "</P>");

 

to

 

echo("<P>Error adding submitted update: " .
                          mysql_error() . ": $query</P>");

 

This will display full query string, so that we might look at it and try to find out what's wrong.

[PFMaBiSmAd]

SET expects a comma separated list -

 

myOrder =$this->position,

active=$this->active,

content='$this->content'

[Mchl]

Good one

[purencool]

I tried it with the commas still did not work. Below the following error came up with the change error handler

 

Error adding submitted update: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' content='dafasdsdfasgbvfgf gasdasdfsdfsd' at line 3: UPDATE webContent SET myOrder =5, active= , content='dafasdsdfasgbvfgf gasdasdfsdfsdfsdf', WHERE pageName = 'ffdadfadfsadfsdfsdfas'

[Mchl]

In your query you can see:

active= ,

 

which means $this->active is not set.

[purencool]

yes I thought that to when I saw it but

 

Error adding submitted update: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE pageName = 'ffdadfadfsadfsdfsdfas'' at line 5: UPDATE webContent SET myOrder =5, active=1 , content='dafasdsdfasgbvfgf gasdasdfsdfsdfsdf', WHERE pageName = 'ffdadfadfsadfsdfsdfas'

[Mchl]

Too much commas. There should be no comma before WHERE

[PFMaBiSmAd]

And in reply#4 you did not have a comma there (nor did anyone show putting one there.) Why did it get added?

[purencool]

the short answer is I stuffed up

 

thank you for your help