String Search unknown text

[icekat83]

Hi everyone,

 

I have a problem, where what I'm trying to do works, but it feels clumsy. I'm hoping someone can help me improve my code.

 

Basically I have a page of variables and I'm trying to make a self install script, much like how you self install wordpress or something. At the moment I'm trying to change the name and age in the contents of the page. Not the variable (because I need it to still be there when the person leaves and then comes back) but the actually hard text in my file.

 

Rather than try and explain all the code I'm going to put a copy of it below. The idea is that eventually a user could fill in a form with say the mysql table details and my script will take them and put them in a file like settings.php. At the moment I'm just trying to get the code right but as I said it feels clumsy and relies heavily on the comment. I'd really prefer this to not rely on a comment to work so I'm hoping for some ideas. Of course any feed back on efficiency or security is also much appreciated.

 

Thanks everyone,

Alanna.

 

BTW - I know the variable names aren't great. I found an example online (thank goodness) and only now that I understand it do I want to edit it. I will change the variable names later.

 

Variables.php:

[pre]<?php

$hard_name = "IceKat83"; //replace with name// -- comment VITAL!

$hard_age = "1064"; //replace with age// -- comment VITAL!

?>[/pre]

Processor.php:

[pre]<?php

require("variables.php");

$name = $_POST['name'];

$age  = $_POST['age'];

 

if((($name != "") || ($name != $hardname)) && (($age != "") || ($age != $hardage))){

// get contents of the file into a string

$filename = "variables.php";

$handle = fopen($filename, "r");

$contents = fread($handle, filesize($filename));

fclose($handle);

 

// find start of the text

$startpos = strpos ( $contents, '$hard_name = "');

 

// account for the offset

$startpos = $startpos + 14;

 

// find end of title text

$endpos = strpos ( $contents, '"; //replace with name//', $startpos);

 

// get the length of the title

$title_len = ($endpos - $startpos);

//echo "Var Len: ".$title_len."<br />";

 

// clip out that chunk

$newtitle = substr ( $contents, $startpos, $title_len);

 

// crop new title if necessary

$newtitle = substr ( $newtitle, 0, 120);

 

 

//print "New Name: $newtitle<br>";

 

//echo "Now replace the string...<br />";

 

// do the S&R

$contents = str_replace ( '$hard_name = "'.$newtitle.'";', '$hard_name = "'.$name.'";', $contents );

///////////////////////////////////////////////////////////////////////////////////////////////////////////

// find start of the text

$startpos2 = strpos ( $contents, '$hard_age = "');

 

// account for the offset

$startpos2 = $startpos2 + 13;

 

// find end of title text

$endpos2 = strpos ( $contents, '"; //replace with age//', $startpos);

 

// get the length of the title

$title_len2 = ($endpos2 - $startpos2);

//echo "Var Len: ".$title_len2."<br />";

 

// clip out that chunk

$newtitle2 = substr ( $contents, $startpos2, $title_len2);

 

// crop new title if necessary

$newtitle2 = substr ( $newtitle2, 0, 120);

 

 

//print "New Age: $newtitle2<br>";

 

//echo "Now replace the string...<br />";

 

// do the S&R

$contents = str_replace ( '$hard_age = "'.$newtitle2.'";', '$hard_age = "'.$age.'";', $contents );

/////////////////////////////////////////////////////////////////////////////////////////////////////////

// Let's make sure the file exists and is writable first.

if (is_writable($filename)) {

 

 

  if (!$handle = fopen($filename, 'w+')) {

        echo "Cannot open file ($filename)<br>";

        exit;

  }

 

 

 

  // Write $contents to our opened file.

  if (fwrite($handle, $contents) === FALSE) {

      echo "Cannot write to file ($filename)<br>";

      exit;

  }

 

  //echo "Success, wrote content to file ($filename)<br>";

 

  fclose($handle);

header("location:index.php?msg=1");

 

} else {

  //echo "The file $filename is not writable<br>";

  header("location:index.php?msg=2");

}

}

?>[/pre]