finding true/false

[monkeytooth]

Im not superbly versed with javascript. So I come and ask.

 

I have a function:

			if(defaults.nospace)
		{
			var pattern = new RegExp('[ ]+', 'g');

			val = val.replace(pattern, '');
		}

 

Well thats an if-else from it, but the one in question. the function itself is something that filters text inputs forces them to be letters only, letters and numbers, numbers only, uppercase, lowercase, etc.. issue is, is the above snipplet, you can set it to true or false. and if set to true its supposed to remove the spaces if its set to false its supposed to leave the spaces. Question is, that doesn't to me look as though its looking for one or the other, it seems like its only looking for if its set.. can anyone help me out, tell me how i can make that find the true|false?

[salathe]

It is "finding" true/false.  The if expects a condition that evaluates to either true or false. In this case the condition is simply the value of defaults.nospace. So, if that is false then what is inside the if block will not be executed (i.e., spaces will not be removed from val). If it is true then the spaces in val will be removed.

 

If you wanted to be super-specific, you could change the if line to read if (defaults.nospace == true) but that wouldn't change behaviour for true/false values.

 

[ot]

Since you're not superbly versed with JavaScript, I don't know whether you know about the shorthand form of writing regular expressions in JS.  Instead of using new RegExp, you can use the form /regex/modifiers where regex is your regular expression ([ ]+) and modifiers are your pattern modifiers (g).  To put this into context, your own code could be written in the two following ways:

 

if (defaults.nospace)
{
    var pattern = /[ ]+/g;
    val = val.replace(pattern, '');
}

 

if (defaults.nospace)
{
    val = val.replace(/[ ]+/g, '');
}

 

Also note that since your character class ([…]) only contains one value (the space) it is not strictly necessary. The regexp might as well be / +/g which would work in exactly the same manner.

[/ot]