Help with code.

[Oedwards]

I am trying to get this script to run but i get the error

 

Parse error: syntax error, unexpected $end in /home/pdgeman/public_html/Register.php on line 18

 

I have tried all sorts of stuff.. please help me!

 

Here is the code:

<?
$DBhost = "localhost";
$DBuser = "";
$DBpass = "";
$DBName = "";
$table  = "";
$uname = $_POST['uname'];
$pass = $_POST['pass']; 

mysql_connect($DBhost,$DBuser,$DBpass);
@mysql_select_db("$DBName");

$query = mysql_num_rows(mysql_query("SELECT * FROM usernames WHERE username='$uname'"));
if(username == '$uname');
    {
    die();
$result = mysql_query($query);
?>

[rajivgonsalves]

You missed out a closing brackets, this

 

if(username == '$uname');
    {
    die();
$result = mysql_query($query);

should be

 

if(username == '$uname');
    {
    die();
$result = mysql_query($query);
}

 

[Oedwards]

Oh.... lol. I am very new at this type of coding, I usually just copy and paste. I am going to try it now.

[Oedwards]

<?
$DBhost = "localhost";
$DBuser = "";
$DBpass = "";
$DBName = "";
$table  = "";
$uname = $_POST['uname'];
$pass = $_POST['pass']; 

mysql_connect($DBhost,$DBuser,$DBpass);
@mysql_select_db("$DBName");

$query = mysql_num_rows(mysql_query("SELECT * FROM usernames WHERE username='$uname'"));
if(username == '$uname')
die();
else
$SQL = "INSERT INTO $table (Username, Password) VALUES ('$uname' , '$pass')";
$result = mysql_query($query);
?>

 

this is my current code, it doesn't display an error but it doesn't add anything to the database either... I am so lost.

 

Someone told me this code wouldn't work but didn't explain why.. does anybody know?

[rajivgonsalves]

I would just like to say logical errors right code would be

 

<?php
$DBhost = "localhost";
$DBuser = "";
$DBpass = "";
$DBName = "";
$table  = "";


mysql_connect($DBhost,$DBuser,$DBpass) or die('Cannot connect to database');
mysql_select_db($DBName) or die('Cannot select database');

$uname = isset($_POST['uname']) ? mysql_real_escape_string($_POST['uname']) : '';
$pass = isset($_POST['pass']) ? mysql_real_escape_string($_POST['pass']) : '';


$result = mysql_query("SELECT * FROM usernames WHERE username='$uname'") or die('Cannot Execute Query:'.mysql_error());
$rows = mysql_num_rows($result);
if($rows > 0) {
   die('Username already exists');
}
else {
   $query = "INSERT INTO $table (Username, Password) VALUES ('$uname' , '$pass')";
   $result = mysql_query($query);
}
?>

[Oedwards]

dude, you are awesome, doesn't explain to me why it wouldn't work, but none the less, at least it works now..

[rajivgonsalves]

actually if you compare the two codes you will know where you went wrong