Empty not empty?

[smordue]

I am using the following code, if there is data in the line it works fine, if there is no data in the line it still prints <li></li><li>|</li>, Could this have to do with the \n in the filewrite?

 

		<?
	$file = file('basedata.txt');
	if(!empty($lines[3]))
	{
	   echo "<li>" . $lines[3] . "</li>" ;
	   echo "<li>|</li>";
	}
	?> 

 

basedata.txt:

 

A Company Name

We are the best

123 Pine Street

 

Tampa

FL

33509

 

[mrMarcus]

where is $lines being defined?

[smordue]

Should

 

$file = file('basedata.txt');

 

be

 

$lines = file('basedata.txt');

 

?

 

I thought I had tried that...

[smordue]

Also, it works if there is data in the line

[rajivgonsalves]

Yes that is due to the newline, I would suggest the following

 

     

<?php
      $lines = file('basedata.txt');
      $lines[3] = preg_replace("#[\r\n]+$#", '', $lines[3]);
      if(!empty($lines[3]))
      {
         echo "<li>" . $lines[3] . "</li>" ;
         echo "<li>|</li>";
      }
      ?>

[smordue]

That's what I needed, thanks alot

[salathe]

You can pass a few flags to the file function and one of those will be particularly useful here.

 

$lines = file("basedata.txt", FILE_IGNORE_NEW_LINES);

if ( ! empty($lines[3]))
{
echo "<li>$lines[3]</li><li>|</li>";
}

 

Bear in mind that empty will return true for more than just a zero-length string (e.g. "0").