Php Url parameter

[adamriley]

Hi my php code is

 

--------------------------------------------------------------

<?php

if (isset($_GET['a']) && $_GET['a'] != "") {

if (isset($_GET['b']) && $_GET['b'] != "") {

$a = $_GET['a'];

$b = $_GET['b'];

if (file_exists('pages/'.$a.'.$b')) {

@include ('pages/'.$a.'.$b');

} elseif (!file_exists('pages/'.$a.'.$b')) {

echo 'Page you are requesting doesnt exist';

}

} else {

@include ('pages/1.php');

}

?>

---------------------------------------------

my url is "sitemap.php?a=1&b=php"

--------------------------------------------

 

could you say why its not working im a beginner

[sh0wtym3]

What error are you getting?

 

 

And if you don't see any errors just add:

error_reporting(E_ALL);

... to the top of your code.

[rajivgonsalves]

for us to help you, you will have to elaborate on whats not working, you must tell us

 

1) Whats the result

2) What was the expected result

[Buddski]

Are you getting any errors?

put this at the top of your script..

error_reporting(E_ALL);
ini_set('display_errors',1);

And remove the @ symbols..

[adamriley]

ok what i get is "Parse error: syntax error, unexpected $end in /home/a162162/public_html/sitemap.php on line 47"

 

what i expected is the file that was named in the "a=1" and the file format that was "b=php"

[Buddski]

you are missing a } at the end of your script..

formatting helps find these things out

<?php
if (isset($_GET['a']) && $_GET['a'] != "") {
if (isset($_GET['b']) && $_GET['b'] != "") {
	$a = $_GET['a'];
	$b = $_GET['b'];
	if (file_exists('pages/'.$a.'.$b')) {
		@include ('pages/'.$a.'.$b');
	} elseif (!file_exists('pages/'.$a.'.$b')) {
		echo 'Page you are requesting doesnt exist';
	}
} else {
	@include ('pages/1.php');
}
}
?>

[adamriley]

This part of the script is now solved but now it seems that it cannot find the page when i try the script with 1 parameter. The script excludes the "Page you are requesting doesnt exist" 

[adamriley]

This part of the script is now solved but now it seems that it cannot find the page when i try the script with 1 parameter. The script excludes the "Page you are requesting doesnt exist" 

 

Sorry that one is very confusing what i ment is that bit of the script now works but the script now says "Page you are requesting doesnt exist"

[Buddski]

You need to simplify the code down a bit..

if (file_exists('pages/'.$a.'.$b')) {
         @include ('pages/'.$a.'.$b');
      } elseif (!file_exists('pages/'.$a.'.$b')) {
         echo 'Page you are requesting doesnt exist';
      }

can be simply put as

if (file_exists('pages/'.$a.'.$b')) {
         @include ('pages/'.$a.'.$b');
      } else {
         echo 'Page you are requesting doesnt exist';
      }

because you already know the page doesnt exist...

 

Here is a cleaner version..

<?php
if (isset($_GET['a']) && isset($_GET['b']) && $_GET['a'] != '' && $_GET['b'] != '') {
$a = $_GET['a'];
$b = $_GET['b'];
if (file_exists('pages/'.$a.'.$b')) {
	include('pages/'.$a.'.$b');
} else {
	echo 'Page you are requesting doesnt exist';
}
} else {
include ('pages/1.php');
}
?>

Make sure that your directory structure matches what you are testing for..

 

[adamriley]

Hi thanks my directory structure matches what you i am testing for and the script still does not dissplay what i want it to

 

[Buddski]

You could infact ignore that file_exists..

<?php
if (isset($_GET['a']) && isset($_GET['b']) && $_GET['a'] != '' && $_GET['b'] != '') {
   $a = $_GET['a'];
   $b = $_GET['b'];
   if (!@include('pages/'.$a.'.'.$b)) {
     echo 'Page you are requesting doesnt exist';
   }
} else {
   include ('pages/1.php');
}
?>

 

Edit:

I just noticed an error which is gone in the code above

'pages/'.$a.'.$b'

would be looking for 1.$b

[adamriley]

The script still does not work :confused:

[Buddski]

Did you use the last edited version I posted?

<?php
if (isset($_GET['a']) && isset($_GET['b']) && $_GET['a'] != '' && $_GET['b'] != '') {
   $a = $_GET['a'];
   $b = $_GET['b'];
   if (!@include('pages/'.$a.'.'.$b)) {
     echo 'Page you are requesting doesnt exist';
   }
} else {
   include ('pages/1.php');
}
?>

[adamriley]

Ok thanks the script does now work which part of the script did you change

[Buddski]

Just

'pages/'.$a.'.$b'

to 'pages/'.$a.'.'.$b

[adamriley]

so if i was to add a third parameter what would i need to add

[Buddski]

What will the 3rd parameter be for?

[adamriley]

If i was to add a c parameter to the bit that says "('pages/" and put $c what would the script now be

[Buddski]

so $c would replace the word pages?

[adamriley]

yes it would so the url would be something like sitemap.php?a=1&b=php&c=pages

[Buddski]

then it would be

<?php
if (isset($_GET['a']) && isset($_GET['b']) && isset($_GET['c']) && $_GET['c'] !='' && $_GET['a'] != '' && $_GET['b'] != '') {
   $a = $_GET['a'];
   $b = $_GET['b'];
   if (!@include($c.'/'.$a.'.'.$b)) {
     echo 'Page you are requesting doesnt exist';
   }
} else {
   include ('pages/1.php');
}
?>

[adamriley]

Thanks very much for your time Buddski 

[Buddski]

Not a problem..

[adamriley]

Am i right in thinking you missed "$c = $_GET['c'];" from the script

[Buddski]

Indeed you are 5am coding is never good..