value is being lost for no reason

[jamesxg1]

Hiya peeps,

 

Heres the snippet of my code.

 

if(ereg("^[^@]{1,64}@[^@]{1,255}$", $levelone)):
$this->levelOneUser = mysql_real_escape_string(trim($levelone));
else:
return 'Registration Failed!';
endif;

$this->levelOneSelectEarnings = "SELECT `earnings`, `refcount` FROM `members` WHERE emailaddress = '$this->levelOneUser' LIMIT 1";
$this->levelOneSelectEarningsSQL = mysql_query($this->levelOneSelectEarnings);

if($this->levelOneSelectEarningsSQL == FALSE):
return 'Registeration failed!';
else:

while($this->earnings = mysql_fetch_assoc($this->levelOneSelectEarningsSQL)):
$this->levelOneSubTotal = $this->earnings['earnings'];
$this->levelOneSubRefCount = $this->earnings['refcount']+1;
endwhile;

$this->levelOneTotal = $this->levelOneSubTotal + 1.00;
$this->levelOneRefCount = $this->levelOneSubRefCount + 1;



     // the var $this->levelOneUser has the correct value until here. And then the value is dropped and i dont know why.




if($this->levelOneSelectReferralSQL == FALSE):
return 'Registeration failed!';
else:

 

Many thanks

 

James.

 

[jamesxg1]

Anyone have any ideas on why this is happening ?

 

 

Many thanks

 

James.

[PFMaBiSmAd]

Since that is not all of the relevant code (for example what did you remove from the posted code that is setting $this->levelOneSelectReferralSQL) it is not possible to tell you what logical error there is in your code that is causing the problem.

 

Also, you do know that you only need to define and use class variables when you need them to be shared between different class methods or accessed in the main code as data object of the instance of the class. You don't need to define and use $this->variable_name for every single variable that is used in a class function.

[jamesxg1]

Hiya mate,

 

Here's the full code.

 

<?php

class userControl {

private $emailaddress;
private $password;
private $passwordconf;
private $firstname;
private $lastname;
private $housenumber;
private $road;
private $city;
private $county;
private $postcode;
private $refer;
private $levelone;
private $leveltwo;

function registerUser($emailaddress, $password, $passwordconf, $firstname, $lastname, $housenumber, $road, $city, $county, $postcode, $refer) {

if(empty($refer)):
$this->refer = mysql_real_escape_string(trim('----'));
else:

if(ereg("^[^@]{1,64}@[^@]{1,255}$", $refer)):
$this->refer = mysql_real_escape_string(trim($refer));
else:
return 'Registration Failed!';
endif;

endif;

 $postcode = strtoupper(str_replace(" ","",$postcode));

if(eregi("^(GIR0AA)|(TDCU1ZZ)|((([A-PR-UWYZ][0-9][0-9]?)|"."(([A-PR-UWYZ][A-HK-Y][0-9][0-9]?)|"."(([A-PR-UWYZ][0-9][A-HJKSTUW])|"."([A-PR-UWYZ][A-HK-Y][0-9][ABEHMNPRVWXY]))))"."[0-9][ABD-HJLNP-UW-Z]{2})$", $postcode)):
    $this->postcode = mysql_real_escape_string(trim($postcode));
else:
    return 'Registration Failed!';
endif;

if(ereg("^[^@]{1,64}@[^@]{1,255}$", $emailaddress)):
$this->emailaddress = mysql_real_escape_string(trim($emailaddress));
else:
return 'Registration Failed!';
endif;

if(strlen($password) >= 6 && ereg("[a-z]", $password) && ereg("[0-9]", $password)):
$this->password = base64_encode(md5(sha1(md5(mhash(MHASH_CRC32, $password . '823ehsp2192u')))));
$this->password = mysql_real_escape_string(trim($this->password));
else:
return 'Registration Failed!';
endif;

if(strlen($passwordconf) >= 6 && ereg("[a-z]", $passwordconf) && ereg("[0-9]", $passwordconf)):
$this->passwordconf = base64_encode(md5(sha1(md5(mhash(MHASH_CRC32, $passwordconf . '823ehsp2192u')))));
$this->passwordconf = mysql_real_escape_string(trim($this->passwordconf));
else:
return 'Registration Failed!';
endif;

if(preg_match("/^\d$/", $housenumber)):
return 'Registration Failed!';
else:
$this->housenumber = mysql_real_escape_string(trim($housenumber));
endif;

if(preg_match("/^[a-zA-Z]+(([\'\,\.\-][a-zA-Z])?[a-zA-Z]*)*$/", $firstname)):
$this->firstname = mysql_real_escape_string(trim($firstname));
else:
return 'Registration Failed!';
endif;

if(preg_match("/^[a-zA-Z]+(([\'\,\.\-][a-zA-Z])?[a-zA-Z]*)*$/", $lastname)):
$this->lastname = mysql_real_escape_string(trim($lastname));
else:
return 'Registration Failed!';
endif;

if($this->password !== $this->passwordconf):
return 'Registration Failed!';
else:

$this->time = date('H:i:s');
$this->date = date('Y-m-d');
$this->road = mysql_real_escape_string(trim($road));

$this->registerInsert = "INSERT INTO `members` (`emailaddress`, `firstname`, `lastname`, `password`, `housenumber`, `road`, `city`, `county`, `postcode`, `time`, `date`, `refcount`, `earnings`) VALUES('$this->emailaddress', '$this->firstname', '$this->lastname', '$this->password', '$this->housenumber', '$this->road', '$this->city', '$this->county', '$this->postcode', '$this->time', '$this->date', '0', '0')";
$this->referrerInsert = "INSERT INTO `referrals` (`referrer`, `member`, `time`, `date`) VALUES('$this->refer', '$this->emailaddress', '$this->time', '$this->date')";

if(mysql_query($this->registerInsert) == FALSE):
return 'Registeration failed!';
else:

if(mysql_query($this->referrerInsert) == FALSE):
return 'Registeration failed!';
else:

$this->levelOne($this->refer);

endif;
endif;
endif;
}

function levelOne($levelone) {

if(ereg("^[^@]{1,64}@[^@]{1,255}$", $levelone)):
$this->levelOneUser = mysql_real_escape_string(trim($levelone));
else:
return 'Registration Failed!';
endif;

$this->levelOneSelectEarnings = "SELECT `earnings`, `refcount` FROM `members` WHERE emailaddress = '$this->levelOneUser' LIMIT 1";
$this->levelOneSelectEarningsSQL = mysql_query($this->levelOneSelectEarnings);

if($this->levelOneSelectEarningsSQL == FALSE):
return 'Registeration failed!';
else:

while($this->earnings = mysql_fetch_assoc($this->levelOneSelectEarningsSQL)):
$this->levelOneSubTotal = $this->earnings['earnings'];
$this->levelOneSubRefCount = $this->earnings['refcount']+1;
endwhile;

$this->levelOneTotal = $this->levelOneSubTotal + 1.00;
$this->levelOneRefCount = $this->levelOneSubRefCount + 1;


// var being dropped here!.


if($this->levelOneSelectReferralSQL == FALSE):
return 'Registeration failed!';
else:

$this->levelOneSelectReferral = "SELECT `referrer` FROM `referrals` WHERE member = '$this->levelOneUser' LIMIT 1";
$this->levelOneSelectReferralSQL = mysql_query($this->levelOneSelectReferral);

while($this->referrer = mysql_fetch_assoc($this->levelOneSelectReferralSQL)):
$this->referrer = $this->referrer['referrer'];
endwhile;

$this->levelOneInsert = "UPDATE `members` SET earnings = '$this->levelOneTotal', refcount = '$this->levelOneRefCount' WHERE emailaddress = '$this->levelOneUser'";
$this->levelOneInsertSQL = mysql_query($this->levelOneInsert);

if($this->levelOneInsertSQL == FALSE):
return 'Registeration failed!';
else:
$this->leveltwo($this->referrer);
endif;
endif;
endif;
}
?>

 

 

Many thanks

 

James.

[Buddski]

One thing I have noticed is when you are calling

$this->levelOne($this->refer);

The levelOne function has a return but its not assigned or handled by the registerUser function at all..

 

With that said are you sure that its even getting to that part of your levelOne function?

[jamesxg1]

One thing I have noticed is when you are calling

$this->levelOne($this->refer);

The levelOne function has a return but its not assigned or handled by the registerUser function at all..

 

With that said are you sure that its even getting to that part of your levelOne function?

 

I'm not too sure I got all that lol. But yes the levelOne function gets the $this->refer var.

 

Many thanks

 

James.

[PFMaBiSmAd]

So, you are guessing that the variable in question is being lost because the symptom you see in front of you is the return of the 'Registration failed!' value from the function?

 

LOL, you are testing $this->levelOneSelectReferralSQL before the query that sets it has even been executed, so of course it is a FALSE value.

 

 

[jamesxg1]

So, you are guessing that the variable in question is being lost because the symptom you see in front of you is the return of the 'Registration failed!' value from the function?

 

LOL, you are testing $this->levelOneSelectReferralSQL before the query that sets it has even been executed, so of course it is a FALSE value.

 

Cheers for that bud, fixed! . Just wondering I know this is off topic but I have

	$this->levelOneTotal = $this->levelOneSubTotal + 1.00;

but it only inserts as '1' how do I make it insert as 1.00 as I also need to insert as 0.50 on levelTwo once I have created it and 12.05 on levelThree.

 

Many thanks

 

James.

[Buddski]

Most people use return for functions like yours to return true or false..

so then in your main function (registerUser) you will do something like this.

 if ($this->levelOne($this->refer)) { // This is assuming that it returns true on success and false of failure
echo 'Yay it worked';
} else {
echo 'Epic Fail';
}

 

Also.. this line

$this->refer = mysql_real_escape_string(trim('----'));

doesnt need to be that complex because you are defining the value and I dont think you are going to do some sql injection on yourself .. I have been wrong before

 

EDIT: What is your tables field type that is storing those values?

[jamesxg1]

Cheers bud, I shall use that code. And VARCHAR, INT's ect.

 

Iv sorted the number formatting.

[Buddski]

So you dont need help with the last question?

[jamesxg1]

Nah all cool and working now . Is there a way of exiting a class properly ? return ? or something else ?

 

Many thanks

 

James.