Wrong Password

[eazyefolife]

Everytime I type in something, even if the password and name is RIGHT I get a error code:

 

http://comptons.pastebin.com/m3715aac1

[jskywalker]

try to echo the username and password to your screen, and see if they really have the value you expect them to be...

[eazyefolife]

echo $myusername;

echo $mypassword;

 

??

[wildteen88]

... I get a error code:

Can you post the error your are getting?

[eazyefolife]

... I get a error code:

Can you post the error your are getting?

 

Wrong Username or Password. please go back.

[wildteen88]

How are your storing your password in the database? Do you use any form of encryption? Such as md5, sha1 etc.

[eazyefolife]

How are your storing your password in the database? Do you use any form of encryption? Such as md5, sha1 etc.

 

With nothing

[wildteen88]

Just looking at your code again. Where are you connecting to your database?

[eazyefolife]

Just looking at your code again. Where are you connecting to your database?

 

On top of the script in:

 

<?php include("sql.php"); ?>

 

[wildteen88]

I have added some debug code.

<?php

$myusername = mysql_real_escape_string(stripslashes($_POST['username']));
$mypassword = mysql_real_escape_string(stripslashes($_POST['mypassword']));

$result = mysql_query("SELECT * FROM users WHERE Name = '$myusername' AND Password='$mypassword'");
$count = mysql_num_rows($result);
if($count==1)
{
session_register("myusername");
session_register("mypassword");
header("location:login_success.php");
}
else
{
    echo '<h1>DEBUG IT</h1>';

    echo '<p>Match Username (<i>'.$myUsername.'</i>)... ';

    $query = mysql_query("SELECT Password FROM users WHERE name='$myusername'");

    if(mysql_num_rows($query) > 0)
    {
        echo 'SUCCESS';

        echo '<p>Match password... ';

        list($dbPassword) = mysql_fetch_row($query);

        if($myPassword == $dbPassword)
            echo 'SUCCESS';
        else
        {
            echo 'FAIL!';

            echo '<p>Password is wrong what is it?';

            echo '$myPassword = \''.$myPassword.'\'<br />';
            echo '$dbPassword = \''.$dbPassword.'\'';
        }
    }
    else
    {
        echo 'FAIL!';
    }

     echo "Wrong Username or Password. please go back.";
}
?>

Run that code and post the output. Make sure you are filling in your login form and running the above code directly.

[eazyefolife]

I have added some debug code.

<?php

$myusername = mysql_real_escape_string(stripslashes($_POST['username']));
$mypassword = mysql_real_escape_string(stripslashes($_POST['mypassword']));

$result = mysql_query("SELECT * FROM users WHERE Name = '$myusername' AND Password='$mypassword'");
$count = mysql_num_rows($result);
if($count==1)
{
session_register("myusername");
session_register("mypassword");
header("location:login_success.php");
}
else
{
    echo '<h1>DEBUG IT</h1>';

    echo '<p>Match Username (<i>'.$myUsername.'</i>)... ';

    $query = mysql_query("SELECT Password FROM users WHERE name='$myusername'");

    if(mysql_num_rows($query) > 0)
    {
        echo 'SUCCESS';

        echo '<p>Match password... ';

        list($dbPassword) = mysql_fetch_row($query);

        if($myPassword == $dbPassword)
            echo 'SUCCESS';
        else
        {
            echo 'FAIL!';

            echo '<p>Password is wrong what is it?';

            echo '$myPassword = \''.$myPassword.'\'<br />';
            echo '$dbPassword = \''.$dbPassword.'\'';
        }
    }
    else
    {
        echo 'FAIL!';
    }

     echo "Wrong Username or Password. please go back.";
}
?>

Run that code and post the output. Make sure you are filling in your login form and running the above code directly.

 

Wrong password:

 

Match Username ()... SUCCESS

Match password... FAIL!

Password is wrong what is it?$myPassword = ''
$dbPassword = '123456'Wrong Username or Password. please go back.

 

Right password:

 

Match Username ()... SUCCESS

Match password... FAIL!

Password is wrong what is it?$myPassword = ''
$dbPassword = '123456'Wrong Username or Password. please go back. 

 

:'(

[wildteen88]

Woops. Try

<?php

$myusername = mysql_real_escape_string(stripslashes($_POST['username']));
$mypassword = mysql_real_escape_string(stripslashes($_POST['mypassword']));

$result = mysql_query("SELECT * FROM users WHERE Name = '$myusername' AND Password='$mypassword'");
$count = mysql_num_rows($result);
if($count==1)
{
session_register("myusername");
session_register("mypassword");
header("location:login_success.php");
}
else
{
    echo '<h1>DEBUG IT</h1>';

    echo '<p>Match Username (<i>'.$myusername.'</i>)... ';

    $query = mysql_query("SELECT Password FROM users WHERE name='$myusername'");

    if(mysql_num_rows($query) > 0)
    {
        echo 'SUCCESS';

        echo '<p>Match password... ';

        list($dbPassword) = mysql_fetch_row($query);

        if($mypassword == $dbPassword)
            echo 'SUCCESS';
        else
        {
            echo 'FAIL!';

            echo '<p>Password is wrong what is it?<br />';

            echo '$mypassword = \''.$mypassword.'\'<br />';
            echo '$dbPassword = \''.$dbPassword.'\'';
        }
    }
    else
    {
        echo 'FAIL!';
    }

     echo "Wrong Username or Password. please go back.";
}
?>

[eazyefolife]

Woops. Try

<?php

$myusername = mysql_real_escape_string(stripslashes($_POST['username']));
$mypassword = mysql_real_escape_string(stripslashes($_POST['mypassword']));

$result = mysql_query("SELECT * FROM users WHERE Name = '$myusername' AND Password='$mypassword'");
$count = mysql_num_rows($result);
if($count==1)
{
session_register("myusername");
session_register("mypassword");
header("location:login_success.php");
}
else
{
    echo '<h1>DEBUG IT</h1>';

    echo '<p>Match Username (<i>'.$myusername.'</i>)... ';

    $query = mysql_query("SELECT Password FROM users WHERE name='$myusername'");

    if(mysql_num_rows($query) > 0)
    {
        echo 'SUCCESS';

        echo '<p>Match password... ';

        list($dbPassword) = mysql_fetch_row($query);

        if($mypassword == $dbPassword)
            echo 'SUCCESS';
        else
        {
            echo 'FAIL!';

            echo '<p>Password is wrong what is it?<br />';

            echo '$mypassword = \''.$mypassword.'\'<br />';
            echo '$dbPassword = \''.$dbPassword.'\'';
        }
    }
    else
    {
        echo 'FAIL!';
    }

     echo "Wrong Username or Password. please go back.";
}
?>

 

Even with wrong username and password I get:

 

DEBUG IT

Match Username ()... SUCCESS

Match password... FAIL!

Password is wrong what is it?
$mypassword = ''
$dbPassword = '123456'Wrong Username or Password. please go back. 

 

But with the right one, I get the same thing.

[wildteen88]

What the! How is it getting a match with no username and password! What is the username and password you're using?

[eazyefolife]

What the! How is it getting a match with no username and password! What is the username and password you're using?

 

Comptons_Eazy_E

 

Password: Test

[eazyefolife]

bump

[PFMaBiSmAd]

There's no code in your code to make a connection to the mysql server, so things like mysql_real_escape_string() are returning a null/false value.

 

You should be learning php, developing php code, and debugging php code on a system with error_reporting set to E_ALL and display_errors set to ON in your master php.ini so that php would help you by displaying all the errors it detects. You would save a huge amount of time. Stop and start your web server to get any change made to the php.ini to take effect and confirm that the two settings are actually changed using a phpinfo() statement.

 

[mattal999]

He has already stated that he is using an include to connect to the database.

 

By the way, should this:

 

$mypassword = mysql_real_escape_string(stripslashes($_POST['mypassword']));

Be:

 

$mypassword = mysql_real_escape_string(stripslashes($_POST['password']));

[PFMaBiSmAd]

Than it's likely the include statement is failing or the code in the sql.php file is failing.

 

If the last code posted is echoing nothing for the entered values, either the form is incorrect or the code is trashing the values.

[eazyefolife]

Than it's likely the include statement is failing or the code in the sql.php file is failing.

 

If the last code posted is echoing nothing for the entered values, either the form is incorrect or the code is trashing the values.

 

Can you help me with this?

[PFMaBiSmAd]

Someone already suggested how to save a ton of time by getting php to display all the errors it detects that would help point out problems -

You should be learning php, developing php code, and debugging php code on a system with error_reporting set to E_ALL and display_errors set to ON in your master php.ini so that php would help you by displaying all the errors it detects. You would save a huge amount of time. Stop and start your web server to get any change made to the php.ini to take effect and confirm that the two settings are actually changed using a phpinfo() statement.

 

I have not seen your form code posted yet, so it is also likely that the form is invalid and is not even submitting any $_POST data.

[eazyefolife]

Someone already suggested how to save a ton of time by getting php to display all the errors it detects that would help point out problems -

You should be learning php, developing php code, and debugging php code on a system with error_reporting set to E_ALL and display_errors set to ON in your master php.ini so that php would help you by displaying all the errors it detects. You would save a huge amount of time. Stop and start your web server to get any change made to the php.ini to take effect and confirm that the two settings are actually changed using a phpinfo() statement.

 

I have not seen your form code posted yet, so it is also likely that the form is invalid and is not even submitting any $_POST data.

 

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Son of Mini-Missions - Home</title>

<style type="text/css">
<!--
body {
background-image: url(http://www.jservers.co.uk/imgs/bg.png);
background-repeat: repeat;
}
#apDiv1 {
position:absolute;
left:541px;
top:296px;
width:266px;
height:26px;
z-index:1;
font-size: 16px;
font-family: Georgia, "Times New Roman", Times, serif;
font-weight: bold;
}
.loginHolder tr td b {
font-weight: bold;
}
-->
</style></head>

<body>

<div align="center">
  <p><a href="index.php"><img src="logo.jpg" width="648" height="144" /></a></p>
  <table class="loginHolder">
    <tr>
      <td><b>Player Name</b></td>
      <td><b>Password:</b></td>
    </tr>
    <tr>
      <td height="24"><input name="username" type="text" value="My_SonofMM_PlayerName" /></td>
      <td><input name="password" type="password" id="loginPassword" value="MyPassword" /></td>
    </tr>
  </table>
  <form action="login.php" method="post">
    <input type="submit" name="button" id="button" value="Login" />
  </form>
  <hr />
<p align="center"> </p>
</div>
</body>
</html>

[PFMaBiSmAd]

Your form fields are not located between the <form ...> </form> tags so they don't do anything.

 

Ref: http://w3schools.com/html/html_forms.asp

http://w3schools.com/php/php_forms.asp

[eazyefolife]

Your form fields are not located between the <form ...> </form> tags so they don't do anything.

 

Ref: http://w3schools.com/html/html_forms.asp

http://w3schools.com/php/php_forms.asp

 

So this is better?

 

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Son of Mini-Missions - Home</title>

<style type="text/css">
<!--
body {
background-image: url(http://www.jservers.co.uk/imgs/bg.png);
background-repeat: repeat;
}
#apDiv1 {
position:absolute;
left:541px;
top:296px;
width:266px;
height:26px;
z-index:1;
font-size: 16px;
font-family: Georgia, "Times New Roman", Times, serif;
font-weight: bold;
}
.loginHolder tr td b {
font-weight: bold;
}
-->
</style></head>

<body>

<div align="center">
  <p><a href="index.php"><img src="logo.jpg" width="648" height="144" /></a></p>
  <table class="loginHolder">
    <tr>
      <td><b>Player Name</b></td>
      <td><b>Password:</b></td>
    </tr>
    <tr>
      <td height="24"><form action="login.php" method="post"><input name="username" type="text" value="My_SonofMM_PlayerName" /></td>
      <td><input name="password" type="password" id="loginPassword" value="MyPassword" /></form></td>
    </tr>
  </table>
  <form action="login.php" method="post">
    <input type="submit" name="button" id="button" value="Login" />
  </form>
  <hr />
<p align="center"> </p>
</div>
</body>
</html>

[mattal999]

He has already stated that he is using an include to connect to the database.

 

By the way, should this:

 

$mypassword = mysql_real_escape_string(stripslashes($_POST['mypassword']));

Be:

 

$mypassword = mysql_real_escape_string(stripslashes($_POST['password']));

As I said yesterday, this change should be made. It is simply that your password is not getting set, because you have the wrong POST name. It should be 'password', not 'mypassword'.