warning when editing mysql using php

[Nucleus]

Hello,

 

I am using this form, to connect on MySQL database and edit the fields "FirstName", "LastName" and "PhoneNumber" in the "Employees" table.

 

<?
//connect to mysql
include 'connect.php';

//If cmd has not been initialized
if(!isset($cmd))
{
   //display all the fields
   $result = mysql_query("select * from Employees order by id");

   //run the while loop that grabs all the fields
   while($r=mysql_fetch_array($result))
   {
      //grab the title and the ID of the fields
      $ID=$r["ID"];
      $FirstName=$r["FirstName"];
      $LastName=$r["LastName"];
      $PhoneNumber=$r["PhoneNumber"];

 //make the title a link
      echo "<a href='edit.php?cmd=edit&id=$id'>$FirstName - Edit</a>";
      echo "<br>";
    }
}
?>
<?
if($_GET["cmd"]=="edit" || $_POST["cmd"]=="edit")
{
   if (!isset($_POST["submit"]))
   {
      $id = $_GET["ID"];
      $sql = "SELECT * FROM Employees WHERE id=$id";
      $result = mysql_query($sql);
      $myrow = mysql_fetch_array($result);
      ?>

      <form action="edit.php" method="post">
      <input type=hidden name="id" value="<?php echo $myrow["id"] ?>">

      First Name:<INPUT TYPE="TEXT" NAME="FirstName" VALUE="<?php echo $myrow["FirstName"] ?>" SIZE=30><br>
      Last Name:<INPUT TYPE="TEXT" NAME="LastName" VALUE="<?php echo $myrow["LastName"] ?>" SIZE=30><br>
      Phone Number:<INPUT TYPE="TEXT" NAME="PhoneNumber" VALUE="<?php echo $myrow["PhoneNumber"] ?>" SIZE=30><br>

      <input type="hidden" name="cmd" value="edit">

      <input type="submit" name="submit" value="submit">

      </form>

<? } ?>
<?
   if ($_POST["$submit"])
   {
      $FirstName = $_POST["FirstName"];
  $LastName = $_POST["LastName"];
  $PhoneNumber = $_POST["PhoneNumber"];

  $sql = "UPDATE Employees SET FirstName='$FirstName',LastName='$LastName',PhoneNumber='$PhoneNumber' WHERE id=$id";
      //replace the fields with your table name above
      $result = mysql_query($sql);
      echo "Thank you! Information updated.";
}
}
?>

 

My problem is that I get this warning message:

 

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home1/koutouro/public_html/ioannou/edit.php on line 34

 

As a result I cannot update the database.

 

I started working with PHP and MySQL yesterday, so please be patient with me.

 

Thanks.

[jammesz]

$sql = "SELECT * FROM Employees WHERE id=$id";

 

should be

 

$sql = "SELECT * FROM Employees WHERE ID=$id";

 

from what i can gather from this line

 

$ID=$r["ID"];

 

 

[Nucleus]

The warning is now gone, but the form does not display the "Thank you! Information updated" message, nor it updates the table.  :-\

[jl5501]

There is no evidence that the update query is being run.

 

You might mean if(isset($_POST['submit']))  where you have if ($_POST["$submit"])

[Nucleus]

That worked. Thank you very much! 

[Nucleus]

It seems that for some reason when I update a record, it overwrites another. 

[New Coder]

check you are actually passing the ID value, echo it somewhere, it may be empty