Update a table using information provided by a user

[AnAmericanGunner]

Hello,

 

I'm trying to create an update function using information provided by a user in a form. I have, on my edithorse.php page:

 

<? 
session_name('usersession');
session_start();

$title = "My Account";
$home = "not";
$guests = "not";
$forum = "not";
$est = "not";
$res = "not";
$my = "my";
$contact = "not";

include('../includes/database.php');
include('../includes/header.php');

$query = "SELECT * FROM mhr WHERE id='$id'"; 
$result = mysql_query($query) or die(mysql_error());

if(!isset($peacock))
{
include ('../includes/loginform.php');
include('../includes/footer.php');
exit();
}

?>

<?
if($admin == 1)
{

while($row= mysql_fetch_array($result)) {

$id = $row['id'];
$colour = $row['colour'];
$horsename = $row['horsename'];
$origin = $row['origin'];
$status = $row['status'];
$age = $row['yob'];
$colour = $row['colour'];
$breed = $row['breed'];
$gender = $row['gender'];
$height = $row['height'];
$sire = $row['sire'];
$dam = $row['dam'];
$damsire = $row['damsire'];
$disciplines = $row['disciplines'];
$ownername = $row['ownername'];
?>

<b>Horse's Information:</b> <br />
This is the horse you have selected to edit. <br /><br />

<blockquote>MHR ID#: <? echo $id ?> <br />
<? echo $horsename ?> <? echo $age ?> <? echo $colour 

?> <? echo $breed ?> <? echo $gender ?>, <? echo $height 

?> <br />
<? echo $sire ?> - <? echo $dam ?>, <? echo $damsire ?>; 

<? echo $disciplines ?>; <? echo $ownername 

?>.</blockquote>

<? } ?>

<br /><br />

If you feel that changes are in order, please make the 

appropriate changes. <br />
All drop down fields will have to either be fixed or placed on 

what they should be placed on. <br />
Status: Set this to 1 for approval. <br /><br />

<form action="edithorseproc.php" method="post"> 

<table class="horse">
<tr>
<td><input type="hidden" name="id" size="50" value="<? 

echo $id ?>"></td>
</tr>

<tr>
<td width= "150px">Horse Name: </td>
<td><input type="text" name="horsename" size= "50" 

value="<? echo $horsename ?>"></td>
</tr>

<tr>
<td>Sire: </td>
<td><input type="text" name="sire" size= "50" value="<? 

echo $sire ?>"></td>
</tr>

<tr>
<td>Dam: </td>
<td><input type="text" name="dam" size= "50" value="<? 

echo $dam ?>"></td>
</tr>

<tr>
<td>Dam's Sire: </td>
<td><input type="text" name="damsire" size= "50" 

value="<? echo $damsire ?>"></td>
</tr>

<tr>
<td>YOB: </td>
<td>
   <select name= "yob">
<option><? echo $age ?></option>
<option></option>
<option>2010</option>
<option>2009</option>
<option>2008</option>
<option>2007</option>
<option>2006</option>
<option>2005</option>
<option>2004</option>
<option>2003</option>
<option>2002</option>
<option>2001</option>
<option>2000</option>
<option>1999</option>
<option>1998</option>
<option>1997</option>
<option>1996</option>
<option>1995</option>
<option>1994</option>
<option>1993</option>
<option>1992</option>
<option>1991</option>
<option>1990</option>
<option>1989</option>
<option>1988</option>
<option>1987</option>
<option>1986</option>
<option>1985</option>
   </select>
</td>
</tr>

<tr>
<td>Colour: </td>
<td>
   <select name= "colour" />
<option><? echo $colour ?></option>
<option></option>
<option value= "Bay">Bay</option>
<option value= "Bay Roan">Bay Roan</option>
<option value= "Blood Bay">Blood Bay</option>
<option value= "Blood Bay Roan">Blood Bay Roan</option>
<option value= "Dark Bay">Dark Bay</option>
<option value= "Dark Bay Roan">Dark Bay Roan</option>
<option value= "Black">Black</option>
<option value= "Black Roan">Black Roan</option>
<option value= "Brown">Brown</option>
<option value= "Brown Dun">Brown Dun</option>
<option value= "Brown Roan">Brown Roan</option>
<option value= "Buckskin">Buckskin</option>
<option value= "Buckskin Roan">Buckskin Roan</option>
<option value= "Amber Champagne">Amber 

Champagne</option>
<option value= "Classic Champagne">Classic 

Champagne</option>
<option value= "Gold Champagne">Gold 

Champagne</option>
<option value= "Sable Champagne">Sable 

Champagne</option>
<option value= "Chestnut">Chestnut</option>
<option value= "Chestnut Roan">Chestnut Roan</option>
<option value= "Flaxen Chestnut">Flaxen Chestnut</option>
<option value= "Flaxen Chestnut Roan">Flaxen Chestnut 

Roan</option>
<option value= "Liver Chestnut">Liver Chestnut</option>
<option value= "Liver Chestnut Roan">Liver Chestnut 

Roan</option>
<option value= "Cremello">Cremello</option>
<option value= "Dun">Dun</option>
<option value= "Dun Roan">Dun Roan</option>
<option value= "Grey">Grey</option>
<option value= "Grey Dun">Grey Dun</option>
<option value= "Grulla">Grulla</option>
<option value= "Grulla Roan">Grulla Roan</option>
<option value= "Palomino">Palomino</option>
<option value= "Palomino Roan">Palomino Roan</option>
<option value= "Perlino">Perlino</option>
<option value= "Red Dun">Red Dun</option>
<option value= "Red Dun Roan">Red Dun Roan</option>
<option value= "Silver Bay">Silver Bay</option>
<option value= "Silver Black">Silver Black</option>
<option value= "Silver Buckskin">Silver Buckskin</option>
<option value= "Silver Grulla">Silver Grulla</option>
<option value= "Smoky Black">Smoky Black</option>
<option value= "Smoky Black Roan">Smoky Black 

Roan</option>
<option value= "Smoky Cream">Smoky Cream</option>
<option value= "White">White</option>
   </select>   
</td>
</tr>

<tr>
<td>Pattern: </td>
<td>
   <select name= "pattern" />
<option><? echo $pattern ?></option>
<option></option>
<option value= "">None</option>
<option value= "Overo">Overo</option>
<option value= "Rabicano">Rabicano</option>
<option value= "Sabino">Sabino</option>
<option value= "Tobiano">Tobiano</option>
<option value= "Tovero">Tovero</option>
<option value= "Spotted Blanket">Spotted Blanket</option>
<option value= "Frosted Blanket">Frosted Blanket</option>
<option value= "Leopard">Leopard</option>
<option value="Near Leopard">Near Leopard</option>
<option value= "Snowflake">Snowflake</option>
<option value= "Snowcap">Snowcap</option>
<option value= "Few Spot">Few Spot</option>
<option value= "Varnish Roan">Varnish Roan</option>
   </select>
</td>
</tr>

<tr>
<td>Breed: </td>
<td>
   <select name= "breed" />
<option><? echo $breed ?></option>
<option value= "">Select A Breed</option>
<option value= "Arabian Cross">Crossbred - 

Arabian (please specify in notes)</option>
<option value= "Draft Cross">Crossbred - Draft 

(please specify in notes)</option>
<option value= "Stock Horse Cross">Crossbred - 

Stock Horse (please specify in notes)</option>
<option value= "Thoroughbred Cross">Crossbred - 

Thoroughbred (please specify in notes)</option>
<option value= "Pony Cross">Crossbred - Pony 

(please specify in notes)</option>
<option value= "Warmblood Cross">Crossbred - 

Warmblood (please specify in notes)</option>
<option>Akhal Teke</option>
<option>American Cream Draft</option>
<option>American Creme And White</option>
<option>American Walking Pony</option>
<option>American Warmblood</option>
<option>Andalusian</option>
<option>Anglo-Arab</option>
<option>Appaloosa</option>
<option>Appendix Quarter Horse</option>
<option>Araappaloosa</option>
<option>Arabian</option>
<option>Ardennes</option>
<option>Argentine Criollo</option>
<option>Australian Brumby</option>
<option>Australian Stock Horse</option>
<option>Azteca</option>
<option>Barb</option>
<option>Bashkir</option>
<option>Bashkir Curly</option>
<option>Belgian Draft</option>
<option>Belgian Warmblood</option>
<option>Brandenberger</option>
<option>Breton</option>
<option>Budyonny</option>
<option>Camargue</option>
<option>Canadian Horse</option>
<option>Canadian Sport Horse</option>
<option>Canadian Warmblood</option>
<option>Caspian</option>
<option>Czech Warmblood</option>
<option>Chincoteague Pony</option>
<option>Cleveland Bay</option>
<option>Clydesdale</option>
<option>Colorado Ranger Horse</option>
<option>Connemara</option>
<option>Dales Pony</option>
<option>Danish Warmblood</option>
<option>Dartmoor Pony</option>
<option>Donkey</option>
             <option>Dole Horse</a>
<option>Drum Horse</option>
<option>Dutch Draft</option>
<option>Dutch Harness</option>
<option>Dutch Warmblood</option>
             <option>Egyptian Arabian</option>
<option>Exmoor Pony</option>
<option>Falabella</option>
<option>Fell Pony</option>
<option>Fjord</option>
<option>Florida Cracker</option>
<option>Fredericksborg</option>
<option>French Trotter</option>
<option>Friesian</option>
<option>Gelderlander</option>
<option>German Riding Pony</option>
<option>German Warmblood</option>
<option>Gotland</option>
<option>Groningen</option>
<option>Gypsy Cob</option>
<option>Gypsy Vanner</option>
<option>Hackney</option>
<option>Haflinger</option>
<option>Hanoverian</option>
<option>Highland Pony</option>
<option>Holsteiner</option>
<option>Hungarian Warmblood</option>
<option>Iberian Warmblood</option>
<option>Icelandic</option>
<option>Irish Cob</option>
<option>Irish Draught</option>
<option>Irish Sport Horse</option>
<option>Irish Warmblood</option>
<option>Jutland</option>
<option>Kentucky Mountain Saddle 

Horse</option>
<option>Kiger Mustang</option>
<option>Kladruby</option>
<option>Knabstrupper</option>
<option>Latvian Warmblood</option>
<option>Lippizzaner</option>
<option>Lusitano</option>
<option>Marwari</option>
<option>Miniature Horse</option>
<option>Missouri Fox Trotting Horse</option>
<option>Mongolian</option>
<option>Morab</option>
<option>Morgan</option>
<option>Mule</option>
<option>Mustang</option>
<option>National Show Horse</option>
<option>New Forest Pony</option>
<option>Newfoundland Pony</option>
<option>Nokota</option>
<option>Oldenburg</option>
<option>Orlov Trotter</option>
<option>Other (please specify in notes)</option>
<option>Paint</option>
<option>Paso Fino</option>
<option>Percheron</option>
<option>Peruvian Paso</option>
<option>Pintabian</option>
<option>Pony Of The Americas</option>
             <option>Polish Arabian</option>
<option>Quarab</option>
<option>Quarter Horse</option>
<option>Quarter Pony</option>
<option>Racking Horse</option>
<option>Rheinland Pfalz Saar</option>
<option>Rocky Mountain Horse</option>
             <option>Russian Arabian</option>
<option>Russian Don</option>
<option>Russian Trotter</option>
<option>Russian Warmblood</option>
<option>Saddlebred</option>
<option>Selle Francais</option>
<option>Shagya</option>
<option>Shetland Pony</option>
<option>Shire</option>
<option>Sorraia</option>
<option>Spanish Mustang</option>
<option>Spanish Barb</option>
<option>Spanish Norman</option>
<option>Standardbred</option>
<option>Suffolk Punch</option>
<option>Swedish Warmblood</option>
<option>Tennessee Walker</option>
<option>Thoroughbred</option>
<option>Trakehner</option>
<option>Walkaloosa</option>
<option>Welara</option>
<option>Welsh Mountain Pony (Section 

A)</option>
<option>Welsh Riding Pony (Section B)</option>
<option>Welsh Pony of Cob Type (Section 

C)</option>
<option>Welsh Cob (Section D)</option>
<option>Westfalen</option>
<option>Wielkopolski</option>
<option>Zangersheide</option>
   </select>
</td>
</tr>

<tr>
<td>Gender: </td>
<td>
   <select name= "gender" />
<option><? echo $gender ?></option>
<option></option>
<option value= "Stallion">Stallion</option>
<option value= "Mare">Mare</option>
<option value= "Gelding">Gelding</option>
   </select>
</td>
</tr>

<tr>
<td>Height: </td>
<td>
   <select name= "height" />
<option><? echo $height ?></option>
<option></option>
<option>6.0</option>
<option>6.1</option>
<option>6.2</option>
<option>6.3</option>
<option>7.0</option>
<option>7.1</option>
<option>7.2</option>
<option>7.3</option>
<option>8.0</option>
<option>8.1</option>
<option>8.2</option>
<option>8.3</option>
<option>9.0</option>
<option>9.1</option>
<option>9.2</option>
<option>9.3</option>
<option>10.0</option>
<option>10.1</option>
<option>10.2</option>
<option>10.3</option>
<option>11.0</option>
<option>11.1</option>
<option>11.2</option>
<option>11.3</option>
<option>12.0</option>
<option>12.1</option>
<option>12.2</option>
<option>12.3</option>
<option>13.0</option>
<option>13.1</option>
<option>13.2</option>
<option>13.3</option>
<option>14.0</option>
<option>14.1</option>
<option>14.2</option>
<option>14.3</option>
<option>15.0</option>
<option>15.1</option>
<option>15.2</option>
<option>15.3</option>
<option>16.0</option>
<option>16.1</option>
<option>16.2</option>
<option>16.3</option>
<option>17.0</option>
<option>17.1</option>
<option>17.2</option>
<option>17.3</option>
<option>18.0</option>
<option>18.1</option>
<option>18.2</option>
<option>18.3</option>
<option>19.0</option>
<option>19.1</option>
<option>19.2</option>
<option>19.3</option>
<option>20.0</option>
   </select> HH
</td>
</tr>

<tr>
<td>First Discipline: </td>
<td>
<select name="disciplines1" />
<option>All Around</option>
<option>Broodmare</option>
<option>Combined Driving</option>
<option>Cutting</option>
<option>Draft</option>
<option>Dressage</option>
<option>Driving</option>
<option>Endurance</option>
<option>Equitation</option>
<option>Eventing</option>
<option>Flat Racing</option>
<option>Gaming</option>
<option>Halter</option>
<option>Harness Racing</option>
<option>Hunter</option>
<option>Hunter In Hand</option>
<option>Hunter Under Saddle</option>
<option>Lunge Line</option>
<option>Obstacle Driving</option>
<option>Pleasure Driving</option>
<option>Polo</option>
<option>Ranch Horse</option>
<option>Reining</option>
<option>Roping</option>
<option>Saddleseat</option>
<option>Show Jumping</option>
<option>Showmanship</option>
<option>Steeplechasing</option>
<option>Stud</option>
<option>Working Cow Horse</option>
<option>Western Horsemanship</option>
<option>Western Pleasure</option>
<option>Western Riding</option>
<option>Western Trail</option>
<option>Other (Please specify)</option>
   </select> 
</td>
</tr>

<tr>
<td>Second Discipline: </td>
<td>
<select name="disciplines2" />
<option value= ""></option>
<option value= ", Broodmare">Broodmare</option>
<option value= ", Combined Driving">Combined 

Driving</option>
<option value= ", Cutting">Cutting</option>
<option value= ", Draft">Draft</option>
<option value= ", Dressage">Dressage</option>
<option value= ", Driving">Driving</option>
<option value= ", Endurance">Endurance</option>
<option value= ", Equitation">Equitation</option>
<option value= ", Eventing">Eventing</option>
<option value= ", Flat Racing">Flat Racing</option>
<option value= ", Gaming">Gaming</option>
<option value= ", Halter">Halter</option>
<option value= ", Harness Racing">Harness Racing</option>
<option value= ", Hunter">Hunter</option>
<option value= ", Hunter In Hand">Hunter In Hand</option>
<option value= ", Hunter Under Saddle">Hunter Under 

Saddle</option>
<option value= ", Lunge Line">Lunge Line</option>
<option value= ", Obstacle Driving">Obstacle 

Driving</option>
<option value= ", Pleasure Driving">Pleasure 

Driving</option>
<option value= ", Polo">Polo</option>
<option value= ", Ranch Horse">Ranch Horse</option>
<option value= ", Reining">Reining</option>
<option value= ", Roping">Roping</option>
<option value= ", Saddleseat">Saddleseat</option>
<option value= ", Showjumping">Show Jumping</option>
<option value= ", Showmanship">Showmanship</option>
<option value= ", Steeplechasing">Steeplechasing</option>
<option value= ", Stud">Stud</option>
<option value= ", Working Cow Horse">Working Cow 

Horse</option>
<option value= ", Western Horsemanship">Western 

Horsemanship</option>
<option value= ", Western Pleasure">Western 

Pleasure</option>
<option value= ", Western Riding">Western Riding</option>
<option value= ", Western Trail">Western Trail</option>
<option value= ", Other">Other (Please specify)</option>
   </select> 
</td>
</tr>

<tr>
<td>Third Discipline: </td>
<td>
<select name="disciplines3" />
<option value= ""></option>
<option value= ", Broodmare">Broodmare</option>
<option value= ", Combined Driving">Combined 

Driving</option>
<option value= ", Cutting">Cutting</option>
<option value= ", Draft">Draft</option>
<option value= ", Dressage">Dressage</option>
<option value= ", Driving">Driving</option>
<option value= ", Endurance">Endurance</option>
<option value= ", Equitation">Equitation</option>
<option value= ", Eventing">Eventing</option>
<option value= ", Flat Racing">Flat Racing</option>
<option value= ", Gaming">Gaming</option>
<option value= ", Halter">Halter</option>
<option value= ", Harness Racing">Harness Racing</option>
<option value= ", Hunter">Hunter</option>
<option value= ", Hunter In Hand">Hunter In Hand</option>
<option value= ", Hunter Under Saddle">Hunter Under 

Saddle</option>
<option value= ", Lunge Line">Lunge Line</option>
<option value= ", Obstacle Driving">Obstacle 

Driving</option>
<option value= ", Pleasure Driving">Pleasure 

Driving</option>
<option value= ", Polo">Polo</option>
<option value= ", Ranch Horse">Ranch Horse</option>
<option value= ", Reining">Reining</option>
<option value= ", Roping">Roping</option>
<option value= ", Saddleseat">Saddleseat</option>
<option value= ", Showjumping">Show Jumping</option>
<option value= ", Showmanship">Showmanship</option>
<option value= ", Steeplechasing">Steeplechasing</option>
<option value= ", Stud">Stud</option>
<option value= ", Working Cow Horse">Working Cow 

Horse</option>
<option value= ", Western Horsemanship">Western 

Horsemanship</option>
<option value= ", Western Pleasure">Western 

Pleasure</option>
<option value= ", Western Riding">Western Riding</option>
<option value= ", Western Trail">Western Trail</option>
<option value= ", Other">Other (Please specify)</option>

   </select> 
</td>
</tr>

<tr>
<td></td>
</tr>

<tr>
<td>Owner: </td>
<td>
<Select name="newowner">
<option><? echo $ownername ?></option>
<option></option>
<?
$query = "SELECT * FROM user ORDER BY username";
$result = mysql_query($query) or die(mysql_error());
while($row = mysql_fetch_array($result)){

echo "<option>";
echo $row['username'];
echo "</option>";
}
?>
</select>
</td>
</tr>

<tr>
<td>Status:</td>
<td><input type="text" name="status" value="0"></td>
</tr>
</table>

<br> <input type="submit" value="Update Horse" /> 
</form>


<? } ?>

<a href="adminhorse.php">[Go Back]</a>

<?
include('../includes/footer.php');
?>

 

 

And then, on the edithorseproc.php page:

<?
session_name('usersession');
session_start();

$title = "My Account";
$home = "not";
$guests = "not";
$forum = "not";
$est = "not";
$res = "not";
$my = "my";
$contact = "not";

include('../includes/database.php');
include('../includes/header.php');

if(!isset($peacock))
{
include ('../includes/loginform.php');
include('../includes/footer.php');
exit();
}

?>


<?
if (isset($_POST['id'])) {
   $id= $_POST['id'];
   $horsename= $_POST['horsename'];

   $sql = "UPDATE mhr SET 
       horsename='$horsename',

       WHERE id = '$id'"; 
       
   if (mysql_query($sql)) { 
     echo '<p>Your updates have been successful!.</p>'; 
  }

     echo '<p>[<a href= "adminhorse.php">Go Back To Admin: Horse</a>]</p>';
   }
   
    else { 
     echo '<p>Error: ' . 
         mysql_error() . '</p>'; 
   } 

include('../includes/footer.php');
?>

 

Right now, I'm trying to just get one field to update. However, I'll eventually want it to where they can edit the fields that need to be edited and then update. These are admin functions, so the admin == 1 needs to be set. Can anyone help?

[DaiLaughing]

You have not said what the problem is.  Doesn't it work?  If so have you tried echoing the variables to check they are what you expect?  What does happen?

 

Just glancing through it you seem to have all the basics (but no protection against SQL injection which you will need to add later of course).

[AnAmericanGunner]

Sorry;

It doesn't update. It'll show me the link to go back.

[DaiLaughing]

Put an "or die" in your processing page like you have in the first one.  Also echo the variables as I mentioned to make sure the values are being stored.  The technique is to narrow down what is going on until you are left with only one possible cause.