Help with simple if / else statement

[Mr.Canuck]

Hey everyone. I am a PHP novice and I was wondering if anyone can assist me with this if else statement. I don't have something right, because it doesn't work. So, if conditions are true, it won't display the <div> code and if the conditions are false, then it will display the <img> instead. Thanks.

 

<?php	
$cpage = $_GET['cpage']; 
?>

	<?php
if ($cpage != 'intro' && $cpage !='directions' && $cpage !='hours' && $cpage !='jam' && $cpage !='pointe'  && $cpage !='about'  && $cpage !='tc' && $cpage !='privacy' && $xlspg !='contact_us')  { 
?>
	  <div id="contain2"><?php $this->crumbTrail->Render(); ?></div>
            
      <?php else {
	  
<img class="img1" src="css/images/bcreplace.jpg" width="695" height="29" alt="bcreplace" />   
}
?>

[coupe-r]

You didn't close the bracket before the else clause.  You have 1 open { at the end of your condition but didn't close it.

[coupe-r]

Try this:

 

	

<?php
if ($cpage != 'intro' && $cpage !='directions' && $cpage !='hours' && $cpage !='jam' && $cpage !='pointe'  && $cpage !='about'  && $cpage !='tc' && $cpage !='privacy' && $xlspg !='contact_us')  { 
?>

  <div id="contain2"><?php $this->crumbTrail->Render(); ?></div>
            
      <?php }else {

<img class="img1" src="css/images/bcreplace.jpg" width="695" height="29" alt="bcreplace" />   
}
?>

[Psycho]

You have no closing braket on the IF condition. But, I would clean that code up by doing this:

 

<?php

$cpage = $_GET['cpage'];
$cpage_list = ('intro', 'directions', 'hours', 'jam', 'pointe', 'about', 'tc', 'privacy');

if (!in_array($cpage, $cpage_list) && $xlspg !='contact_us')
{
    echo "<div id=\"contain2\">" . $this->crumbTrail->Render() . "</div>";
}
else
{
    echo "<img class=\"img1\" src=\"css/images/bcreplace.jpg\" width=\"695\" height=\"29\" alt=\"bcreplace\" />";
}

?>

[Mr.Canuck]

Thanks for the replies guys. However, it does not seem to be working. If I run this code (without the "else") the page loads and it does what it is supposed to do for the "if". When I use the code above with the "else", the page does not load:

  <?php	
$cpage = $_GET['cpage']; 
?>

<?php

if ($cpage != 'intro' && $cpage !='directions' && $cpage !='hours' && $cpage !='jam' && $cpage !='pointe'  && $cpage !='about'  && $cpage !='tc' && $cpage !='privacy' && $xlspg !='contact_us')  { 
?>

<?php

}
?> 

[cweathers]

http://www.phpbuilder.com/manual/en/migration.if-endif.php

[seventheyejosh]

http://www.phpbuilder.com/manual/en/migration.if-endif.php

 

A different coding style isn't going to magically fix the fact that he has a missing bracket, it is just a different way.

 

OP: Try using a syntax highlighting editor, to find your errors.

[seventheyejosh]

You have no closing braket on the IF condition. But, I would clean that code up by doing this:

 

<?php

$cpage = $_GET['cpage'];
$cpage_list = ('intro', 'directions', 'hours', 'jam', 'pointe', 'about', 'tc', 'privacy');

if (!in_array($cpage, $cpage_list) && $xlspg !='contact_us')
{
    echo "<div id=\"contain2\">" . $this->crumbTrail->Render() . "</div>";
}
else
{
    echo "<img class=\"img1\" src=\"css/images/bcreplace.jpg\" width=\"695\" height=\"29\" alt=\"bcreplace\" />";
}

?>

 

I think you used ( ) instead of " " on your string declaration:

 

EDIT: I see it is an array.. just missed the "array"

<?php

$cpage = $_GET['cpage'];
//$cpage_list = ('intro', 'directions', 'hours', 'jam', 'pointe', 'about', 'tc', 'privacy'); // unexpected ',' ....
//$cpage_list = "'intro', 'directions', 'hours', 'jam', 'pointe', 'about', 'tc', 'privacy'"; // not supposed to be a string...

$cpage_list = array('intro', 'directions', 'hours', 'jam', 'pointe', 'about', 'tc', 'privacy'); // much better

if (!in_array($cpage, $cpage_list) && $xlspg !='contact_us')
{
    echo "<div id=\"contain2\">" . $this->crumbTrail->Render() . "</div>";
}
else
{
    echo "<img class=\"img1\" src=\"css/images/bcreplace.jpg\" width=\"695\" height=\"29\" alt=\"bcreplace\" />";
}

?>

[Mr.Canuck]

Thanks guys!! Seventheyejosh, you got it buddy! It works! Thanks Everyone!

[seventheyejosh]

No problem. Like I said, syntax highlighting is amazing. I use Komodo Edit, but Notepad++, Eclipse, Coda, etc all do it. There is a thread in the MISC section I believe devoted solely to editors. I'd check it out

[Mr.Canuck]

I'll do that. Thanks again