URL adds a ' making it invalid

[Jennmc75]

I've been working on adding a direct link in an automated email.  For some reason the url link adds a ' and makes the link invalid.  I can't figure out why the ' is added.

 

The link comes back like http://www.twcslibrary.com/user.php?action=revres&reviewid='revid

when I want it to be http://www.twcslibrary.com/user.php?action=revres&reviewid=revid

$mailquery= dbquery("SELECT ap.newreviews,"._EMAILFIELD." as email, "._PENNAMEFIELD." as penname FROM "._AUTHORTABLE." LEFT JOIN ".TABLEPREFIX."fanfiction_authorprefs as ap ON ap.uid = "._UIDFIELD." WHERE "._UIDFIELD." = '$author' ".(!empty($coauthors) ? " OR ".findclause(_UIDFIELD, $coauthors) : ""));
			while($mail = dbassoc($mailquery)) {
				if($mail['newreviews']) {
					include_once("includes/emailer.php");
					$subject = _REVEMAIL1.$title;
					 $mailtext = sprintf(_REVEMAIL2, "type=$type&item=$item", $review);
					//$mail['email'] = '[email protected]';
					$gname = $_SESSION[usrname];
					//echo $mailtext."mail text is there";
					//echo $substitute= substr($mailtext,50);
					//echo "select reviewid from " .TABLEPREFIX."fanfiction_reviews where review ='$review' && reviewer = '$gname' order by reviewid DESC"; 
					 $qry= dbquery("select reviewid from " .TABLEPREFIX."fanfiction_reviews where review ='$review' && reviewer = '$gname' order by reviewid DESC");
					$qry1 = dbrow($qry);
					 $revid = $qry1['reviewid'];
					$str = "<b>A review from"." ".$_SESSION[usrname]."</b><br>";
					 $mailtext= $str.$mailtext;
					 $revreply = "<br><br> Review can be responded <a href=http://www.twcslibrary.com/user.php?action=revres&reviewid='$revid'>by clicking here</a>";
					  $mailtext = $mailtext.$revreply;
					 $result = sendemail($mail['penname'], $mail['email'], $sitename, $siteemail, $subject, $mailtext, "html");

[.Stealth]

Try that.

 

$mailquery= dbquery("SELECT ap.newreviews,"._EMAILFIELD." as email, "._PENNAMEFIELD." as penname FROM "._AUTHORTABLE." LEFT JOIN ".TABLEPREFIX."fanfiction_authorprefs as ap ON ap.uid = "._UIDFIELD." WHERE "._UIDFIELD." = '$author' ".(!empty($coauthors) ? " OR ".findclause(_UIDFIELD, $coauthors) : ""));









while($mail = dbassoc($mailquery)) {











if($mail['newreviews']) {













include_once("includes/emailer.php");













$subject = _REVEMAIL1.$title;













$mailtext = sprintf(_REVEMAIL2, "type=$type&item=$item", $review);













//$mail['email'] = '[email protected]';













$gname = $_SESSION[usrname];













//echo $mailtext."mail text is there";













//echo $substitute= substr($mailtext,50);













//echo "select reviewid from " .TABLEPREFIX."fanfiction_reviews where review ='$review' && reviewer = '$gname' order by reviewid DESC"; 













$qry= dbquery("select reviewid from " .TABLEPREFIX."fanfiction_reviews where review ='$review' && reviewer = '$gname' order by reviewid DESC");













$qry1 = dbrow($qry);













$revid = $qry1['reviewid'];













$str = "<b>A review from"." ".$_SESSION[usrname]."</b><br>";













$mailtext= $str.$mailtext;













$revreply = "<br><br> Review can be responded <a href=http://www.twcslibrary.com/user.php?action=revres&reviewid=" . $revid . " '>by clicking here</a>";













  $mailtext = $mailtext.$revreply;













$result = sendemail($mail['penname'], $mail['email'], $sitename, $siteemail, $subject, $mailtext, "html");

[-Karl-]

   $mailquery= dbquery("SELECT ap.newreviews,"._EMAILFIELD." as email, "._PENNAMEFIELD." as penname FROM "._AUTHORTABLE." LEFT JOIN ".TABLEPREFIX."fanfiction_authorprefs as ap ON ap.uid = "._UIDFIELD." WHERE "._UIDFIELD." = '$author' ".(!empty($coauthors) ? " OR ".findclause(_UIDFIELD, $coauthors) : ""));
                while($mail = dbassoc($mailquery)) {
                    if($mail['newreviews']) {
                        include_once("includes/emailer.php");
                        $subject = _REVEMAIL1.$title;
                         $mailtext = sprintf(_REVEMAIL2, "type=$type&item=$item", $review);
                        //$mail['email'] = '[email protected]';
                        $gname = $_SESSION[usrname];
                        //echo $mailtext."mail text is there";
                        //echo $substitute= substr($mailtext,50);
                        //echo "select reviewid from " .TABLEPREFIX."fanfiction_reviews where review ='$review' && reviewer = '$gname' order by reviewid DESC"; 
                         $qry= dbquery("select reviewid from " .TABLEPREFIX."fanfiction_reviews where review ='$review' && reviewer = '$gname' order by reviewid DESC");
                        $qry1 = dbrow($qry);
                         $revid = $qry1['reviewid'];
                        $str = "<b>A review from"." ".$_SESSION[usrname]."</b><br>";
                         $mailtext= $str.$mailtext;
                         $revreply = "<br><br> Review can be responded <a href='http://www.twcslibrary.com/user.php?action=revres&reviewid=".$revid."'>by clicking here</a>";
                          $mailtext = $mailtext.$revreply;
                         $result = sendemail($mail['penname'], $mail['email'], $sitename, $siteemail, $subject, $mailtext, "html");

[.Stealth]

The hell happened to mine 

[Jennmc75]

Thanks for your suggestion but it didn't work either.  I'm really starting to wonder if I'm not going to be able to have that link work.

[jdavidbakr]

It's not in the table with the quote, is it?

[Jennmc75]

I just checked and the field in the table is an auto-increment.  No special characters.

[jdavidbakr]

Just looked more closely at your code - you're opening the $revreply assignment with a double-quote, and then putting single-quotes around the variable.  The double-quote aren't terminated by the single quotes.  Try this:

 

$revreply = "<br><br> Review can be responded <a href='http://www.twcslibrary.com/user.php?action=revres&reviewid=$revid'>by clicking here</a>";

[Jennmc75]

That worked!  Thank you so much!