if() with two conditions OR nested if() what is best

[anatak]

What do you think is the best way ?

 

I am testing two arrays to see if the corresponding values are empty or not

 

for($t=0;$t<count($array1);$T++){
if(empty($array1[$t]) AND empty($array2[$t])){}
if(empty($array1[$t]) AND !empty($array2[$t])){}
if(!empty($array1[$t]) AND empty($array2[$t])){}
if(!empty($array1[$t]) AND !empty($array2[$t])){}
}

 

OR

for($t=0;$t<count($array1);$T++){
  if(empty($array1[$t]){
    if(empty($array2[$t]){
    //empty($array1[$t]) AND empty($array2[$t]
    }else{
    //empty($array1[$t]) AND !empty($array2[$t]
    }
  }else{
  if(!empty($array2[$t])){
    //!empty($array1[$t]) AND !empty($array2[$t]
    }
  }

 

what would be the fastest code ?

the first one is a lot more readable I think than the second one but I would guess that the second one would be more faster.

could you also explain why you think which code would be better ?

 

 

thank you

anatak

[sspoke]

neither best is using if statements properly!

 

for($t=0;$t<count($array1);$T++){
  if(empty($array1[$t]) AND empty($array2[$t])){
  } elseif(empty($array1[$t]) AND !empty($array2[$t])){
  } elseif(!empty($array1[$t]) AND empty($array2[$t])){
  } elseif(!empty($array1[$t]) AND !empty($array2[$t])){
  }
}

 

^ thats the fastest because it may only check the first if then exit.. to next loop

or it may check 2 if's and exit..

but if you add a bunch of if's it will check them all!

 

Unless you want them to all be checked?

[GoneNowBye]

doesn't matter the difference will be neglidgable anyway, only prominant if you have 10's of millions of if's i should think.

[anatak]

neither best is using if statements properly!

 

for($t=0;$t<count($array1);$T++){
  if(empty($array1[$t]) AND empty($array2[$t])){
  } elseif(empty($array1[$t]) AND !empty($array2[$t])){
  } elseif(!empty($array1[$t]) AND empty($array2[$t])){
  } elseif(!empty($array1[$t]) AND !empty($array2[$t])){
  }
}

 

^ thats the fastest because it may only check the first if then exit.. to next loop

or it may check 2 if's and exit..

but if you add a bunch of if's it will check them all!

 

Unless you want them to all be checked?

 

 

I am such an idiot

why didn't I think about elseif()

thanks

I also thinks this is the most readable solution