Jump to content

SELECT Statement Help


jmfillman

Recommended Posts

The function below always returns true, no matter what I pass for $eMail and $Password and I can't figure out why!! Please help!

 

 

  public function validateUser($eMail, $Password) {

$email = $eMail;

$pass = $Password;

$query = "SELECT * FROM regUsers WHERE eMail='$email' AND Password='$pass'";

$validResult = mysql_query($query);

if(!$validResult) {

    $msg=$this->err_prefix."Your e-mail and/or Password do not match. ".$this->mysql->error;

throw new Exception($msg);

}

else {

return true;

}

  }

Link to comment
Share on other sites

You are not checking the "results" of the query. You are merely checking to see if the query ran successfully, i.e. without errors:

 

public function validateUser($eMail, $Password)
{
   $query = "SELECT * FROM regUsers WHERE eMail='$eMail' AND Password='$Password'";
   $result = mysql_query($query);
   if(!$validResult)
   {
       //Query did not run
       $msg = $this->err_prefix."There was an error running the query. ".$this->mysql->error;
       throw new Exception($msg);
       return false;
   }
   else if (mysql_num_rows($result)!=1)
   {
       //Query ran, but there were no results
       $msg = $this->err_prefix."Your e-mail and/or Password do not match.";
       throw new Exception($msg);
       return false;
   }
   return true;
}

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.