runeveryday Posted August 14, 2010 Share Posted August 14, 2010 class 1: class HelloWorld { public $world; function getHtml() { return "<html><body>". "Hello, ".$this->world."!". "</body></html>"; } } class2: class HelloWorld { public $world; function __construct($world) { $this->world = $world; } function getHtml() { return "<html><body>". "Hello ".$this->world."!". "</body></html>"; } } i don't know why in class 2 it uses a construct function. i feel it is unnecessary .any tips would be appreciated. Quote Link to comment Share on other sites More sharing options...
ignace Posted August 14, 2010 Share Posted August 14, 2010 The proper method would be: class SomeOddWorld { private $theOddWorldsName; public function __construct($nameIt) { $this->theOddWorldsName = $nameIt; } } Ditch the getHtml() method it's against proper design. Every model should be free of storing and presenting itself. Quote Link to comment Share on other sites More sharing options...
runeveryday Posted August 14, 2010 Author Share Posted August 14, 2010 The proper method would be: class SomeOddWorld { private $theOddWorldsName; public function __construct($nameIt) { $this->theOddWorldsName = $nameIt; } } Ditch the getHtml() method it's against proper design. Every model should be free of storing and presenting itself. i am still confused. Quote Link to comment Share on other sites More sharing options...
ignace Posted August 14, 2010 Share Posted August 14, 2010 i am still confused. OOP is about encapsulating your data, which means that the data is hidden from the client. If you declare your class variables public you are no longer encapsulating this data. It's best to always declare your class variables private NOT public and only in VERY rare cases should you use protected. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.