Uploading Images Help

andrew_biggart · October 28, 2010

Ok I have finally got rid of my syntax errors with this upload script. Now im getting the error uploading your image.

My folders are called project_files and project_thumbs.

This is my script

<?php
	$results = "";

	error_reporting(E_ALL);
    ini_set("display_errors", 1);

	//Auto Thumbnail Function
	function create_thumbnail($source,$destination, $thumb_width) {
	$size = getimagesize($source);
	$width = $size[0];
	$height = $size[1];
	$x = 0;
	$y = 0;
	if($width> $height) {
		$x = ceil(($width - $height) / 2 );
		$width = $height;
	} elseif($height> $width) {
		$y = ceil(($height - $width) / 2);
		$height = $width;
	}
	$new_image = imagecreatetruecolor($thumb_width,$thumb_width)
		or die('Cannot initialize new GD image stream');
	$extension = get_image_extension($source);
	if($extension=='jpg' || $extension=='jpeg')
		$image = imagecreatefromjpeg($source);
	if($extension=='gif')
		$image = imagecreatefromgif($source);
	if($extension=='png')
		$image = imagecreatefrompng($source);

	imagecopyresampled($new_image,$image,0,0,$x,$y,$thumb_width,							       
    $thumb_width,$width,$height);
	if($extension=='jpg' || $extension=='jpeg')
		imagejpeg($new_image,$destination);
	if($extension=='gif')
		imagegif($new_image,$destination);
	if($extension=='png')
		imagepng($new_image,$destination);

	}

	//Get Extension Function
	function get_image_extension($name) {
	$name = strtolower($name);
	$i = strrpos($name,".");
	if (!$i) { return ""; }
		$l = strlen($name) - $i;
	$extension = substr($name,$i+1,$l);
	return $extension; 
	}

	//Random Name Function
	function random_name($length) {
	$characters = "abcdefghijklmnopqrstuvwxyz01234567890";
	$name = "";

	for ($i = 0; $i < $length; $i++) {
		$name .= $characters[mt_rand(0, strlen($characters) - 1)];
	}
	return "image-".$name;
}



$images_location = "/project_files/";
$thumbs_location = "/project_thumbs/";
$thumb_width = "100";
$maximum_size = "5000000";			

//Check And Save Image			
if($_POST) {

if($_FILES['image']['name'] == ""){
	$results = "Please select the image you would like to upload by clicking browse";
}
else{
	$size=filesize($_FILES['image']['tmp_name']);
	$filename = stripslashes($_FILES['image']['name']);
	$extension = get_image_extension($filename);
	if($size > $maximum_size) {
		$results = "Your file size exceeds the maximum file size!";
	}
	else

	if (($extension != "jpg") &&
		($extension != "jpeg") &&
		($extension != "png") &&
		($extension != "gif")) {
		$results = "Only the following extensions are allowed. 'jpg', 'jpeg', 'png', 'gif'.";
	}
	else {
		$image_random_name=random_name(15).".".$extension;
		$copy = @copy($_FILES['image']['tmp_name'], $images_location.$image_random_name);
		if (!$copy) {
			$results = "Error while uploadin your image! Please try again!";
		}
		else{
		create_thumbnail($images_location.$image_random_name,$thumbs_location.$image_random_name, $thumb_width);
			$results = "Your image has been uploaded!";
		}
	}
}
}
?>

and the form

<html>
<head>
<title>test</title>
</head>
<body>
<?php echo $results; ?>
<form action="#" method="post" enctype="multipart/form-data">
<input type="hidden" name="MAX_FILE_SIZE" value="5000000" />
    <input type="file" name="image" />
    <input type="submit" value="Upload Image" />
</form>
</body>
</html>

PFMaBiSmAd · October 28, 2010

The @ on the copy() statement is hiding any php errors that would tell you why it is failing.

Code should never have @ in it to hide errors (there's no need anyway because you would have display_errors set the way you want to show or not show error messages to the client.)

andrew_biggart · October 28, 2010

Ok I have removed the @ but I am still getting the same thing, Error while uploadin your image! Please try again!

So the image is not saving but why?

andrew_biggart · October 28, 2010

I have also checked the file permissions of all the folders and they are all 777!!!

PFMaBiSmAd · October 28, 2010

Is the form on the same page as the php code so that any php errors would be seen?

Sign In

Uploading Images Help

Recommended Posts

andrew_biggart

Link to comment

Share on other sites

PFMaBiSmAd

Link to comment

Share on other sites

andrew_biggart

Link to comment

Share on other sites

andrew_biggart

Link to comment

Share on other sites

PFMaBiSmAd

Link to comment

Share on other sites

Join the conversation

Browse

Activity

Important Information