Anag Posted December 9, 2010 Share Posted December 9, 2010 Hello, I'm working on a script which should read lines from a file keyword.txt create a new file with that variable name, insert the content close and loop through all the lines in the keyword file. The loop itself works but now that i'm adding the fopen fwrite and fclose i'm running into trouble. I'm not that great a coder and have pieced this together so far. I'd appreciate any suggestions on how to fix the fopen and other file functions to create unique files using the keywords from the file Thanks in advance <?php $read_file = file('keywords.txt'); foreach($read_file as $var) { $file = fopen($var, "x"); $content = "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\"> <html xmlns=\"http://www.w3.org/1999/xhtml\"> <head> <meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\" /> <title>This is the title</title> </head> <body> <h2>The keyword is $var</h2> <p><p> </body> </html>"; fwrite($file, $content); fclose($file); } ?> Quote Link to comment https://forums.phpfreaks.com/topic/221099-variable-fopen-file-name-loop-to-make-multiple-files/ Share on other sites More sharing options...
OldWest Posted December 9, 2010 Share Posted December 9, 2010 what trouble are you running into? getting any specific errors? what happens when you run the script? Quote Link to comment https://forums.phpfreaks.com/topic/221099-variable-fopen-file-name-loop-to-make-multiple-files/#findComment-1144836 Share on other sites More sharing options...
Anag Posted December 9, 2010 Author Share Posted December 9, 2010 This is the warning i get it repeats for each entry in keywords.txt. New York is on the first line Warning: fopen(New York .txt) [function.fopen]: failed to open stream: Invalid argument in C:\script.php on line 5 Warning: fwrite() expects parameter 1 to be resource, boolean given in C:\script.php on line 17 Warning: fclose() expects parameter 1 to be resource, boolean given in C:\script.php on line 18 Quote Link to comment https://forums.phpfreaks.com/topic/221099-variable-fopen-file-name-loop-to-make-multiple-files/#findComment-1144848 Share on other sites More sharing options...
Buddski Posted December 9, 2010 Share Posted December 9, 2010 I have always found the file_put_contents() is alot easier to use http://au.php.net/manual/en/function.file-put-contents.php I am not 100% sure as to why you are getting the first error, i suspect the file exists and you are using mode x which will return false thus causing the second 2 errors Quote Link to comment https://forums.phpfreaks.com/topic/221099-variable-fopen-file-name-loop-to-make-multiple-files/#findComment-1144851 Share on other sites More sharing options...
Anag Posted December 9, 2010 Author Share Posted December 9, 2010 The files do not exist i am trying to create all new files using the content in this script Quote Link to comment https://forums.phpfreaks.com/topic/221099-variable-fopen-file-name-loop-to-make-multiple-files/#findComment-1144852 Share on other sites More sharing options...
Buddski Posted December 9, 2010 Share Posted December 9, 2010 Can you try wrapping the $var in a trim() $file = fopen(trim($var), "x"); Just a theory Quote Link to comment https://forums.phpfreaks.com/topic/221099-variable-fopen-file-name-loop-to-make-multiple-files/#findComment-1144853 Share on other sites More sharing options...
Anag Posted December 9, 2010 Author Share Posted December 9, 2010 That worked thank you so much Quote Link to comment https://forums.phpfreaks.com/topic/221099-variable-fopen-file-name-loop-to-make-multiple-files/#findComment-1144856 Share on other sites More sharing options...
Buddski Posted December 9, 2010 Share Posted December 9, 2010 No worries. Quote Link to comment https://forums.phpfreaks.com/topic/221099-variable-fopen-file-name-loop-to-make-multiple-files/#findComment-1144857 Share on other sites More sharing options...
OldWest Posted December 9, 2010 Share Posted December 9, 2010 And if you want to create .html files, just do this: $file = fopen(trim($line) . ".html", 'x'); Quote Link to comment https://forums.phpfreaks.com/topic/221099-variable-fopen-file-name-loop-to-make-multiple-files/#findComment-1144860 Share on other sites More sharing options...
OldWest Posted December 9, 2010 Share Posted December 9, 2010 Can you try wrapping the $var in a trim() $file = fopen(trim($var), "x"); Just a theory Not theory. Solid fact! Good idea! Quote Link to comment https://forums.phpfreaks.com/topic/221099-variable-fopen-file-name-loop-to-make-multiple-files/#findComment-1144861 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.