Image upload not working with some files?

[budimir]

Hey guys,

 

I have an image upload script and it's working fine. But for some files it will not work. It says it can't get the filesize and it can't copy that file. I have tried to change the file format of that file, but with no result. So it's not the file format. Is there anything else that could confuse getfilesize and copy commands in PHP? Can you please tell me what is wrong?

 

include ("include/session.php");

//Pohranjivanje podataka za 1. sliku

$naziv1 = mysql_real_escape_string($_POST["naziv1"],$veza);
$opis1 = mysql_real_escape_string($_POST["opis1"],$veza);
$album_id = mysql_real_escape_string($_POST["album_id"],$veza);
$datum1 = date("Y-m-d H:i:s");


//Upload slike i thumba
//define a maxim size for the uploaded images 
define ("MAX_SIZE","10000000000"); 

// define the width and height for the thumbnail 
// note that theese dimmensions are considered the maximum dimmension and are not fixed, 
// because we have to keep the image ratio intact or it will be deformed 
define ("WIDTH","200"); 
define ("HEIGHT","150");   

// this is the function that will create the thumbnail image from the uploaded image 
// the resize will be done considering the width and height defined, but without deforming the image 

function make_thumb($img_name,$filename,$new_w,$new_h) { 

//get image extension. 
$ext=getExtension($img_name); 
//creates the new image using the appropriate function from gd library 

if(!strcmp("jpg",$ext) || !strcmp("jpeg",$ext)) $src_img=imagecreatefromjpeg($img_name);   
if(!strcmp("png",$ext)) $src_img=imagecreatefrompng($img_name);  
if(!strcmp("gif",$ext)) $src_img=imagecreatefromgif($img_name);

//gets the dimmensions of the image 

$old_x=imageSX($src_img); $old_y=imageSY($src_img);   

// next we will calculate the new dimmensions for the thumbnail image 
// the next steps will be taken: 
// 1. calculate the ratio by dividing the old dimmensions with the new ones 
// 2. if the ratio for the width is higher, the width will remain the one define in WIDTH variable 
// and the height will be calculated so the image ratio will not change 
// 3. otherwise we will use the height ratio for the image 
// as a result, only one of the dimmensions will be from the fixed ones 

$ratio1=$old_x/$new_w; $ratio2=$old_y/$new_h;

if($ratio1>$ratio2) { $thumb_w=$new_w; $thumb_h=$old_y/$ratio1; } else { $thumb_h=$new_h; $thumb_w=$old_x/$ratio2; }   

// we create a new image with the new dimmensions 

$dst_img=ImageCreateTrueColor($thumb_w,$thumb_h);   

// resize the big image to the new created one 

imagecopyresampled($dst_img,$src_img,0,0,0,0,$thumb_w,$thumb_h,$old_x,$old_y);   

// output the created image to the file. Now we will have the thumbnail into the file named by $filename

if(!strcmp("png",$ext)) imagepng($dst_img,$filename); else imagejpeg($dst_img,$filename);   

//destroys source and destination images. 
imagedestroy($dst_img); imagedestroy($src_img); }   

// This function reads the extension of the file. 
// It is used to determine if the file is an image by checking the extension. 

function getExtension($str) { $i = strrpos($str,"."); if (!$i) { return ""; } $l = strlen($str) - $i; $ext = substr($str,$i+1,$l); return $ext; }   

// This variable is used as a flag. The value is initialized with 0 (meaning no error found) 
//and it will be changed to 1 if an errro occures. If the error occures the file will not be uploaded. 

$errors=0; 

// checks if the form has been submitted 

if(isset($_POST['spremi'])) { 

//reads the name of the file the user submitted for uploading 

$image=$_FILES['slika1']['name']; 

// if it is not empty 

if ($image) { 

// get the original name of the file from the clients machine 

$filename = stripslashes($_FILES['slika1']['name']); 

// get the extension of the file in a lower case format 

$extension = getExtension($filename); $extension = strtolower($extension); 


// if it is not a known extension, we will suppose it is an error, print an error message 
//and will not upload the file, otherwise we continue 

if (($extension != "jpg") && ($extension != "jpeg") && ($extension != "png") && ($extension != "gif")) { echo '<h1>Unknown extension!</h1>'; $errors=1; } else { 

// get the size of the image in bytes 
// $_FILES[\'image\'][\'tmp_name\'] is the temporary filename of the file in which the uploaded file was stored on the server 

$size=getimagesize($_FILES['slika1']['tmp_name']); 
$sizekb=filesize($_FILES['slika1']['tmp_name']);   


//compare the size with the maxim size we defined and print error if bigger 

if ($sizekb > MAX_SIZE*1024) { echo '<h1>You have exceeded the size limit!</h1>'; $errors=1; }   

//we will give an unique name, for example the time in unix time format 

$image_name1=mt_rand(0,9999999).'.'.$extension; 

//the new name will be containing the full path where will be stored (images folder) 

$newname="slike_natjecanja/".$image_name1; 
$copied = copy($_FILES['slika1']['tmp_name'], $newname); 

//we verify if the image has been uploaded, and print error instead 

if (!$copied) { echo '<h1>Copy unsuccessfull!</h1>'; $errors=1; } else { 

// the new thumbnail image will be placed in images/thumbs/ folder 

$thumb_name='slike_natjecanja/thumbs/thumb_'.$image_name1; 
$thumb_name1 = 'thumb_'.$image_name1;

// call the function that will create the thumbnail. The function will get as parameters 
//the image name, the thumbnail name and the width and height desired for the thumbnail 

$thumb=make_thumb($newname,$thumb_name,WIDTH,HEIGHT); }} }} 

//If no errors registred, print the success message and show the thumbnail image created 
if(isset($_POST['Submit']) && !$errors) { echo "<h1>Thumbnail created Successfully!</h1>"; echo '<img src="'.$thumb_name.'">'; }


if (empty($_FILES['slika1']['name'])) {
    
    echo "Prazno je!";
    die;
    
    } else {
             
    //Ubacivanje u bazu
    $upit = "INSERT INTO natjecanja_slike_sve (album_id, naziv_slike, opis_slike, datum_dodavanja_slike, slika_nat_mala, slika_nat_velika) VALUES ('$album_id', '$naziv1', '$opis1', '$datum1', '$thumb_name1', '$image_name1')";
    echo "$upit";
    die;
    $rezultat = mysql_query($upit) or die (mysql_error());
    
}

[PFMaBiSmAd]

Your code isn't checking if the upload worked, before accessing any of the uploaded file information. $_FILES['slika1']['error'] will be set and be a zero if the upload worked. If $_FILES['slika1']['error'] is a non-zero, the value would tell you why the upload failed. See this link for the ['error'] values - http://us.php.net/manual/en/features.file-upload.errors.php

[budimir]

@  PFMaBiSmAd:

You are the man!!! I would never come up with this... My image was bigger then allowed in php.ini!!!

 

You made my Year

 

Thank you so much!!!!

[budimir]

OK, I did make some error reporting to my script but still I have a problem. The script is not uploading some of the files. I have checked the file format and everything, and it's OK, but for some files it is not working.

 

When I'm uploading just one file it's OK, but if I'm trying to upload multiple files the script won't work. And I can't figure out why. It says no file uploaded.

 

I have attached my file, so if anyone can take a look, I would appreciate it!

 

[attachment deleted by admin]

[PFMaBiSmAd]

The total size of all the files is probably exceeding the post_max_size setting - http://us.php.net/manual/en/ini.core.php#ini.post-max-size

[budimir]

@ PFMaBiSmAd

 

Ok, that was the problem. But, I have a question regarding that. I have changed the values in php.ini for my local server. What will happen when I upload my web site to a hosting server? Can I somehow make some override for max file size on that server? Like with a php script?

[PFMaBiSmAd]

You should probably check with your web host if and how they permit you to change the upload_max_filesize and post_max_size settings on their server.

[budimir]

OK, thanks!

 

You helped me a lot!