Jump to content

Using proper doctype declaration breaks Javascript


Guest

Recommended Posts

Here's my function:

 

var cropPic = document.getElementById('cropPic');
var cropFrame = document.getElementById('cropFrame');

var cropPicWidth = cropPic.clientWidth;
var cropPicHeight = cropPic.clientHeight;
var cropFrameWidth = cropFrame.clientWidth;
var cropFrameHeight = cropFrame.clientHeight;
var maxX = cropPicWidth - cropFrameWidth;
var maxY = cropPicHeight - cropFrameHeight;

cropFrame.style.left = (cropPicWidth / 2) - (cropFrameWidth / 2);
cropFrame.style.top = (cropPicHeight / 2) - (cropPicHeight / 2);

 

Obviously, it cropFrame in the middle center of cropPic. Thing is, it totally doesn't work unless I delete the doctype declaration from the head of my HTML!

 

<!DOCTYPE html PUBLIC
"-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

 

Why on Earth would the doctype kill my function? Makes no sense at all to me...

Link to comment
Share on other sites

When you set the style you need to add "px" after the top or left.

e.g.

cropFrame.style.left = ((cropPicWidth / 2) - (cropFrameWidth / 2))+"px";
cropFrame.style.top = ((cropPicHeight / 2) - (cropPicHeight / 2))+"px";

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.