php/sql problem

[Imaulle]

Hello,

 

The following code does not return any errors, but nothing is ever inserted into the database. I'm sure it's something super simple :\

 

 

$result = mysql_query("SELECT filename FROM p_headerimages ORDER BY ordernum") or die(mysql_error());
$newcount = count($result) +1;
$query2 = "INSERT INTO `psitez_wrdp12`.`p_headerimages` (`filename`, `ordernum`) VALUES (\''$file_name'\', \''$newcount'\');";
$result2= mysql_query($query2);

 

 

 

Here is the database stuff

 

--
-- Table structure for table `p_headerimages`
--

CREATE TABLE IF NOT EXISTS `p_headerimages` (
  `filename` varchar(64) NOT NULL,
  `ordernum` tinyint(3) unsigned NOT NULL,
  PRIMARY KEY  (`ordernum`)
) ENGINE=MyISAM  DEFAULT CHARSET=latin1;

--
-- Dumping data for table `p_headerimages`
--

INSERT INTO `p_headerimages` (`filename`, `ordernum`) VALUES
('slideshow.jpg', 1),
('slideshow1.jpg', 2),
('slideshow2.jpg', 3),
('slideshow3.jpg', 4),
('slideshow4.jpg', 5),
('slideshow5.jpg', 6),
('slideshow6.jpg', 7);

 

 

 

 

any ideas?? Thank you for your help!

 

[fugix]

try this

$result = mysql_query("SELECT filename FROM p_headerimages ORDER BY ordernum") or die(mysql_error());
$newcount = count($result) +1;
$query2 = "INSERT INTO `psitez_wrdp12`.`p_headerimages` (`filename`, `ordernum`) VALUES ('$file_name', '$newcount')";
$result2= mysql_query($query2) or die(mysql_error());

[Imaulle]

nope :\

 

I'm thinking it's how I have the table rows set up... argh

[fugix]

you dont receive any errors though?

[Imaulle]

as far as I can tell no errors

[Imaulle]

this php file is getting ran by some javascript so if the 'or die' is killing the php script I won't see that output correct?

[fugix]

correct, but you would receive an error as well

[Imaulle]

When I set ordernum as 'auto-increment' and then do just

 

$query2 = "INSERT INTO p_headerimages (`filename`) VALUES ('$file_name')";

 

 

it works, but then the number that gets put into ordernum is not what I want it to be. Do I need to add another value like just id or something?

[Imaulle]

oh cool! I removed ordernum as the primary key and it's now getting put into the table!

 

except now '2' is getting put in as ordernum. How do I get count to count the number of entries and not rows?

[fugix]

show me what you have now please

[Imaulle]

$result = mysql_query("SELECT filename FROM p_headerimages ORDER BY ordernum") or die(mysql_error());
$newcount = mysql_num_rows($result)+1;
$query2 = "INSERT INTO p_headerimages (`filename`, `ordernum`) VALUES ('$file_name', '$newcount')";
$result2= mysql_query($query2) or die(mysql_error());

 

 

This is now working. Except the database does not seem to have a key or nothing is sorted. Do I need to worry about that?

[fugix]

its not a huge deal, however it is a good practice to get into to use an auto-incrementing primary key field...for neatness. I normally set a field called "id" as my primary key, and make it auto-incrementing as well

[fugix]

and honestly i would get rid of the ordernum field...i dont see the purpose for it

[Imaulle]

ok thank you very much!

[fugix]

ok thank you very much!

glad i could help...