Help with updating date in database

[sac0o01]

I am trying to update last logged in entry in the database upon succesful login. 

 

I may be way off in the logic here or I may be missing something simple.  I don't get any errors and it logs in fine.  Just does not update the lastvisit field in the database. 

 

 

//record date of most recent login
	$result = mysql_query("SELECT username FROM users WHERE user_id ='".$_SESSION['userId'] . "'"); 
	$dtCreated = date('Y-m-d');
	mysql_query("UPDATE users SET lastvisit=('$dtCreated') WHERE username = $result");

[Zurev]

mysql_query creates a resource. You're updating where username equals resource id whatever.

 

So:

//record date of most recent login
	$result = mysql_query("SELECT username FROM users WHERE user_id ='".$_SESSION['userId'] . "'"); 
                $theUsername = mysql_fetch_row($result);
                $theUsername = $theUsername[0];
	$dtCreated = date('Y-m-d');
	mysql_query("UPDATE users SET lastvisit=('$dtCreated') WHERE username = $theUsername");

 

Give that a try.

[harristweed]

why so much code?

why not:

mysql_query("update users set lastvisit = curdate() where user_id = '{$_SESSION['userId']}' ");

[sac0o01]

Thanks to both of you, I got it going.

 

Harristweed I thought the same thing as you and had tried that but could not get it to work.

In the end the problem was coming from the fact that when I created the column in the database I did not set it to "not null".  So it would not update the row.  I fixed the null problem and it works great now.

 

Thanks again