Query Function Help

[JaredRitchey]

I have a script that runs at the end of a batch process specifically built to clean out empty records.

 

How can I make it a function and then call the function.

 

Here is my query;

 

$sql="DELETE FROM ".$dbname." . property WHERE property . id=''";
mysql_query($sql) or die("<b>A fatal MySQL error occured</b>.\n<br />Query: " . $sql . "<br />\nError: (" . mysql_errno() . ") " . mysql_error());

$sql="DELETE FROM ".$dbname." . agents WHERE agents . ip_source=''";
mysql_query($sql) or die("<b>A fatal MySQL error occured</b>.\n<br />Query: " . $sql . "<br />\nError: (" . mysql_errno() . ") " . mysql_error());

$sql="DELETE FROM ".$dbname." . settings WHERE settings . prop_id=''";
mysql_query($sql) or die("<b>A fatal MySQL error occured</b>.\n<br />Query: " . $sql . "<br />\nError: (" . mysql_errno() . ") " . mysql_error());

 

I would like this to be in a function that i could specifically call the function. Why? Well because I have 5 different sets of queries like this set above and I'm going to build a conditional. So like if condition 1 then run use this function, condition 2, use function ??? etc and so on.

[wildteen88]

specifically built to clean out empty records.

If you're validating your data correctly before it is inserted into the database then you shouldn't need to do this.

 

If you want to make your code a function then do this

function deleteEmptyRecords($dbname)
{
$sql="DELETE FROM ".$dbname." . property WHERE property . id=''";
mysql_query($sql) or die("<b>A fatal MySQL error occured</b>.\n<br />Query: " . $sql . "<br />\nError: (" . mysql_errno() . ") " . mysql_error());

$sql="DELETE FROM ".$dbname." . agents WHERE agents . ip_source=''";
mysql_query($sql) or die("<b>A fatal MySQL error occured</b>.\n<br />Query: " . $sql . "<br />\nError: (" . mysql_errno() . ") " . mysql_error());

$sql="DELETE FROM ".$dbname." . settings WHERE settings . prop_id=''";
mysql_query($sql) or die("<b>A fatal MySQL error occured</b>.\n<br />Query: " . $sql . "<br />\nError: (" . mysql_errno() . ") " . mysql_error());
}

 

Call it using

deleteEmptyRecords($dbname);

 

[JaredRitchey]

Thanks sincerely, but will that work even though $dbname is a dynamic variable?

[.josh]

You are supposed to pass the $dbname value to the function, when you call the function.

[wildteen88]

Should do as you're passing $dbname when it is being called

deleteEmptyRecords($dbname);

[JaredRitchey]

Okay, that makes sense now, thanks!