loops not working for me did i screw up???

[YoungNate_Black_coder]

i cant understand why this isnt working ....

 

i have some functions worte up on anoter page but i cant get them to show up..

<?
<?
switch($_GET){
case (isset($_GET['state'])&&($_GET['city'])&&($_GET['cat'])&&($_GET['aid'])):
ad($id);
break;
case (isset($_GET['state'])&&($_GET['city'])&&($_GET['cat'])):		
ads($state,$city,$cats);
break;
case (isset($_GET['state'])&&($_GET['city'])):		
all_cats($state,$city);
break;
case (isset($_GET['state'])):		
all_city($sid);
break;
default: ?>
<form action="">
<select>
<? all_states; ?>
</select>
<button class="b_l_r" type="submit">Find Citties...</button>
</form>
<? 
break;}?>

?>

[monkeytooth]

<?
<?
switch($_GET){

 

the double <? may be screwing you up..

 

($_GET['city'])&&($_GET['cat'])&&($_GET['aid'])

 

as might not doing isset() around each of those..

[QuickOldCar]

what's this?

 

<? all_states; ?>

 

If that's php it should echo

Is it a variable?

<?php echo $all_states; ?>

 

You should also not be using short tags like <? and use <?php instead

[monkeytooth]

QuickOldCar, valid points.. missed the lack of an echo.. and I should have definitively mentioned the no short code concept (bad practice, as I know eventually the shorts are supposed to be snubbed out from support php6 i think?)

[YoungNate_Black_coder]

the extra php tags wer putthere cause i thought that would help with the highlighting of code on this page im not that dump!

and those are functions that are being called here on this page like

function all_states{

echo "
inside a while loop....
<ahref = ""...............>
";
}