Jump to content

Problem with error message when login


Recommended Posts

The error messages "O campo Email nao foi preenchido." and "O campo Senha nao foi preenchido." are not appearing when the fileds are blank.

 

index.php

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head>

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />

<title>Login</title>

<link href="loginmodule.css" rel="stylesheet" type="text/css" />

</head>

<body>

<h1>Login</h1>

<form id="loginForm" name="loginForm" method="post" action="actions/login.php">

  <table width="300" border="0" align="left" cellpadding="2" cellspacing="0">

    <tr>

      <td width="112"><b>Email</b></td>

      <td width="188"><input name="email" type="text" class="textfield" id="email" /></td>

    </tr>

    <tr>

      <td><b>Senha</b></td>

      <td><input name="password" type="password" class="textfield" id="password" /></td>

    </tr>

<tr>

<td></td>

<td><p><a href="resend_password.php">Esqueceu sua senha?</a></p></td>

</tr>

    <tr>

      <td> </td>

      <td><input type="submit" name="Submit" value="Login" /></td>

    </tr>

  </table>

</form>

</body>

</html>

 

actions/login.php

<?php

//Start session

session_start();



//Include database connection details

require_once('../config/config.php');



//Array to store validation errors

$errmsg_arr = array();



//Validation error flag

$errflag = false;



//Connect to mysql server

$link = mysql_connect(DB_HOST, DB_USER, DB_PASSWORD);

if(!$link) {

	die('Failed to connect to server: ' . mysql_error());

}



//Select database

$db = mysql_select_db(DB_DATABASE);

if(!$db) {

	die("Unable to select database");

}



//Function to sanitize values received from the form. Prevents SQL injection

function clean($str) {

	$str = @trim($str);

	if(get_magic_quotes_gpc()) {

		$str = stripslashes($str);

	}

	return mysql_real_escape_string($str);

}



//Sanitize the POST values

$email = clean($_POST['email']);

$password = clean($_POST['password']);



//Input Validations

if($email == '') {

	$errmsg_arr[] = 'O campo Email nao foi preenchido.';

	$errflag = true;

}

if($password == '') {

	$errmsg_arr[] = 'O campo Senha nao foi preenchido.';

	$errflag = true;

}



//If there are input validations, redirect back to the login form

if($errflag) {

	$_SESSION['ERRMSG_ARR'] = $errmsg_arr;

	session_write_close();

	header("location: ../index.php");

	exit();

}



//Create query

$qry="SELECT * FROM members WHERE email='$email' AND passwd='".md5($_POST['password'])."'";

$result=mysql_query($qry);



//Check whether the query was successful or not

if($result) {

	if(mysql_num_rows($result) == 1) {

		//Login Successful

		session_regenerate_id();

		$member = mysql_fetch_assoc($result);

		$_SESSION['SESS_MEMBER_ID'] = $member['member_id'];

		$_SESSION['SESS_NAME'] = $member['name'];

		session_write_close();

		header("location: ../home.php");

		exit();

	}else {

		//Login failed

		header("location: ../login_failed.php");

		exit();

	}

}else {

	die("Query failed");

}

?>

Link to comment
Share on other sites

How do you expect PHP held data to appear on a page without any PHP on it?

 

index.php

<?php
session_start();
if(isset($_SESSION['ERRMSG_ARR'])) {
$errors = implode('<br />',$_SESSION['ERRMSG_ARR']);
}else {
$errors = NULL;
}
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head>

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />

<title>Login</title>

<link href="loginmodule.css" rel="stylesheet" type="text/css" />

</head>

<body>

<h1>Login</h1>

<form id="loginForm" name="loginForm" method="post" action="actions/login.php">

  <table width="300" border="0" align="left" cellpadding="2" cellspacing="0">

    <tr>

      <td width="112"><b>Email</b></td>

      <td width="188"><input name="email" type="text" class="textfield" id="email" /></td>

    </tr>

    <tr>

      <td><b>Senha</b></td>

      <td><input name="password" type="password" class="textfield" id="password" /></td>

    </tr>

<tr>

<td></td>

<td><p><a href="resend_password.php">Esqueceu sua senha?</a></p></td>

</tr>

    <tr>

      <td> </td>

      <td><input type="submit" name="Submit" value="Login" />
<?php echo $errors; ?></td>

    </tr>

  </table>

</form>

</body>

</html>

Link to comment
Share on other sites

Thanks. I used:

 

<?php

session_start();

?>

 

and

 

<?php

if( isset($_SESSION['ERRMSG_ARR']) && is_array($_SESSION['ERRMSG_ARR']) && count($_SESSION['ERRMSG_ARR']) >0 ) {

	echo '<ul class="err">';

	foreach($_SESSION['ERRMSG_ARR'] as $msg) {

		echo '<li>',$msg,'</li>'; 

	}

	echo '</ul>';

	unset($_SESSION['ERRMSG_ARR']);

}

?>

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.