PHP Pagination help...

Jnerocorp · September 13, 2011

Hello,

I am trying to incorporate pagination to only show 20 rows per page but instead the links work but shows all rows on all pages.

Link to see: http://webjax.99k.org/

Full Code:

<?php
include ("./header.php");

//PAGINATION

$sql = "SELECT COUNT(*) FROM servers";
$result = mysql_query($sql) or trigger_error("SQL", E_USER_ERROR);
$r = mysql_fetch_row($result);
$numrows = $r[0];

// number of rows to show per page

$rowsperpage = 20;
// find out total pages
$totalpages = ceil($numrows / $rowsperpage);

// get the current page or set a default
if (isset($_GET['currentpage']) && is_numeric($_GET['currentpage'])) {
   // cast var as int
   $currentpage = (int) $_GET['currentpage'];
} else {
   // default page num
   $currentpage = 1;
} // end if

// if current page is greater than total pages...
if ($currentpage > $totalpages) {
   // set current page to last page
   $currentpage = $totalpages;
} // end if
// if current page is less than first page...
if ($currentpage < 1) {
   // set current page to first page
   $currentpage = 1;
} // end if

// the offset of the list, based on current page 
$offset = ($currentpage - 1) * $rowsperpage;

//END PAGINATION


//======================================================================== Commands
If (isSet($_GET['sort']))
{
$sortby = $_GET['sort'];
If ($sortby=='name' || $sortby=='ip' || $sortby=='votes' || $sortby=='username')
{
	If ($sortby=='name')
	{
		$options = "<option value='./index.php?sort=name' selected='selected'>Name</option>
					<option value='./index.php?sort=ip'>IP Address</option>
					<option value='./index.php?sort=votes'>Rank</option>
					<option value='./index.php?sort=username'>Owner</option>";
	}
	If ($sortby=='ip')
	{
		$options = "<option value='./index.php?sort=name'>Name</option>
					<option value='./index.php?sort=ip' selected='selected'>IP Address</option>
					<option value='./index.php?sort=votes'>Rank</option>
					<option value='./index.php?sort=username'>Owner</option>";
	}
	If ($sortby=='votes')
	{
		$options = "<option value='./index.php?sort=name'>Name</option>
					<option value='./index.php?sort=ip'>IP Address</option>
					<option value='./index.php?sort=votes' selected='selected'>Rank</option>
					<option value='./index.php?sort=username'>Owner</option>";
	}
	If ($sortby=='username')
	{
		$options = "<option value='./index.php?sort=name'>Name</option>
					<option value='./index.php?sort=ip'>IP Address</option>
					<option value='./index.php?sort=votes'>Rank</option>
					<option value='./index.php?sort=username' selected='selected'>Owner</option>";
	}
}
else
{
	$sortby = "votes";
	$options = "<option value='./index.php?sort=name'>Name</option>
				<option value='./index.php?sort=ip'>IP Address</option>
				<option value='./index.php?sort=votes' selected='selected'>Rank</option>
				<option value='./index.php?sort=username'>Owner</option>";
}
}
else
{
$sortby = "votes";
$options = "<option value='./index.php?sort=name'>Name</option>
			<option value='./index.php?sort=ip'>IP Address</option>
			<option value='./index.php?sort=votes' selected='selected'>Rank</option>
			<option value='./index.php?sort=username'>Owner</option>";
}
If ($_GET['act']=='see' && isSet($_GET['id']))
{
//=================================================================== XSS protection
$sid = str_replace("/", "", $_GET['id']);
$sid = str_replace(Chr(92), "", $sid);
$sid = str_replace("'", "", $sid);
$sid = str_replace('"', "", $sid);
$sid = str_replace("<", "", $sid);
$sid = str_replace(">", "", $sid);
$sid = str_replace("-", "", $sid);
$sid = str_replace("union", "", $sid);
$sid = str_replace("information_schema", "", $sid);
$sid = strtolower(trim($sid));
//=================================================================== XSS protection
$result = mysql_query("SELECT * FROM servers WHERE id='$sid'") or die (mysql_error());
$nr = mysql_num_rows($result);
If ($nr<='0')
{
	$exist = "No";
}
else
{
	$exist = "Yes";
	while($row = mysql_fetch_array($result))
	{
		If ($row['name']=='')
		{
			$servername = "<img src='./banners/" .$row['banner']. "' style='width:468px;height:60px' title='Server details'>";
		}
		else
		{
			$servername = $row['name'];
		}
		$did			= $row['id'];
		$dname 			= $row['name'];
		$dbanner 		= $row['banner'];
		$dip 			= $row['ip'];
		$ddescription 	= $row['description'];
		$dwebsite 		= $row['website'];
		$dcountry 		= $row['country'];
		$dsponsored 	= $row['sponsored'];
		$dvotes 		= $row['votes'];
		$mineq			= $row['mineq'];
		$dusername 		= $row['username'];
		$ddate 			= $row['date'];
		If ($dusername==$username)
		{
			$me = "Yes";
		}
		else
		{
			$me = "No";
		}
		If ($mineq=='Yes')
		{
			If (!$dip=='')
			{
				include ("./minequery.class.php");
				$mine 		= array((Minequery::query($dip)));
				$donlinep 	= $mine["0"]["playerCount"];
				If ($donlinep>0)
				{
					for ($i = 0; $i <= $donlinep; $i++)
					{
						$playername = $mine["0"]["playerList"][$i];
						If (!$playername=='')
						{
							$donline .= $playername. ", ";
						}
					}
					$donline = left($donline, strlen($donline)-2);
				}
			}
			else
			{
				$donline 	= "<i>n/a</i>";
			}
		}
		else
		{
			$donline 	= "<i>n/a</i>";
		}
	}
}
}
If ($_GET['act']=='' || $_GET['act']=='sponsored' || $_GET['act']=='myservers')
{
$result = mysql_query("SELECT * FROM servers ORDER BY votes DESC") or die (mysql_error());
while($rk_list[] = mysql_fetch_array($result));
If (isSet($username) && $_GET['act']=='myservers')
{
	$result = mysql_query("SELECT * FROM servers WHERE username='$username' ORDER BY id DESC") or die (mysql_error());
}
else
{
	If ($_GET['act']=='sponsored')
	{
		$result = mysql_query("SELECT * FROM servers WHERE sponsored='Yes' ORDER BY id DESC") or die (mysql_error());
	}
	else
	{
		If (isSet($_GET['country']))
		{
			$result = mysql_query("SELECT * FROM servers WHERE country='$_GET[country]' ORDER BY votes DESC") or die (mysql_error());
		}
		else
		{
			$result = mysql_query("SELECT * FROM servers ORDER BY $sortby DESC") or die (mysql_error());
		}
	}
}
$nr = mysql_num_rows($result);
If ($nr<='0')
{
	$serverslist = "<tr><td align='center' colspan='6'>There are no servers added yet !</td></tr>";
}
else
{
	include ("./minequery.class.php");
	$rank = "0";
	while($row = mysql_fetch_array($result)){
	$data[] = $row; }
	foreach ($data as $row)
	{
		$rank = ($rank + 1);
		If ($row['banner']=='')
		{
			$servername = $row['name'];
		}
		else
		{
			$servername = "<img src='" .$row['banner']. "' style='width:400px;height:60px' title='Server details'>";
		}
		If ($row['sponsored']=='Yes')
		{
			$star = "style='background:url(./images/star.png);background-repeat:no-repeat;'";
		}
		else
		{
			$star = "";
		}
		If ($row['mineq']=='Yes')
		{
			If (!$row['ip']=='')
			{
				$mine 		= array((Minequery::query($row['ip'])));
				$onlinep 	= $mine["0"]["playerCount"];
			}
			else
			{
				$onlinep	= "<i>n/a</i>";
			}
		}
		else
		{
			$onlinep	= "<i>n/a</i>";
		}
		$country = "./flags/" .$row['country']. ".png";
		$serverslist .= "<tr><td align='center'>" .(array_search($row, $rk_list) + 1). "</td><td align='center'><a href='./index.php?country=" .$row['country']. "'><img src='" .$country. "' title='" .$row['country']. "' style='width:32px;height:32px;'></a></td><td align='center' valign='middle' style='height:60px;'><a class='nav' href='./index.php?act=see&id=" .$row['id']. "' title='Server details'>" .$servername. "</a></td><td align='center' " .$star. ">" .$row['ip']. "</td><td align='center'>" .$onlinep. "</td><td align='center'>" .$row['votes']. "</td></tr>";
		//$serverslist .= "<tr><td align='center'>" .$row['id']. "</td><td align='center' valign='middle' style='height:60px;'><a class='nav' href='./index.php?act=see&id=" .$row['id']. "' title='Server details'>" .$servername. "</a></td><td align='center'><img src='./flags/" .$row['country']. ".ico' title='" .$row['country']. "'> " .$row['ip']. "</td><td align='center'>" .$row['votes']. "</td><td align='center'>" .$row['date']. "</td></tr>";
		//$serverslist .= "<tr><td align='center'>" .$row['id']. "</td><td align='center'>" .$servername. "</td><td align='center'>" .country_flag($row['ip']). " " .$row['ip']. "</td><td align='center'>" .$row['votes']. "</td></tr>";
	}
}
}

/******  build the pagination links ******/
// range of num links to show
$range = 3;

// if not on page 1, don't show back links
if ($currentpage > 1) {
   // show << link to go back to page 1
   echo " <a href='./{$_SERVER['PHP_SELF']}?currentpage=1'><<</a> ";
   // get previous page num
   $prevpage = $currentpage - 1;
   // show < link to go back to 1 page
   echo " <a href='./{$_SERVER['PHP_SELF']}?currentpage=$prevpage'><</a> ";
} // end if 

// loop to show links to range of pages around current page
for ($x = ($currentpage - $range); $x < (($currentpage + $range) + 1); $x++) {
   // if it's a valid page number...
   if (($x > 0) && ($x <= $totalpages)) {
      // if we're on current page...
      if ($x == $currentpage) {
         // 'highlight' it but don't make a link
         echo " [<b>$x</b>] ";
      // if not current page...
      } else {
         // make it a link
         echo " <a href='./{$_SERVER['PHP_SELF']}?currentpage=$x'>$x</a> ";
      } // end else
   } // end if 
} // end for
                 
// if not on last page, show forward and last page links        
if ($currentpage != $totalpages) {
   // get next page
   $nextpage = $currentpage + 1;
    // echo forward link for next page 
   echo " <a href='./{$_SERVER['PHP_SELF']}?currentpage=$nextpage'>></a> ";
   // echo forward link for lastpage
   echo " <a href='./{$_SERVER['PHP_SELF']}?currentpage=$totalpages'>>></a> ";
} // end if
/****** end build pagination links ******/

//======================================================================== Strings
$countries = 	"<option>Afghanistan</option>
			<option>Albania</option>
			<option>Algeria</option>
			<option>Andorra</option>
			<option>Angola</option>
			<option>Antigua and Barbuda</option>
			<option>Argentina</option>
			<option>Armenia</option>
			<option>Aruba</option>
			<option>Australia</option>
			<option>Austria</option>
			<option>Azerbaijan</option>
			<option>Bahamas, The</option>
			<option>Bahrain</option>
			<option>Bangladesh</option>
			<option>Barbados</option>
			<option>Belarus</option>
			<option>Belgium</option>
			<option>Belize</option>
			<option>Benin</option>
			<option>Bermuda</option>
			<option>Bhutan</option>
			<option>Bolivia</option>
			<option>Bosnia and Herzegovina</option>
			<option>Botswana</option>
			<option>Brazil</option>
			<option>Brunei</option>
			<option>Bulgaria</option>
			<option>Burkina Faso</option>
			<option>Burma</option>
			<option>Burundi</option>
			<option>Cambodia</option>
			<option>Cameroon</option>
			<option>Canada</option>
			<option>Cape Verde</option>
			<option>Cayman Islands</option>
			<option>Central African Republic</option>
			<option>Chad</option>
			<option>Chile</option>
			<option>China</option>
			<option>Colombia</option>
			<option>Comoros</option>
			<option>Congo, Democratic Republic of the</option>
			<option>Congo, Republic of the</option>
			<option>Costa Rica</option>
			<option>Cote d'Ivoire</option>
			<option>Croatia</option>
			<option>Cuba</option>
			<option>Curacao</option>
			<option>Cyprus</option>
			<option>Czech Republic</option>
			<option>Denmark</option>
			<option>Djibouti</option>
			<option>Dominica</option>
			<option>Dominican Republic</option>
			<option>Ecuador</option>
			<option>Egypt</option>
			<option>El Salvador</option>
			<option>Equatorial Guinea</option>
			<option>Eritrea</option>
			<option>Estonia</option>
			<option>Ethiopia</option>
			<option>Fiji</option>
			<option>Finland</option>
			<option>France</option>
			<option>Gabon</option>
			<option>Gambia</option>
			<option>Georgia</option>
			<option>Germany</option>
			<option>Ghana</option>
			<option>Greece</option>
			<option>Grenada</option>
			<option>Guatemala</option>
			<option>Guinea</option>
			<option>Guinea-Bissau</option>
			<option>Guyana</option>
			<option>Haiti</option>
			<option>Holy See</option>
			<option>Honduras</option>
			<option>Hong Kong</option>
			<option>Hungary</option>
			<option>Iceland</option>
			<option>India</option>
			<option>Indonesia</option>
			<option>Iran</option>
			<option>Iraq</option>
			<option>Ireland</option>
			<option>Israel</option>
			<option>Italy</option>
			<option>Jamaica</option>
			<option>Japan</option>
			<option>Jordan</option>
			<option>Kazakhstan</option>
			<option>Kenya</option>
			<option>Kiribati</option>
			<option>Kosovo</option>
			<option>Kuwait</option>
			<option>Kyrgyzstan</option>
			<option>Laos</option>
			<option>Latvia</option>
			<option>Lebanon</option>
			<option>Lesotho</option>
			<option>Liberia</option>
			<option>Libya</option>
			<option>Liechtenstein</option>
			<option>Lithuania</option>
			<option>Luxembourg</option>
			<option>Macau</option>
			<option>Macedonia</option>
			<option>Madagascar</option>
			<option>Malawi</option>
			<option>Malaysia</option>
			<option>Maldives</option>
			<option>Mali</option>
			<option>Malta</option>
			<option>Marshall Islands</option>
			<option>Mauritania</option>
			<option>Mauritius</option>
			<option>Mexico</option>
			<option>Micronesia</option>
			<option>Moldova</option>
			<option>Monaco</option>
			<option>Mongolia</option>
			<option>Montenegro</option>
			<option>Morocco</option>
			<option>Mozambique</option>
			<option>Namibia</option>
			<option>Nauru</option>
			<option>Nepal</option>
			<option>Netherlands</option>
			<option>Netherlands Antilles</option>
			<option>New Zealand</option>
			<option>Nicaragua</option>
			<option>Niger</option>
			<option>Nigeria</option>
			<option>North Korea</option>
			<option>Norway</option>
			<option>Oman</option>
			<option>Pakistan</option>
			<option>Palau</option>
			<option>Panama</option>
			<option>Papua New Guinea</option>
			<option>Paraguay</option>
			<option>Peru</option>
			<option>Philippines</option>
			<option>Poland</option>
			<option>Portugal</option>
			<option>Qatar</option>
			<option>Romania</option>
			<option>Russia</option>
			<option>Rwanda</option>
			<option>Saint Kitts and Nevis</option>
			<option>Saint Lucia</option>
			<option>Saint Vincent and the Grenadines</option>
			<option>Samoa</option>
			<option>San Marino</option>
			<option>Sao Tome and Principe</option>
			<option>Saudi Arabia</option>
			<option>Senegal</option>
			<option>Serbia</option>
			<option>Seychelles</option>
			<option>Sierra Leone</option>
			<option>Singapore</option>
			<option>Slovakia</option>
			<option>Slovenia</option>
			<option>Solomon Islands</option>
			<option>Somalia</option>
			<option>South Africa</option>
			<option>South Korea</option>
			<option>South Sudan</option>
			<option>Spain</option>
			<option>Sri Lanka</option>
			<option>Sudan</option>
			<option>Suriname</option>
			<option>Swaziland</option>
			<option>Sweden</option>
			<option>Switzerland</option>
			<option>Syria</option>
			<option>Taiwan</option>
			<option>Tajikistan</option>
			<option>Tanzania</option>
			<option>Thailand</option>
			<option>Timor-Leste</option>
			<option>Togo</option>
			<option>Tonga</option>
			<option>Trinidad and Tobago</option>
			<option>Tunisia</option>
			<option>Turkey</option>
			<option>Turkmenistan</option>
			<option>Tuvalu</option>
			<option>Uganda</option>
			<option>Ukraine</option>
			<option>United Arab Emirates</option>
			<option>United Kingdom</option>
			<option>Uruguay</option>
			<option>Uzbekistan</option>
			<option>Vanuatu</option>
			<option>Venezuela</option>
			<option>Vietnam</option>
			<option>Yemen</option>
			<option>Zambia</option>
			<option>Zimbabwe</option>";
$servers = 	"<table align='center' class='fancy' width='100%'>
			<tr><th align='left' colspan='6'>Servers list</th></tr>
			<tr><td align='left' colspan='3'>Servers : " .$nr. "</td><td align='right' colspan='3'>Arrange by : <select name='by' onChange=location.href=this.options[this.selectedIndex].value;>" .$options. "</select></td></tr>
			<tr><th align='center' width='1%'>#</th><th align='center' width='1%'>Country</th><th align='center' width='47%'>Name / Banner</th><th align='center' width='20%'>IP Address</th><th align='center' width='1%'>Players Online</th><th align='center' width='1%'>Votes</th></tr>
			" .$serverslist. "
		</table>";
$addsv 	=	"<table align='center' class='fancy' width='100%'>
			<tr><th align='left' colspan='2'>Add server</th></tr>
			<tr><td align='left' width='100px'>Name :</td><td align='left'><input class='field' type='text' name='aname' style='width:100%;'></td></tr>
			<tr><td align='left'>Banner url :</td><td align='left'><input class='field' type='text' name='abanner' style='width:100%;'></td></tr>
			<tr><td align='left'>Description :</td><td align='left'><textarea class='textarea' name='adescription'></textarea></td></tr>
			<tr><td align='left'>IP Address :</td><td align='left'><input class='field' type='text' name='aip'></td></tr>
			<tr><td align='left'>Website :</td><td align='left'><input class='field' type='text' name='awebsite'></td></tr>
			<tr><td align='left'>Country :</td><td align='left'><select name='acountry'>" .$countries. "</select></td></tr>
			<tr><td align='left'>MineQuery :</td><td align='left'><select name='amine'><option selected='selected'>Yes</option><option>No</option></select></td></tr>
			<tr><td align='left'>Captcha :</td><td align='left'><img src='./captcha.php' title='Captcha'> <input class='field' type='text' name='captcha' style='width:100px;' maxlength='5'></td></tr>
			<tr><td> </td><td align='left'><input type='submit' name='aok' value='Add'></td></tr>
		</table>";
$login	= 	"<table align='left' class='fancy' width='40%'>
			<tr><th align='left' colspan='2'>Login</th></tr>
			<tr><td align='left' width='30%'>Username :</td><td align='left'><input class='field' type='text' name='lname'></td></tr>
			<tr><td align='left'>Password :</td><td align='left'><input class='field' type='password' name='lpass'></td></tr>
			<tr><td> </td><td align='left'><input type='submit' name='lok' value='Login'></td></tr>
		</table>";
$register = "<table align='left' class='fancy' width='45%'>
			<tr><th align='left' colspan='2'>Register</th></tr>
			<tr><td align='left' width='30%'>Username :</td><td align='left'><input class='field' type='text' name='rname'> <font color='red'>*</font></td></tr>
			<tr><td align='left'>E-mail :</td><td align='left'><input class='field' type='text' name='rmail'> <font color='red'>*</font></td></tr>
			<tr><td align='left'>Password :</td><td align='left'><input class='field' type='password' name='rpass'> <font color='red'>*</font></td></tr>
			<tr><td align='left'>Re-Password :</td><td align='left'><input class='field' type='password' name='rrepass'> <font color='red'>*</font></td></tr>
			<tr><td> </td><td align='left'><input type='submit' name='rok' value='Register'></td></tr>
		</table>";
$settings = "<table align='left' class='g' width='80%'>
			<tr><th align='left' colspan='2'>Settings</th></tr>
			<tr><td width='50%' valign='top'>
				<table align='left' class='fancy' width='100%'>
					<tr><th align='left' colspan='2'>My account</th></tr>
					<tr><td align='left'>E-mail : </td><td align='left'>" .$uemail. "</td></tr>
					<tr><td align='left'>Servers : </td><td align='left'>" .$uservers. "</td></tr>
					<tr><td align='left'>Next vote : </td><td align='left'>" .$unextvoted. "</td></tr>
					<tr><td align='left'>Join date : </td><td align='left'>" .$udate. "</td></tr>
				</table>
			</td><td width='50%' valign='top'>
				<table align='left' class='fancy' width='100%'>
					<tr><th align='left' colspan='2'>Change password</th></tr>
					<tr><td align='left'>Current password : </td><td align='left'><input type='password' name='cpass'></td></tr>
					<tr><td align='left'>New password : </td><td align='left'><input type='password' name='cnpass'></td></tr>
					<tr><td align='left'>New re-password : </td><td align='left'><input type='password' name='cnrepass'></td></tr>
					<tr><td> </td><td align='left'><input type='submit' name='cok' value='Change'></td></tr>
				</table>
			</td></tr>
		</table>";
$f = fopen("./mine.txt", "r");
while ($line = fgets($f, 9999))
{
$minetext .= $line. "";
}
fclose($f);
$minequery = "<table align='left' class='fancy' width='100%'>
		<tr><th align='left' colspan='2'>MineQuery</th></tr>
		<tr><td align='left'>
			" .$minetext. "
		</td></tr>
	</table>";
$f = fopen("./help.txt", "r");
while ($line = fgets($f, 9999))
{
$helptext .= $line. "";
}
fclose($f);
$help = "<table align='left' class='fancy' width='100%'>
		<tr><th align='left' colspan='2'>Help</th></tr>
		<tr><td align='left'>
			" .$helptext. "
		</td></tr>
	</table>";
If ($me=='No')
{
If ($dname=='')
{
	$dname = "<i>none</i>";
}
If ($dbanner=='')
{
	$dbanner = "<i>none</i>";
}
else
{
	$dbanner = "<img src='" .$dbanner. "' title='Banner' style='width:468px;height:60px'>";
}
$details =	"<table align='center' class='fancy' width='100%'>
				<tr><th align='left' colspan='2'>Server details</th></tr>
				<tr><td align='left' width='100px'>Name :</td><td align='left'>" .$dname. "</td></tr>
				<tr><td align='left'>Banner url :</td><td align='left'>" .$dbanner. "</td></tr>
				<tr><td align='left'>Description :</td><td align='left'>" .$ddescription. "</td></tr>
				<tr><td align='left'>Players online :</td><td align='left'>" .$donline. "</td></tr>
				<tr><td align='left'>IP Address :</td><td align='left'>" .$dip. "</td></tr>
				<tr><td align='left'>Website :</td><td align='left'>" .$dwebsite. "</td></tr>
				<tr><td align='left'>Sponsored :</td><td align='left'>" .$dsponsored. "</td></tr>
				<tr><td align='left'>Votes :</td><td align='left'>" .$dvotes. "</td></tr>
				<tr><td align='left'>Owner :</td><td align='left'>" .$dusername. "</td></tr>
				<tr><td align='left'>Added at :</td><td align='left'>" .$ddate. "</td></tr>
				<tr><td align='left'>Vote link :</td><td align='left'><a class='nav' href='" .$siteurl. "/vote.php?id=" .$did. "' title='Vote link'>" .$siteurl. "/vote.php?id=" .$did. "</td></tr>
			</table>";
}
else
{
$details =	"<table align='center' class='fancy' width='100%'>
				<tr><th align='left' colspan='2'>Server details</th></tr>
				<tr><td align='left' width='100px'>Name :</td><td align='left'><input class='field' type='text' name='nname' style='width:700px;' value='" .$dname. "'></td></tr>
				<tr><td align='left'>Banner url :</td><td align='left'><input class='field' type='text' name='nbanner' style='width:700px;' value='" .$dbanner. "'></td></tr>
				<tr><td align='left'>Description :</td><td align='left'><textarea class='textarea' name='ndescription'>" .$ddescription. "</textarea></td></tr>
				<tr><td align='left'>Players online :</td><td align='left'>" .$donline. "</td></tr>
				<tr><td align='left'>IP Address :</td><td align='left'><input class='field' type='text' name='nip' value='" .$dip. "'></td></tr>
				<tr><td align='left'>Website :</td><td align='left'><input class='field' type='text' name='nwebsite' value='" .$dwebsite. "'></td></tr>
				<tr><td align='left'>Vote link :</td><td align='left'><a class='nav' href='" .$siteurl. "/vote.php?id=" .$did. "' title='Vote link'>" .$siteurl. "/vote.php?id=" .$did. "</td></tr>
				<tr><td> </td><td align='left'><input type='submit' name='dok' value='Update'> <input type='submit' name='delok' value='Delete'></td></tr>
			</table>";
}
//======================================================================== Display
echo "<form method='post' action='" .curPageURL(). "' style='margin:0px;'>";
If ($sidebar=="Yes")
{
echo 	"<table align='center' width='100%'>
			<tr><td align='left' width='80%' valign='top'>";
}
If ($_GET['act']=='add' || $_GET['act']=='see' || $_GET['act']=='login' || $_GET['act']=='register' || $_GET['act']=='settings' || $_GET['act']=='myservers' || $_GET['act']=='minequery' || $_GET['act']=='help')
{
If ($_GET['act']=='add')
{
	If (!$_SESSION['user']=='')
	{
		echo $addsv;
	}
	else
	{
		echo $login;
	}
}
If ($_GET['act']=='login')
{
	If ($_SESSION['user']=='')
	{
		echo $login;
	}
	else
	{
		echo $servers;
	}
}
If ($_GET['act']=='register')
{
	If ($_SESSION['user']=='')
	{
		echo $register;
	}
	else
	{
		echo $servers;
	}
}
If ($_GET['act']=='see')
{
	If ($exist=='Yes')
	{
		echo $details;
	}
	else
	{
		echo $servers;
	}
}
If ($_GET['act']=='settings')
{
	If ($_SESSION['user']=='')
	{
		echo $login;
	}
	else
	{
		echo $settings;
	}
}
If ($_GET['act']=='myservers')
{
	echo $servers;
}
If ($_GET['act']=='minequery')
{
	echo $minequery;
}
If ($_GET['act']=='help')
{
	echo $help;
}
}
else
{
echo $servers;
}
If ($sidebar=="Yes")
{
echo 	"</td><td align='right' width='20%' valign='top'>
			<table align='center' width='100%' class='fancy'>
				" .$rsidead. "
			</table>
		</td></tr>
		</table>";
}
echo "</form>";
include ("./footer.php");
?>

this is where I tried to put pagination in:

If ($_GET['act']=='' || $_GET['act']=='sponsored' || $_GET['act']=='myservers')
{
$result = mysql_query("SELECT * FROM servers ORDER BY votes DESC") or die (mysql_error());
while($rk_list[] = mysql_fetch_array($result));
If (isSet($username) && $_GET['act']=='myservers')
{
	$result = mysql_query("SELECT * FROM servers WHERE username='$username' ORDER BY id DESC") or die (mysql_error());
}
else
{
	If ($_GET['act']=='sponsored')
	{
		$result = mysql_query("SELECT * FROM servers WHERE sponsored='Yes' ORDER BY id DESC") or die (mysql_error());
	}
	else
	{
		If (isSet($_GET['country']))
		{
			$result = mysql_query("SELECT * FROM servers WHERE country='$_GET[country]' ORDER BY votes DESC") or die (mysql_error());
		}
		else
		{
			$result = mysql_query("SELECT * FROM servers ORDER BY $sortby DESC") or die (mysql_error());
		}
	}
}
$nr = mysql_num_rows($result);
If ($nr<='0')
{
	$serverslist = "<tr><td align='center' colspan='6'>There are no servers added yet !</td></tr>";
}
else
{
	include ("./minequery.class.php");
	$rank = "0";
	while($row = mysql_fetch_array($result)){
	$data[] = $row; }
	foreach ($data as $row)
	{
		$rank = ($rank + 1);
		If ($row['banner']=='')
		{
			$servername = $row['name'];
		}
		else
		{
			$servername = "<img src='" .$row['banner']. "' style='width:400px;height:60px' title='Server details'>";
		}
		If ($row['sponsored']=='Yes')
		{
			$star = "style='background:url(./images/star.png);background-repeat:no-repeat;'";
		}
		else
		{
			$star = "";
		}
		If ($row['mineq']=='Yes')
		{
			If (!$row['ip']=='')
			{
				$mine 		= array((Minequery::query($row['ip'])));
				$onlinep 	= $mine["0"]["playerCount"];
			}
			else
			{
				$onlinep	= "<i>n/a</i>";
			}
		}
		else
		{
			$onlinep	= "<i>n/a</i>";
		}
		$country = "./flags/" .$row['country']. ".png";
		$serverslist .= "<tr><td align='center'>" .(array_search($row, $rk_list) + 1). "</td><td align='center'><a href='./index.php?country=" .$row['country']. "'><img src='" .$country. "' title='" .$row['country']. "' style='width:32px;height:32px;'></a></td><td align='center' valign='middle' style='height:60px;'><a class='nav' href='./index.php?act=see&id=" .$row['id']. "' title='Server details'>" .$servername. "</a></td><td align='center' " .$star. ">" .$row['ip']. "</td><td align='center'>" .$onlinep. "</td><td align='center'>" .$row['votes']. "</td></tr>";
		//$serverslist .= "<tr><td align='center'>" .$row['id']. "</td><td align='center' valign='middle' style='height:60px;'><a class='nav' href='./index.php?act=see&id=" .$row['id']. "' title='Server details'>" .$servername. "</a></td><td align='center'><img src='./flags/" .$row['country']. ".ico' title='" .$row['country']. "'> " .$row['ip']. "</td><td align='center'>" .$row['votes']. "</td><td align='center'>" .$row['date']. "</td></tr>";
		//$serverslist .= "<tr><td align='center'>" .$row['id']. "</td><td align='center'>" .$servername. "</td><td align='center'>" .country_flag($row['ip']). " " .$row['ip']. "</td><td align='center'>" .$row['votes']. "</td></tr>";
	}
}
}

/******  build the pagination links ******/
// range of num links to show
$range = 3;

// if not on page 1, don't show back links
if ($currentpage > 1) {
   // show << link to go back to page 1
   echo " <a href='./{$_SERVER['PHP_SELF']}?currentpage=1'><<</a> ";
   // get previous page num
   $prevpage = $currentpage - 1;
   // show < link to go back to 1 page
   echo " <a href='./{$_SERVER['PHP_SELF']}?currentpage=$prevpage'><</a> ";
} // end if 

// loop to show links to range of pages around current page
for ($x = ($currentpage - $range); $x < (($currentpage + $range) + 1); $x++) {
   // if it's a valid page number...
   if (($x > 0) && ($x <= $totalpages)) {
      // if we're on current page...
      if ($x == $currentpage) {
         // 'highlight' it but don't make a link
         echo " [<b>$x</b>] ";
      // if not current page...
      } else {
         // make it a link
         echo " <a href='./{$_SERVER['PHP_SELF']}?currentpage=$x'>$x</a> ";
      } // end else
   } // end if 
} // end for
                 
// if not on last page, show forward and last page links        
if ($currentpage != $totalpages) {
   // get next page
   $nextpage = $currentpage + 1;
    // echo forward link for next page 
   echo " <a href='./{$_SERVER['PHP_SELF']}?currentpage=$nextpage'>></a> ";
   // echo forward link for lastpage
   echo " <a href='./{$_SERVER['PHP_SELF']}?currentpage=$totalpages'>>></a> ";
} // end if
/****** end build pagination links ******/

I'm not sure what im doing wrong can anyone help?

PFMaBiSmAd · September 13, 2011

Pagination requires that you form two similar queries. The first one to get a count (usually with a SELECT COUNT(*) term) of the rows that match the WHERE clause you are using (which is not necessarily all the rows in your table), the second one with a LIMIT clause added on the end of the query to get the correct set of rows for the requested page.

In order for your code to accomplish this, you will need to start by building the desired query in a php variable, rather than forming the query inside of the msyql_query() statement. Once you have the base query built with the desired WHERE clause, you can then use that query in the pagination logic.

Jnerocorp · September 13, 2011

hmmm im not sure how to do that I didnt create this script im just trying to make it have pages to show 20 at a time instead of all at once.

PFMaBiSmAd · September 13, 2011

It would probably be best if you posted the original script, without any of the pagination logic.

Jnerocorp · September 13, 2011

Here it is:

index.php

<?php
include ("./header.php");

//======================================================================== Commands
If (isSet($_GET['sort']))
{
$sortby = $_GET['sort'];
If ($sortby=='name' || $sortby=='ip' || $sortby=='votes' || $sortby=='username')
{
	If ($sortby=='name')
	{
		$options = "<option value='./index.php?sort=name' selected='selected'>Name</option>
					<option value='./index.php?sort=ip'>IP Address</option>
					<option value='./index.php?sort=votes'>Rank</option>
					<option value='./index.php?sort=username'>Owner</option>";
	}
	If ($sortby=='ip')
	{
		$options = "<option value='./index.php?sort=name'>Name</option>
					<option value='./index.php?sort=ip' selected='selected'>IP Address</option>
					<option value='./index.php?sort=votes'>Rank</option>
					<option value='./index.php?sort=username'>Owner</option>";
	}
	If ($sortby=='votes')
	{
		$options = "<option value='./index.php?sort=name'>Name</option>
					<option value='./index.php?sort=ip'>IP Address</option>
					<option value='./index.php?sort=votes' selected='selected'>Rank</option>
					<option value='./index.php?sort=username'>Owner</option>";
	}
	If ($sortby=='username')
	{
		$options = "<option value='./index.php?sort=name'>Name</option>
					<option value='./index.php?sort=ip'>IP Address</option>
					<option value='./index.php?sort=votes'>Rank</option>
					<option value='./index.php?sort=username' selected='selected'>Owner</option>";
	}
}
else
{
	$sortby = "votes";
	$options = "<option value='./index.php?sort=name'>Name</option>
				<option value='./index.php?sort=ip'>IP Address</option>
				<option value='./index.php?sort=votes' selected='selected'>Rank</option>
				<option value='./index.php?sort=username'>Owner</option>";
}
}
else
{
$sortby = "votes";
$options = "<option value='./index.php?sort=name'>Name</option>
			<option value='./index.php?sort=ip'>IP Address</option>
			<option value='./index.php?sort=votes' selected='selected'>Rank</option>
			<option value='./index.php?sort=username'>Owner</option>";
}
If ($_GET['act']=='see' && isSet($_GET['id']))
{
//=================================================================== XSS protection
$sid = str_replace("/", "", $_GET['id']);
$sid = str_replace(Chr(92), "", $sid);
$sid = str_replace("'", "", $sid);
$sid = str_replace('"', "", $sid);
$sid = str_replace("<", "", $sid);
$sid = str_replace(">", "", $sid);
$sid = str_replace("-", "", $sid);
$sid = str_replace("union", "", $sid);
$sid = str_replace("information_schema", "", $sid);
$sid = strtolower(trim($sid));
//=================================================================== XSS protection
$result = mysql_query("SELECT * FROM servers WHERE id='$sid'") or die (mysql_error());
$nr = mysql_num_rows($result);
If ($nr<='0')
{
	$exist = "No";
}
else
{
	$exist = "Yes";
	while($row = mysql_fetch_array($result))
	{
		If ($row['name']=='')
		{
			$servername = "<img src='./banners/" .$row['banner']. "' style='width:468px;height:60px' title='Server details'>";
		}
		else
		{
			$servername = $row['name'];
		}
		$did			= $row['id'];
		$dname 			= $row['name'];
		$dbanner 		= $row['banner'];
		$dip 			= $row['ip'];
		$ddescription 	= $row['description'];
		$dwebsite 		= $row['website'];
		$dcountry 		= $row['country'];
		$dsponsored 	= $row['sponsored'];
		$dvotes 		= $row['votes'];
		$mineq			= $row['mineq'];
		$dusername 		= $row['username'];
		$ddate 			= $row['date'];
		If ($dusername==$username)
		{
			$me = "Yes";
		}
		else
		{
			$me = "No";
		}
		If ($mineq=='Yes')
		{
			If (!$dip=='')
			{
				include ("./minequery.class.php");
				$mine 		= array((Minequery::query($dip)));
				$donlinep 	= $mine["0"]["playerCount"];
				If ($donlinep>0)
				{
					for ($i = 0; $i <= $donlinep; $i++)
					{
						$playername = $mine["0"]["playerList"][$i];
						If (!$playername=='')
						{
							$donline .= $playername. ", ";
						}
					}
					$donline = left($donline, strlen($donline)-2);
				}
			}
			else
			{
				$donline 	= "<i>n/a</i>";
			}
		}
		else
		{
			$donline 	= "<i>n/a</i>";
		}
	}
}
}
If ($_GET['act']=='' || $_GET['act']=='sponsored' || $_GET['act']=='myservers')
{
$result = mysql_query("SELECT * FROM servers ORDER BY votes DESC") or die (mysql_error());
while($rk_list[] = mysql_fetch_array($result));
If (isSet($username) && $_GET['act']=='myservers')
{
	$result = mysql_query("SELECT * FROM servers WHERE username='$username' ORDER BY id DESC") or die (mysql_error());
}
else
{
	If ($_GET['act']=='sponsored')
	{
		$result = mysql_query("SELECT * FROM servers WHERE sponsored='Yes' ORDER BY id DESC") or die (mysql_error());
	}
	else
	{
		If (isSet($_GET['country']))
		{
			$result = mysql_query("SELECT * FROM servers WHERE country='$_GET[country]' ORDER BY votes DESC") or die (mysql_error());
		}
		else
		{
			$result = mysql_query("SELECT * FROM servers ORDER BY $sortby DESC") or die (mysql_error());
		}
	}
}
$nr = mysql_num_rows($result);
If ($nr<='0')
{
	$serverslist = "<tr><td align='center' colspan='6'>There are no servers added yet !</td></tr>";
}
else
{
	include ("./minequery.class.php");
	$rank = "0";
	while($row = mysql_fetch_array($result)){
	$data[] = $row; }
	foreach ($data as $row)
	{
		$rank = ($rank + 1);
		If ($row['banner']=='')
		{
			$servername = $row['name'];
		}
		else
		{
			$servername = "<img src='" .$row['banner']. "' style='width:400px;height:60px' title='Server details'>";
		}
		If ($row['sponsored']=='Yes')
		{
			$star = "style='background:url(./images/star.png);background-repeat:no-repeat;'";
		}
		else
		{
			$star = "";
		}
		If ($row['mineq']=='Yes')
		{
			If (!$row['ip']=='')
			{
				$mine 		= array((Minequery::query($row['ip'])));
				$onlinep 	= $mine["0"]["playerCount"];
			}
			else
			{
				$onlinep	= "<i>n/a</i>";
			}
		}
		else
		{
			$onlinep	= "<i>n/a</i>";
		}
		$country = "./flags/" .$row['country']. ".png";
		$serverslist .= "<tr><td align='center'>" .(array_search($row, $rk_list) + 1). "</td><td align='center'><a href='./index.php?country=" .$row['country']. "'><img src='" .$country. "' title='" .$row['country']. "' style='width:32px;height:32px;'></a></td><td align='center' valign='middle' style='height:60px;'><a class='nav' href='./index.php?act=see&id=" .$row['id']. "' title='Server details'>" .$servername. "</a></td><td align='center' " .$star. ">" .$row['ip']. "</td><td align='center'>" .$onlinep. "</td><td align='center'>" .$row['votes']. "</td></tr>";
		//$serverslist .= "<tr><td align='center'>" .$row['id']. "</td><td align='center' valign='middle' style='height:60px;'><a class='nav' href='./index.php?act=see&id=" .$row['id']. "' title='Server details'>" .$servername. "</a></td><td align='center'><img src='./flags/" .$row['country']. ".ico' title='" .$row['country']. "'> " .$row['ip']. "</td><td align='center'>" .$row['votes']. "</td><td align='center'>" .$row['date']. "</td></tr>";
		//$serverslist .= "<tr><td align='center'>" .$row['id']. "</td><td align='center'>" .$servername. "</td><td align='center'>" .country_flag($row['ip']). " " .$row['ip']. "</td><td align='center'>" .$row['votes']. "</td></tr>";
	}
}
}

//======================================================================== Strings
$countries = 	"<option>Afghanistan</option>
			<option>Albania</option>
			<option>Algeria</option>
			<option>Andorra</option>
			<option>Angola</option>
			<option>Antigua and Barbuda</option>
			<option>Argentina</option>
			<option>Armenia</option>
			<option>Aruba</option>
			<option>Australia</option>
			<option>Austria</option>
			<option>Azerbaijan</option>
			<option>Bahamas, The</option>
			<option>Bahrain</option>
			<option>Bangladesh</option>
			<option>Barbados</option>
			<option>Belarus</option>
			<option>Belgium</option>
			<option>Belize</option>
			<option>Benin</option>
			<option>Bermuda</option>
			<option>Bhutan</option>
			<option>Bolivia</option>
			<option>Bosnia and Herzegovina</option>
			<option>Botswana</option>
			<option>Brazil</option>
			<option>Brunei</option>
			<option>Bulgaria</option>
			<option>Burkina Faso</option>
			<option>Burma</option>
			<option>Burundi</option>
			<option>Cambodia</option>
			<option>Cameroon</option>
			<option>Canada</option>
			<option>Cape Verde</option>
			<option>Cayman Islands</option>
			<option>Central African Republic</option>
			<option>Chad</option>
			<option>Chile</option>
			<option>China</option>
			<option>Colombia</option>
			<option>Comoros</option>
			<option>Congo, Democratic Republic of the</option>
			<option>Congo, Republic of the</option>
			<option>Costa Rica</option>
			<option>Cote d'Ivoire</option>
			<option>Croatia</option>
			<option>Cuba</option>
			<option>Curacao</option>
			<option>Cyprus</option>
			<option>Czech Republic</option>
			<option>Denmark</option>
			<option>Djibouti</option>
			<option>Dominica</option>
			<option>Dominican Republic</option>
			<option>Ecuador</option>
			<option>Egypt</option>
			<option>El Salvador</option>
			<option>Equatorial Guinea</option>
			<option>Eritrea</option>
			<option>Estonia</option>
			<option>Ethiopia</option>
			<option>Fiji</option>
			<option>Finland</option>
			<option>France</option>
			<option>Gabon</option>
			<option>Gambia</option>
			<option>Georgia</option>
			<option>Germany</option>
			<option>Ghana</option>
			<option>Greece</option>
			<option>Grenada</option>
			<option>Guatemala</option>
			<option>Guinea</option>
			<option>Guinea-Bissau</option>
			<option>Guyana</option>
			<option>Haiti</option>
			<option>Holy See</option>
			<option>Honduras</option>
			<option>Hong Kong</option>
			<option>Hungary</option>
			<option>Iceland</option>
			<option>India</option>
			<option>Indonesia</option>
			<option>Iran</option>
			<option>Iraq</option>
			<option>Ireland</option>
			<option>Israel</option>
			<option>Italy</option>
			<option>Jamaica</option>
			<option>Japan</option>
			<option>Jordan</option>
			<option>Kazakhstan</option>
			<option>Kenya</option>
			<option>Kiribati</option>
			<option>Kosovo</option>
			<option>Kuwait</option>
			<option>Kyrgyzstan</option>
			<option>Laos</option>
			<option>Latvia</option>
			<option>Lebanon</option>
			<option>Lesotho</option>
			<option>Liberia</option>
			<option>Libya</option>
			<option>Liechtenstein</option>
			<option>Lithuania</option>
			<option>Luxembourg</option>
			<option>Macau</option>
			<option>Macedonia</option>
			<option>Madagascar</option>
			<option>Malawi</option>
			<option>Malaysia</option>
			<option>Maldives</option>
			<option>Mali</option>
			<option>Malta</option>
			<option>Marshall Islands</option>
			<option>Mauritania</option>
			<option>Mauritius</option>
			<option>Mexico</option>
			<option>Micronesia</option>
			<option>Moldova</option>
			<option>Monaco</option>
			<option>Mongolia</option>
			<option>Montenegro</option>
			<option>Morocco</option>
			<option>Mozambique</option>
			<option>Namibia</option>
			<option>Nauru</option>
			<option>Nepal</option>
			<option>Netherlands</option>
			<option>Netherlands Antilles</option>
			<option>New Zealand</option>
			<option>Nicaragua</option>
			<option>Niger</option>
			<option>Nigeria</option>
			<option>North Korea</option>
			<option>Norway</option>
			<option>Oman</option>
			<option>Pakistan</option>
			<option>Palau</option>
			<option>Panama</option>
			<option>Papua New Guinea</option>
			<option>Paraguay</option>
			<option>Peru</option>
			<option>Philippines</option>
			<option>Poland</option>
			<option>Portugal</option>
			<option>Qatar</option>
			<option>Romania</option>
			<option>Russia</option>
			<option>Rwanda</option>
			<option>Saint Kitts and Nevis</option>
			<option>Saint Lucia</option>
			<option>Saint Vincent and the Grenadines</option>
			<option>Samoa</option>
			<option>San Marino</option>
			<option>Sao Tome and Principe</option>
			<option>Saudi Arabia</option>
			<option>Senegal</option>
			<option>Serbia</option>
			<option>Seychelles</option>
			<option>Sierra Leone</option>
			<option>Singapore</option>
			<option>Slovakia</option>
			<option>Slovenia</option>
			<option>Solomon Islands</option>
			<option>Somalia</option>
			<option>South Africa</option>
			<option>South Korea</option>
			<option>South Sudan</option>
			<option>Spain</option>
			<option>Sri Lanka</option>
			<option>Sudan</option>
			<option>Suriname</option>
			<option>Swaziland</option>
			<option>Sweden</option>
			<option>Switzerland</option>
			<option>Syria</option>
			<option>Taiwan</option>
			<option>Tajikistan</option>
			<option>Tanzania</option>
			<option>Thailand</option>
			<option>Timor-Leste</option>
			<option>Togo</option>
			<option>Tonga</option>
			<option>Trinidad and Tobago</option>
			<option>Tunisia</option>
			<option>Turkey</option>
			<option>Turkmenistan</option>
			<option>Tuvalu</option>
			<option>Uganda</option>
			<option>Ukraine</option>
			<option>United Arab Emirates</option>
			<option>United Kingdom</option>
			<option>Uruguay</option>
			<option>Uzbekistan</option>
			<option>Vanuatu</option>
			<option>Venezuela</option>
			<option>Vietnam</option>
			<option>Yemen</option>
			<option>Zambia</option>
			<option>Zimbabwe</option>";
$servers = 	"<table align='center' class='fancy' width='100%'>
			<tr><th align='left' colspan='6'>Servers list</th></tr>
			<tr><td align='left' colspan='3'>Servers : " .$nr. "</td><td align='right' colspan='3'>Arrange by : <select name='by' onChange=location.href=this.options[this.selectedIndex].value;>" .$options. "</select></td></tr>
			<tr><th align='center' width='1%'>#</th><th align='center' width='1%'>Country</th><th align='center' width='47%'>Name / Banner</th><th align='center' width='20%'>IP Address</th><th align='center' width='1%'>Players Online</th><th align='center' width='1%'>Votes</th></tr>
			" .$serverslist. "
		</table>";
$addsv 	=	"<table align='center' class='fancy' width='100%'>
			<tr><th align='left' colspan='2'>Add server</th></tr>
			<tr><td align='left' width='100px'>Name :</td><td align='left'><input class='field' type='text' name='aname' style='width:100%;'></td></tr>
			<tr><td align='left'>Banner url :</td><td align='left'><input class='field' type='text' name='abanner' style='width:100%;'></td></tr>
			<tr><td align='left'>Description :</td><td align='left'><textarea class='textarea' name='adescription'></textarea></td></tr>
			<tr><td align='left'>IP Address :</td><td align='left'><input class='field' type='text' name='aip'></td></tr>
			<tr><td align='left'>Website :</td><td align='left'><input class='field' type='text' name='awebsite'></td></tr>
			<tr><td align='left'>Country :</td><td align='left'><select name='acountry'>" .$countries. "</select></td></tr>
			<tr><td align='left'>MineQuery :</td><td align='left'><select name='amine'><option selected='selected'>Yes</option><option>No</option></select></td></tr>
			<tr><td align='left'>Captcha :</td><td align='left'><img src='./captcha.php' title='Captcha'> <input class='field' type='text' name='captcha' style='width:100px;' maxlength='5'></td></tr>
			<tr><td> </td><td align='left'><input type='submit' name='aok' value='Add'></td></tr>
		</table>";
$login	= 	"<table align='left' class='fancy' width='40%'>
			<tr><th align='left' colspan='2'>Login</th></tr>
			<tr><td align='left' width='30%'>Username :</td><td align='left'><input class='field' type='text' name='lname'></td></tr>
			<tr><td align='left'>Password :</td><td align='left'><input class='field' type='password' name='lpass'></td></tr>
			<tr><td> </td><td align='left'><input type='submit' name='lok' value='Login'></td></tr>
		</table>";
$register = "<table align='left' class='fancy' width='45%'>
			<tr><th align='left' colspan='2'>Register</th></tr>
			<tr><td align='left' width='30%'>Username :</td><td align='left'><input class='field' type='text' name='rname'> <font color='red'>*</font></td></tr>
			<tr><td align='left'>E-mail :</td><td align='left'><input class='field' type='text' name='rmail'> <font color='red'>*</font></td></tr>
			<tr><td align='left'>Password :</td><td align='left'><input class='field' type='password' name='rpass'> <font color='red'>*</font></td></tr>
			<tr><td align='left'>Re-Password :</td><td align='left'><input class='field' type='password' name='rrepass'> <font color='red'>*</font></td></tr>
			<tr><td> </td><td align='left'><input type='submit' name='rok' value='Register'></td></tr>
		</table>";
$settings = "<table align='left' class='g' width='80%'>
			<tr><th align='left' colspan='2'>Settings</th></tr>
			<tr><td width='50%' valign='top'>
				<table align='left' class='fancy' width='100%'>
					<tr><th align='left' colspan='2'>My account</th></tr>
					<tr><td align='left'>E-mail : </td><td align='left'>" .$uemail. "</td></tr>
					<tr><td align='left'>Servers : </td><td align='left'>" .$uservers. "</td></tr>
					<tr><td align='left'>Next vote : </td><td align='left'>" .$unextvoted. "</td></tr>
					<tr><td align='left'>Join date : </td><td align='left'>" .$udate. "</td></tr>
				</table>
			</td><td width='50%' valign='top'>
				<table align='left' class='fancy' width='100%'>
					<tr><th align='left' colspan='2'>Change password</th></tr>
					<tr><td align='left'>Current password : </td><td align='left'><input type='password' name='cpass'></td></tr>
					<tr><td align='left'>New password : </td><td align='left'><input type='password' name='cnpass'></td></tr>
					<tr><td align='left'>New re-password : </td><td align='left'><input type='password' name='cnrepass'></td></tr>
					<tr><td> </td><td align='left'><input type='submit' name='cok' value='Change'></td></tr>
				</table>
			</td></tr>
		</table>";
$f = fopen("./mine.txt", "r");
while ($line = fgets($f, 9999))
{
$minetext .= $line. "";
}
fclose($f);
$minequery = "<table align='left' class='fancy' width='100%'>
		<tr><th align='left' colspan='2'>MineQuery</th></tr>
		<tr><td align='left'>
			" .$minetext. "
		</td></tr>
	</table>";
$f = fopen("./help.txt", "r");
while ($line = fgets($f, 9999))
{
$helptext .= $line. "";
}
fclose($f);
$help = "<table align='left' class='fancy' width='100%'>
		<tr><th align='left' colspan='2'>Help</th></tr>
		<tr><td align='left'>
			" .$helptext. "
		</td></tr>
	</table>";
If ($me=='No')
{
If ($dname=='')
{
	$dname = "<i>none</i>";
}
If ($dbanner=='')
{
	$dbanner = "<i>none</i>";
}
else
{
	$dbanner = "<img src='" .$dbanner. "' title='Banner' style='width:468px;height:60px'>";
}
$details =	"<table align='center' class='fancy' width='100%'>
				<tr><th align='left' colspan='2'>Server details</th></tr>
				<tr><td align='left' width='100px'>Name :</td><td align='left'>" .$dname. "</td></tr>
				<tr><td align='left'>Banner url :</td><td align='left'>" .$dbanner. "</td></tr>
				<tr><td align='left'>Description :</td><td align='left'>" .$ddescription. "</td></tr>
				<tr><td align='left'>Players online :</td><td align='left'>" .$donline. "</td></tr>
				<tr><td align='left'>IP Address :</td><td align='left'>" .$dip. "</td></tr>
				<tr><td align='left'>Website :</td><td align='left'>" .$dwebsite. "</td></tr>
				<tr><td align='left'>Sponsored :</td><td align='left'>" .$dsponsored. "</td></tr>
				<tr><td align='left'>Votes :</td><td align='left'>" .$dvotes. "</td></tr>
				<tr><td align='left'>Owner :</td><td align='left'>" .$dusername. "</td></tr>
				<tr><td align='left'>Added at :</td><td align='left'>" .$ddate. "</td></tr>
				<tr><td align='left'>Vote link :</td><td align='left'><a class='nav' href='" .$siteurl. "/vote.php?id=" .$did. "' title='Vote link'>" .$siteurl. "/vote.php?id=" .$did. "</td></tr>
			</table>";
}
else
{
$details =	"<table align='center' class='fancy' width='100%'>
				<tr><th align='left' colspan='2'>Server details</th></tr>
				<tr><td align='left' width='100px'>Name :</td><td align='left'><input class='field' type='text' name='nname' style='width:700px;' value='" .$dname. "'></td></tr>
				<tr><td align='left'>Banner url :</td><td align='left'><input class='field' type='text' name='nbanner' style='width:700px;' value='" .$dbanner. "'></td></tr>
				<tr><td align='left'>Description :</td><td align='left'><textarea class='textarea' name='ndescription'>" .$ddescription. "</textarea></td></tr>
				<tr><td align='left'>Players online :</td><td align='left'>" .$donline. "</td></tr>
				<tr><td align='left'>IP Address :</td><td align='left'><input class='field' type='text' name='nip' value='" .$dip. "'></td></tr>
				<tr><td align='left'>Website :</td><td align='left'><input class='field' type='text' name='nwebsite' value='" .$dwebsite. "'></td></tr>
				<tr><td align='left'>Vote link :</td><td align='left'><a class='nav' href='" .$siteurl. "/vote.php?id=" .$did. "' title='Vote link'>" .$siteurl. "/vote.php?id=" .$did. "</td></tr>
				<tr><td> </td><td align='left'><input type='submit' name='dok' value='Update'> <input type='submit' name='delok' value='Delete'></td></tr>
			</table>";
}
//======================================================================== Display
echo "<form method='post' action='" .curPageURL(). "' style='margin:0px;'>";
If ($sidebar=="Yes")
{
echo 	"<table align='center' width='100%'>
			<tr><td align='left' width='80%' valign='top'>";
}
If ($_GET['act']=='add' || $_GET['act']=='see' || $_GET['act']=='login' || $_GET['act']=='register' || $_GET['act']=='settings' || $_GET['act']=='myservers' || $_GET['act']=='minequery' || $_GET['act']=='help')
{
If ($_GET['act']=='add')
{
	If (!$_SESSION['user']=='')
	{
		echo $addsv;
	}
	else
	{
		echo $login;
	}
}
If ($_GET['act']=='login')
{
	If ($_SESSION['user']=='')
	{
		echo $login;
	}
	else
	{
		echo $servers;
	}
}
If ($_GET['act']=='register')
{
	If ($_SESSION['user']=='')
	{
		echo $register;
	}
	else
	{
		echo $servers;
	}
}
If ($_GET['act']=='see')
{
	If ($exist=='Yes')
	{
		echo $details;
	}
	else
	{
		echo $servers;
	}
}
If ($_GET['act']=='settings')
{
	If ($_SESSION['user']=='')
	{
		echo $login;
	}
	else
	{
		echo $settings;
	}
}
If ($_GET['act']=='myservers')
{
	echo $servers;
}
If ($_GET['act']=='minequery')
{
	echo $minequery;
}
If ($_GET['act']=='help')
{
	echo $help;
}
}
else
{
echo $servers;
}
If ($sidebar=="Yes")
{
echo 	"</td><td align='right' width='20%' valign='top'>
			<table align='center' width='100%' class='fancy'>
				" .$rsidead. "
			</table>
		</td></tr>
		</table>";
}
echo "</form>";
include ("./footer.php");
?>

PFMaBiSmAd · September 13, 2011

Also, is the id column just a numerical value (if so all that "XSS protection" logic can be simplified to an (int) cast statement.)

Basically, the logic needs to be cleaned up, simplified, and understandable before worrying about adding pagination to it.

Jnerocorp · September 13, 2011

yes it is numerical, as i said i didnt create the script and i think the work is sloppy in my opinion I just want to get this working thank you for your help so far. its very appreciated

PFMaBiSmAd · September 13, 2011

The following is your code, modified to build the two different queries. The first line If (isSet($username) && $_GET['act']=='myservers') and the last line $nr = mysql_num_rows($result); are your original logic. Replace everything between those two lines with the suggested code. There are comments in the code indicating where you would add portions of the pagination logic.

<?php
If (isSet($username) && $_GET['act']=='myservers'){
	// query for username
	$query = "SELECT * FROM servers WHERE username='$username' ORDER BY id DESC";
} else {
	If ($_GET['act']=='sponsored'){
		// query for sponsored
		$query = "SELECT * FROM servers WHERE sponsored='Yes' ORDER BY id DESC";
	} else {
		If (isSet($_GET['country'])){
			// query for country
			$query = "SELECT * FROM servers WHERE country='$_GET[country]' ORDER BY votes DESC";
		} else {
			// query for all
			$query = "SELECT * FROM servers ORDER BY $sortby DESC";
		}
	}
}
// at this point, $query contains the basic query
$count_query = str_replace('*','COUNT(*)',$query); // produce the query to get the count of the matching rows

// code to execute the $count_query and get the count into $numrows would go here...

// code to calculate the $offset and $rowsperpage would go here...

// add the LIMIT clause onto the end of the $query variable to produce the actual query to retrieve the data in the following code -
$query = "$query LIMIT $offset, $rowsperpage";
$result = mysql_query($query) or die(mysql_error());
$nr = mysql_num_rows($result);

Jnerocorp · September 14, 2011

you sir are a genius I thank you so very much this was driving me absolutely insane

Sign In

PHP Pagination help...

Recommended Posts

Jnerocorp

Link to comment

Share on other sites

PFMaBiSmAd

Link to comment

Share on other sites

Jnerocorp

Link to comment

Share on other sites

PFMaBiSmAd

Link to comment

Share on other sites

Jnerocorp

Link to comment

Share on other sites

PFMaBiSmAd

Link to comment

Share on other sites

Jnerocorp

Link to comment

Share on other sites

PFMaBiSmAd

Link to comment

Share on other sites

Jnerocorp

Link to comment

Share on other sites

Join the conversation

Browse

Activity

Important Information