php?ID=0

[Supremezzy]

Hi i am some problems with my website.

 

Whenever I create a gallery within my websites admin panel, the php?ID=0, and whenever I create multiple galleries, it also links to the same URL.

I don't know what the problem is and hopefully someone can help.

Here is the gallery PHP code.

 

     

<?php
          $GalleryID=$_GET['ID'];
//      $sql_rsGallery = "SELECT * FROM tGallery WHERE GalleryID=1";
      $sql_rsGallery = "SELECT * FROM tGallery WHERE GalleryID=$GalleryID";
      $rsGallery = mysql_query($sql_rsGallery, $conDB) or die(mysql_error());
      $totalRows_rsGallery = mysql_num_rows($rsGallery);
      if ($totalRows_rsGallery > 0) {
                $row_rsGallery = mysql_fetch_assoc($rsGallery);
            echo $row_rsGallery['GalleryTitle3'];
                echo "<br /><br /><br />";
                $GalleryFolder = $row_rsGallery['GalleryFolder'];
                foreach (new DirectoryIterator('gallery/'.$GalleryFolder.'/small/') as $file) {
                  // if the file is not this file, and does not start with a '.' or '..',
                  // then store it for later display
                  $FirstChar = $file->getFilename();
                  $FirstChar = $FirstChar[0];
                  if ( ($FirstChar != ".") && (pathinfo($file, PATHINFO_EXTENSION) == "jpg") && (!$file->isDot()) && ($file->getFilename() != basename($_SERVER['PHP_SELF'])) ) {
                        // if the element is a directory -> dont use it
                        $arrFiles[] = ($file->isDir()) ? $file="" : $file->getFilename();
                  }
                }
                //print_r($arrFiles);
                asort($arrFiles);
                foreach ($arrFiles as $PictureName) {
                  if ($GalleryFolder == "dancing") { // Gallery dancing are Portrait, so width and height are different
                        ?>
                        <a href="gallery/<?php echo $row_rsGallery['GalleryFolder']; ?>/big/<?php echo $PictureName; ?>" rel="lightbox[salsa1]" title=""><img src="gallery/<?php echo $row_rsGallery['GalleryFolder']; ?>/small/<?php echo $PictureName; ?>" title="Click to enlarge" alt="" width="100" height="150" /></a>
                        <?php
                  }
                  else {
                        ?>
                        <a href="gallery/<?php echo $row_rsGallery['GalleryFolder']; ?>/big/<?php echo $PictureName; ?>" rel="lightbox[salsa1]" title="<a href="gallery/<?php echo $row_rsGallery['GalleryFolder']; ?>/download/<?php echo $PictureName; ?>" target="_blank">Download this picture »</a>"><img src="gallery/<?php echo $row_rsGallery['GalleryFolder']; ?>/small/<?php echo $PictureName; ?>" title="Click to enlarge" alt="" width="133" height="100" /></a>
                        <?php
                  }
                }
          }
          mysql_free_result($rsGallery);
          ?>

[MasterACE14]

nothing looks out of place with the code you've shown, check the code for where the GET is coming from.

[Drummin]

Do yourself a favor and use some checks for your GET values before querying DB.  Adding a default $GalleryID will also prevent a fatal error when no GET value is present.

if (isset($_GET['ID'])){
 $GalleryID=mysql_real_escape_string($_GET['ID']);
}
else{
$GalleryID=1;
}