Session Cookies with URL Variables?

[Kristoff1875]

I've got a login script, all working fine, but i've recently added a remember me cookie:

 

$year = time() + 31536000;
	
if($_POST['remember']) {
setcookie('remember_me', $_POST['username'], $year);
}
elseif(!$_POST['remember']) {
	if(isset($_COOKIE['remember_me'])) {
		$past = time() - 100;
		setcookie(remember_me, gone, $past);
	}
}

 

All works fine on the normal login page, however, when clicking on the email link with url variables in it:

 

login.php?clientid=1&jobid=1

 

It can't seem to pull the cookie that recalls the username and ticks the box.

 

Anyone got any idea why this could be?

 

[mac_gyver]

your setcookie isn't setting the path or domain parameters, so if you are changing the path or subdomain in the url, then your cookie won't match and won't be sent by the browser.

[Kristoff1875]

Should it be something like:

 

$year = time() + 31536000;
	
if($_POST['remember']) {
setcookie('remember_me', $_POST['username'], $year, '/', '.mydomain.co.uk');
}
elseif(!$_POST['remember']) {
	if(isset($_COOKIE['remember_me'])) {
		$past = time() - 100;
		setcookie(remember_me, gone, $past);
	}
}

[mac_gyver]

if that worked when you tried it, then yes.

 

you must use the same path and domain parameters when you use the setcookie to clear the cookie, or it will actaully be trying to clear a different cookie.

[Kristoff1875]

It didn't work, that's why I asked haha

[Kristoff1875]

I have however just figured something out...

 

login.php?clientid=1&jobid=

 

sees the cookie fine...

 

login.php?clientid=1&jobid=1

 

Doesn't see the cookie.

[Kristoff1875]

I feel like such an idiot now. Lets just say, one of the if statements, was causing this error.... nothing to see here!!!!