cjburkey01 Posted February 21, 2014 Share Posted February 21, 2014 Hello people! I have this bit of code: <?php function drawArray(DirectoryIterator $directory) { $result=array(); foreach($directory as $object) { if($object->isDir()&&!$object->isDot()) { $result[$object->getFilename()]=drawArray(new DirectoryIterator($object->getPathname())); } else if($object->isFile()) { $result[]=$object->getFilename(); } } return $result; } $array=drawArray(new DirectoryIterator('mods')); $info = implode("\n",$array); file_put_contents("mods.txt", $info); $array2 = drawArray(new DirectoryIterator('config')); $info2 = implode("\n",$array2); file_put_contents("config.txt", $info2); function remove($Filename, $key) { $fc=file($Filename); $f=fopen($Filename,"w"); foreach($fc as $line) { if (!strstr($line,$key)) fputs($f,$line); } fclose($f); } remove("mods.txt", "Array"); remove("mods.txt", ".DS_Store"); remove("config.txt", "Array"); remove("config.txt", ".DS_Store"); ?> It works, but I have directories in the folder it's searching, how would I make it print the directories to the file in this formate: directory/fileInIt.cfg? Quote Link to comment Share on other sites More sharing options...
WebStyles Posted February 21, 2014 Share Posted February 21, 2014 (edited) I know this is not the answer to your question, but it seems you have other issues to deal with first. You're reading through the directories, adding everything into an array, converting that array to a string, creating a file(s), writing the contents of that string to the file(s), then opening that file again, reading each line and removing things you didn't want and writing back the ones you do want... Do you see a problem here? Remember: Simpler is better. Edited February 21, 2014 by WebStyles Quote Link to comment Share on other sites More sharing options...
cjburkey01 Posted February 21, 2014 Author Share Posted February 21, 2014 I know this is not the answer to your question, but it seems you have other issues to deal with first. You're reading through the directories, adding everything into an array, converting that array to a string, creating a file(s), writing the contents of that string to the file(s), then opening that file again, reading each line and removing things you didn't want and writing back the ones you do want... Do you see a problem here? Remember: Simpler is better. Yes, I now see that problem, so would be more efficient to create the file, convert, insert, delete, then close, instead of reopening and everything? Quote Link to comment Share on other sites More sharing options...
WebStyles Posted February 21, 2014 Share Posted February 21, 2014 would be more efficient to remove unwanted stuff from the array BEFORE even writing to the file. Quote Link to comment Share on other sites More sharing options...
WebStyles Posted February 21, 2014 Share Posted February 21, 2014 can I ask exactly why you're doing that? (you're obviously trying to map the directories) but is is a one-time thing you need to do, or is it a script that will run for every user or something like that? (I'm asking because if it's a one-time thing you can simply type: find mods > mods.txt at the command prompt (I'm assuming it's a linux box) and it will map out all the files for you.) Quote Link to comment Share on other sites More sharing options...
cjburkey01 Posted February 21, 2014 Author Share Posted February 21, 2014 can I ask exactly why you're doing that? (you're obviously trying to map the directories) but is is a one-time thing you need to do, or is it a script that will run for every user or something like that? (I'm asking because if it's a one-time thing you can simply type: find mods > mods.txt at the command prompt (I'm assuming it's a linux box) and it will map out all the files for you.) It's a one time thing, well, unless I update the file list. I'm using a java program that reads the mods.txt, gets the url, and dwnloads each file(More proof-of-concept than functional )so, I wanted to run that php everytime I add a new file, (And I didn't want to list the files on my own) Quote Link to comment Share on other sites More sharing options...
WebStyles Posted February 21, 2014 Share Posted February 21, 2014 (edited) try this (it reads through the directories, and writes everything to the text files without having to create an array.) <?php function drawArray(DirectoryIterator $directory, $file ){ $path = ''; foreach ( $directory as $object ){ if ($object->isDir() && !$object->isDot()){ $path .= $object->getFilename() .'/'; $result[$object->getFilename()] = drawArray( new DirectoryIterator( $object->getPathname() ), $file ); }else if($object->isFile() && $object != '.DS_Store'){ $line = $path . $object->getFilename()."\n"; file_put_contents($file,$line,FILE_APPEND); } } } drawArray( new DirectoryIterator( 'mods' ), 'mods.txt' ); drawArray( new DirectoryIterator( 'config' ), 'config.txt' ); ?> (it appends each line to the files as it reads through the directory, so you should delete the previous files first (or empty them, I'm sure you can figure out how to add that) ... Just realized there's still a little bug in there, but you get the idea. Hope it helps Edited February 22, 2014 by WebStyles Quote Link to comment Share on other sites More sharing options...
cjburkey01 Posted February 22, 2014 Author Share Posted February 22, 2014 try this (it reads through the directories, and writes everything to the text files without having to create an array.) <?php function drawArray(DirectoryIterator $directory, $file ){ $path = ''; foreach ( $directory as $object ){ if ($object->isDir() && !$object->isDot()){ $path .= $object->getFilename() .'/'; $result[$object->getFilename()] = drawArray( new DirectoryIterator( $object->getPathname() ), $file ); }else if($object->isFile() && $object != '.DS_Store'){ $line = $path . $object->getFilename()."\n"; file_put_contents($file,$line,FILE_APPEND); } } } drawArray( new DirectoryIterator( 'mods' ), 'mods.txt' ); drawArray( new DirectoryIterator( 'config' ), 'config.txt' ); ?> (it appends each line to the files as it reads through the directory, so you should delete the previous files first (or empty them, I'm sure you can figure out how to add that) ... Just realized there's still a little bug in there, but you get the idea. Hope it helps So, I wouldn't need the delete function. Right? Quote Link to comment Share on other sites More sharing options...
WebStyles Posted February 22, 2014 Share Posted February 22, 2014 What would you want to delete? Quote Link to comment Share on other sites More sharing options...
cjburkey01 Posted February 22, 2014 Author Share Posted February 22, 2014 What would you want to delete? Exactly Quote Link to comment Share on other sites More sharing options...
cjburkey01 Posted March 22, 2014 Author Share Posted March 22, 2014 (edited) Um, when I use this file, it works for everything, but if the file is nested once in a directory, it does not put that directory in the file list. So, you could have a file like this: config/cofh/core.cfg But it only shows as this: core.cfg But if it is further, it work: /config/cofh/core/file/thing.cfg would list like core/file/thing/core.cfg I use this code: <?php function drawArray(DirectoryIterator $directory, $file ){ $path = ''; foreach ( $directory as $object ){ if ($object->isDir() && !$object->isDot()){ $path .= $object->getFilename() .'/'; $result[$object->getFilename()] = drawArray( new DirectoryIterator( $object->getPathname() ), $file ); }else if($object->isFile() && $object != '.DS_Store'){ $line = $path . $object->getFilename()."\n"; file_put_contents($file,$line,FILE_APPEND); } } } drawArray( new DirectoryIterator( 'mods' ), 'mods.txt' ); drawArray( new DirectoryIterator( 'config' ), 'config.txt' ); ?> Edited March 22, 2014 by cjburkey01 Quote Link to comment Share on other sites More sharing options...
cjburkey01 Posted March 22, 2014 Author Share Posted March 22, 2014 Are we allowed to bump? I forget Quote Link to comment Share on other sites More sharing options...
cjburkey01 Posted March 22, 2014 Author Share Posted March 22, 2014 Are we allowed to bump? I forget Seriously, are we? Quote Link to comment Share on other sites More sharing options...
cjburkey01 Posted March 22, 2014 Author Share Posted March 22, 2014 I'll bump then. BUMP BUMP BUMP BUMP BUMP BUMP BUMP Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.