news management

[alen]

I started reading this tutorial about how to make a simple news management script with php and mysql.

I'm new to all this php related stuff.. so could one of you guys help me with some errors?

I have this file called edit_process.php where I'm supposed to modifiy the news that I added. So I open the page and there I find beautiful errors which I tried to fix, but failed :\

Here's the error;

[b]Notice: Undefined index: id in C:\Program Files\Server\public_html\nyheter\edit_process.php on line 7

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in C:\Program Files\Server\public_html\nyheter\edit_process.php on line 9[/b]

Here's the code;

[b]<?php

include "config.php";

$db = mysql_connect($db_host,$db_user,$db_pass);
mysql_select_db ($db_name) or die ("Cannot connect to database");
$query = "SELECT title, news FROM news WHERE id = $_GET[id]";
$result = mysql_query($query);
while($r=mysql_fetch_array($result))
{ 
$title=$r["title"];
$news=$r["news"];
    echo "<form name='edit_process.php' method='post' action='edit_save.php?id=$_GET[id]'>
  <p>Title :
    <input type='text' name='title' value='$title'>
  </p>
  <p>News :</p>
  <p>
    <textarea name='news' cols='40' rows='6'>$news</textarea>
  </p>
  <p>
    <input type='submit' name='Submit' value='Save'>
  </p>
</form>";
}
mysql_close($db);

?> [/b]

Sincerely,
anigma

[bqallover]

Are you sure $_GET[id] contains a value?

Maybe it's not being passed into the script, e.g. edit_process.php?id=22, from the URL?

Or is it being called with POST data from a form or script?  In that case you'd need $_POST[id] instead.

[sw0o0sh]

[code]
<?php
include('config.php');
$db=mysql_connect($db_host,$db_user,$db_pass);
mysql_select_db ($db_name) or die ("Cannot connect to database");
if($_GET){
echo "<!-- Your query was selected with a get method -->";
$query=mysql_query("SELECT * FROM news WHERE id=$_GET[id]");
}else if($_POST){
echo "<!-- Your query was selected with a post method -->";
$query=mysql_query("SELECT * FROM news WHERE id=$_POST[id]");
}

while($r=mysql_fetch_array($result))
{   
echo "<form name='edit_process.php' method='post' action='edit_save.php?id=".$_GET[id]."'>
  <p>Title :
    <input type='text' name='title' value='".$r[title]."' />
  </p>
  <p>News :</p>
  <p>
    <textarea name='news' cols='40' rows='6'>".$r[news]."</textarea>
  </p>
  <p>
    <input type='submit' name='Submit' value='Save' />
  </p>
</form>";
}
?>
[/code]

Try that. Notice I made the query a tad more dynamic. You can undo that if you want, but use it now to find out whether you are using a post or get method to find the query.

[alen]

I got this,

[b]Notice: Undefined variable: result in C:\Program Files\Server\public_html\nyheter\edit_process.php on line 13

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in C:\Program Files\Server\public_html\nyheter\edit_process.php on line 13[/b]

Take a look at the whole script, http://www.oxyscripts.com/item-408.html.

[sws]

Set your error handling to this and you won't have those probs anymore.

Place this snippet of code near the top of your page inside the opening <? tag

[code]error_reporting (E_ALL & ~ E_NOTICE);
# Don't show notices.[/code]

[alen]

ah.

now I only have this error;

[b]Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in C:\Program Files\Server\public_html\nyheter\edit_process2.php on line 10[/b]

[sws]

Looks like a bunch of quotes are missing

Try this :

[code]<?php
include('config.php');
$db=mysql_connect($db_host,$db_user,$db_pass);
mysql_select_db ($db_name) or die ("Cannot connect to database");
if($_GET){
echo "<!-- Your query was selected with a get method -->";
$query=mysql_query("SELECT * FROM news WHERE id=$_GET['id']");
}else if($_POST){
echo "<!-- Your query was selected with a post method -->";
$query=mysql_query("SELECT * FROM news WHERE id=$_POST['id']");
}

while($r=mysql_fetch_array($result))
{ 
echo "<form name='edit_process.php' method='post' action='edit_save.php?id=".$_GET['id']."'>
  <p>Title :
    <input type='text' name='title' value='".$r['title']."' />
  </p>
  <p>News :</p>
  <p>
    <textarea name='news' cols='40' rows='6'>".$r['news']."</textarea>
  </p>
  <p>
    <input type='submit' name='Submit' value='Save' />
  </p>
</form>";
}
?>
[/code]

[alen]

Well, now I get this;

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in C:\Program Files\Server\public_html\nyheter\edit_process.php on line 7

[chriscloyd]

try this

[CODE]
<?php
include('config.php');
$db=mysql_connect($db_host,$db_user,$db_pass);
mysql_select_db ($db_name) or die ("Cannot connect to database");
if(isset($_GET['id'])) {
$id = $_GET['id'];
echo "<!-- Your query was selected with a get method -->";
$query=mysql_query("SELECT * FROM news WHERE id='$id'") or die(mysql_error());
}
if(isset($_POST['id'])){
$id = $_POST['id'];
echo "<!-- Your query was selected with a post method -->";
$query=mysql_query("SELECT * FROM news WHERE id='$id'") or die(mysql_error());
}

while($r=mysql_fetch_array($query)) {
$nid = $r['id']
$title = $r['title'];
$news = $r['news']
echo "<form name='edit_process.php' method='post' action='edit_save.php?id=".$nid."'>
  <p>Title :
    <input type='text' name='title' value='".$title."' />
  </p>
  <p>News :</p>
  <p>
    <textarea name='news' cols='40' rows='6'>".$news."</textarea>
  </p>
  <p>
    <input type='submit' name='Submit' value='Save' />
  </p>
</form>";
}
?>
[/CODE]

[alen]

Now I get this,

Parse error: parse error, unexpected T_VARIABLE in C:\Program Files\Server\public_html\nyheter\edit_process.php on line 18

[chriscloyd]

ya i made a mistake heres the new code tlel me if it works

[code]<?php
include('config.php');
$db=mysql_connect($db_host,$db_user,$db_pass);
mysql_select_db ($db_name) or die ("Cannot connect to database");
if(isset($_GET['id'])) {
$id = $_GET['id'];
echo "<!-- Your query was selected with a get method -->";
$query=mysql_query("SELECT * FROM news WHERE id='$id'") or die(mysql_error());
}
if(isset($_POST['id'])){
$id = $_POST['id'];
echo "<!-- Your query was selected with a post method -->";
$query=mysql_query("SELECT * FROM news WHERE id='$id'") or die(mysql_error());
}

while($r=mysql_fetch_array($query)) {
$nid = $r['id']
$title = $r['title'];
$news = $r['news'];
echo "<form name='edit_process.php' method='post' action='edit_save.php?id=".$nid."'>
  <p>Title :
    <input type='text' name='title' value='".$title."' />
  </p>
  <p>News :</p>
  <p>
    <textarea name='news' cols='40' rows='6'>".$news."</textarea>
  </p>
  <p>
    <input type='submit' name='Submit' value='Save' />
  </p>
</form>";
}
?>[/code]

[alen]

I get the exact same error as before.

[bljepp69]

You're missing a ';' on line 17...

$nid = $r['id'];

[alen]

Now I get;

Notice: Undefined variable: query in C:\Program Files\Server\public_html\nyheter\edit_process.php on line 16

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in C:\Program Files\Server\public_html\nyheter\edit_process.php on line 16

[alen]

I'm trying to figure it out, but I just can't read through the lines.

[bljepp69]

That likely means that your query ($query=mysql_query("SELECT * FROM news WHERE id='$id'") returned nothing.  No rows matched your selection criteria, so the resource ($query) is empty.  Then the call to mysql_fetch_array is invalid.

Try this:
[code]
<?php
  include('config.php');
  $db=mysql_connect($db_host,$db_user,$db_pass);
  mysql_select_db ($db_name) or die ("Cannot connect to database");
  if(isset($_GET['id'])) {
    $id = $_GET['id'];
    echo "<!-- Your query was selected with a get method -->";
    $query=mysql_query("SELECT * FROM news WHERE id='$id'") or die(mysql_error());
  }
  if(isset($_POST['id'])){
    $id = $_POST['id'];
    echo "<!-- Your query was selected with a post method -->";
    $query=mysql_query("SELECT * FROM news WHERE id='$id'") or die(mysql_error());
  }


  if (mysql_num_rows($query)>0) {
    while ($r=mysql_fetch_array($query)) {
      $nid = $r['id']
      $title = $r['title'];
      $news = $r['news'];
      echo "<form name='edit_process' method='post' action='edit_save.php?id=".$nid."'>
        <p>Title :
          <input type='text' name='title' value='".$title."' />
        </p>
        <p>News :</p>
        <p>
          <textarea name='news' cols='40' rows='6'>".$news."</textarea>
        </p>
        <p>
          <input type='submit' name='Submit' value='Save' />
        </p>
      </form>";
    }
  }
  else {
    echo "<p>No news items.</p>";
  }
?>[/code]

I also think you could get rid of the "if (isset($_POST['id']..." statement.  You don't have any variable called 'id' in your form and you are only using a GET method in the query string.  If you wanted to make the processing code such that it didn't matter, then change the GET to REQUEST and then it will grab both POST & GET variables.

[chriscloyd]

[CODE]
<?php
include('config.php');
$db=mysql_connect($db_host,$db_user,$db_pass);
mysql_select_db ($db_name) or die ("Cannot connect to database");
if(isset($_GET['id'])) {
$id = $_GET['id'];
echo "<!-- Your query was selected with a get method -->";
$query=mysql_query("SELECT * FROM news WHERE id='$id'") or die(mysql_error());
}
if(isset($_POST['id'])){
$id = $_POST['id'];
echo "<!-- Your query was selected with a post method -->";
$query=mysql_query("SELECT * FROM news WHERE id='$id'") or die(mysql_error());
}

while($r=mysql_fetch_array($query)) {
$nid = $r['id'];
$title = $r['title'];
$news = $r['news'];
echo "<form name='edit_process.php' method='post' action='edit_save.php?id=".$nid."'>
  <p>Title :
    <input type='text' name='title' value='".$title."' />
  </p>
  <p>News :</p>
  <p>
    <textarea name='news' cols='40' rows='6'>".$news."</textarea>
  </p>
  <p>
    <input type='submit' name='Submit' value='Save' />
  </p>
</form>";
}
?>
[/CODE]

[alen]

I tried the code bljepp69 gave me, and it got me another error;

[b]Notice:[/b] Undefined variable: query in [b]C:\Program Files\Server\public_html\news\edit_process.php[/b] on line [b]10[/b]

[b]Warning:[/b] mysql_fetch_array(): supplied argument is not a valid MySQL result resource in [b]C:\Program Files\Server\public_html\news\edit_process.php[/b] on line [b]10[/b]

[bljepp69]

Now it's time to hunt down where the error is that's causing the query to not be valid.  Try this code.  I have added some echo statements to send output at various points in the code so we can see what's happening.

[code]
<?php
  include('config.php');
  $db=mysql_connect($db_host,$db_user,$db_pass);
  mysql_select_db ($db_name) or die ("Cannot connect to database");
  if(isset($_GET['id'])) {
    $id = $_GET['id'];
    echo "id = $id<br />";  //check the value of $id
    echo "<!-- Your query was selected with a get method -->";
    $query_text = "SELECT * FROM news WHERE id='$id'"; //verify that the query actually picked up the variable $id
    echo "query = $query_text<br />";
    $query=mysql_query($query_text) or die(mysql_error());

  }
  if (mysql_num_rows($query)>0) {
  echo mysql_num_rows($query)." rows returned<br />"; //see how many rows are actually returned
    while ($r=mysql_fetch_array($query)) {
      $nid = $r['id']
      $title = $r['title'];
      $news = $r['news'];
      echo "<form name='edit_process' method='post' action='edit_save.php?id=".$nid."'>
        <p>Title :
          <input type='text' name='title' value='".$title."' />
        </p>
        <p>News :</p>
        <p>
          <textarea name='news' cols='40' rows='6'>".$news."</textarea>
        </p>
        <p>
          <input type='submit' name='Submit' value='Save' />
        </p>
      </form>";
    }
  }
  else {
    echo "<p>No news items.</p>";
  }
?>[/code]

Also, you can get rid of the "Notice" by setting this at the top of your code...

error_reporting(E_ALL ^ E_NOTICE);

[alen]

One last error;

Parse error: parse error, unexpected T_VARIABLE in C:\Program Files\Server\public_html\news\edit_process.php on line 19

[chriscloyd]

[CODE]
<?php
  include('config.php');
  $db=mysql_connect($db_host,$db_user,$db_pass);
  mysql_select_db ($db_name) or die ("Cannot connect to database");
  if(isset($_GET['id'])) {
    $id = $_GET['id'];
    echo "id = $id<br />";  //check the value of $id
    echo "<!-- Your query was selected with a get method -->";
    $query_text = "SELECT * FROM news WHERE id='$id'"; //verify that the query actually picked up the variable $id
    echo "query = $query_text<br />";
    $query=mysql_query($query_text) or die(mysql_error());

  }
  if (mysql_num_rows($query)>0) {
  echo mysql_num_rows($query)." rows returned<br />"; //see how many rows are actually returned
    while ($r=mysql_fetch_array($query)) {
      $nid = $r['id'];
      $title = $r['title'];
      $news = $r['news'];
      echo "<form name='edit_process' method='post' action='edit_save.php?id=".$nid."'>
        <p>Title :
          <input type='text' name='title' value='".$title."' />
        </p>
        <p>News :</p>
        <p>
          <textarea name='news' cols='40' rows='6'>".$news."</textarea>
        </p>
        <p>
          <input type='submit' name='Submit' value='Save' />
        </p>
      </form>";
    }
  }
  else {
    echo "<p>No news items.</p>";
  }
?>
[/CODE]

[alen]

I'm feeling we're making progress;

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in C:\Program Files\Server\public_html\news\edit_process.php on line 15

No news items.

[chriscloyd]

[CODE]
<?php
include('config.php');
$db=mysql_connect($db_host,$db_user,$db_pass);
mysql_select_db ($db_name) or die ("Cannot connect to database");
if(isset($_GET['id'])) {
$id = $_GET['id'];
echo "<!-- Your query was selected with a get method -->";
$query=mysql_query("SELECT * FROM news WHERE id='$id'") or die(mysql_error());
}
if(isset($_POST['id'])){
$id = $_POST['id'];
echo "<!-- Your query was selected with a post method -->";
$query=mysql_query("SELECT * FROM news WHERE id='$id'") or die(mysql_error());
}

while($r=mysql_fetch_array($query)) {
$nid = $r['id'];
$title = $r['title'];
$news = $r['news'];
echo "<form name='edit_process.php' method='post' action='edit_save.php?id=".$nid."'>
  <p>Title :
    <input type='text' name='title' value='".$title."' />
  </p>
  <p>News :</p>
  <p>
    <textarea name='news' cols='40' rows='6'>".$news."</textarea>
  </p>
  <p>
    <input type='submit' name='Submit' value='Save' />
  </p>
</form>";
}
?>[/CODE]

[alen]

the code gave me these errors;

Notice: Undefined variable: query in C:\Program Files\Server\public_html\news\edit_process.php on line 16

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in C:\Program Files\Server\public_html\news\edit_process.php on line 16

[alen]

Nevermind the Notice error, cleared that one.