Jump to content

Avoid duplicated mocks


SomeoneElse

Recommended Posts

Hi,

 

I'm using Mockery and I found out, that I very often need same piece of code, when I mock something.

 

For example, on many places I have this code:

<?php

private function mockedState() {
    return Mockery::mock('State')
    ->shouldReceive('isOnline')->once()->andReturn(true)->mock();
}

But, it is not only about this State class, but also some others classes are very often repeatable.

 

So, should I create some class like this?

class MockedState {
	public function onceCalledIsOnlineMethod() {
		return Mockery::mock('State')
		->shouldReceive('isOnline')->once()->andReturn(true)->mock();
	}

	public function neverCalledIsOnlineMethod() {
		return Mockery::mock('State')
		->shouldReceive('isOnline')->never()->mock();
	}
}

Should I take care of code duplication even though it is mock? I know, that even tests need to refactor so, that's the reason why I ask.

 

Thank you.

Link to comment
https://forums.phpfreaks.com/topic/297734-avoid-duplicated-mocks/
Share on other sites

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.