SOLVED Building my Viewthread.php page on a forum

[Fishcakes]

SOLVED: I'm having trouble with an SQL  query via php in building my Viewthread.php file

So on the main page you have a list of the Threads and the link I created is like the below

<h2><a href='viewthread.php?id='{$row['id']}'>  {$row['Title']} </a></h2> Post {$row['id']}<br> 

If I set the query to an ID that exists the page loads fine

$query = mysqli_query($conn, "SELECT * FROM Threads where id='156'")

however if I set the id to the GET command the page doesn't load (which should've got the id)

$query = mysqli_query($conn, "SELECT * FROM Threads where id=$_GET['id']")

I tried casting this to a variable first too

$Number = "$_GET['id']"
$query = mysqli_query($conn, "SELECT * FROM Threads where id='$Number'")

 

Edited April 2, 2021 by Fishcakes

[Fishcakes]

Figured it out!

Just had to use Intval to cast it

$number = intval($_GET['id']) ; 

 

[Barand]

It sounds like $_GET['id'] does not have a value.

If you want a list of threads, why are you selecting them individually?

You should be using prepared statements and not placing user supplied data directly into the query

Post your code.

[Barand]

21 minutes ago, Fishcakes said:

Just had to use Intval to cast it

That is getting the query to run by changing a blank value to "0" thus preventing a syntax error. You should be checking that $_GET['id'] has a value before calling the query