PHP Notice: Undefined offset: 1 in C:\xampp5\htdocs\appname\processform.php on line 107 to total number of columns to be inserted

admien · April 1

I have nineteen fields. 4 fields are not changeable and it is from header form. 15 fields are changeable from 5 detail forms. when I try to insert multiple rows of some field data that might be came from all rows in the table #1, table #2, table #3, table #4 and table #5. One of example is attached in this post.

sample code for table #1. For table #2 to table #5, it is same way but different id or name.



<!DOCTYPE HTML>
<html lang="en-US">
<?php require_once("head.php");?>
<body>
	<div class="container">
		<?php require_once("header.php");?>
		<div class="row">
			<div class="col-md-12">
				<div style="margin-bottom: 20px">
					<div class="page-header">
						<h4> <p style="color:black;">form data</p></h4>
						
						
						<br>

		</div>
					<div style="margin-bottom: 20px"></div>	
					<form role="form" class="form-horizontal" method="post" action="addform.php" style="margin-bottom: 10px">	
				<!--	<form name="formalbum" action="pagination.php" method="post"> -->					
					<div>
							<div class="form-group">
							<label class="control-label col-sm-2">Country</label>
							<div class="col-sm-4">
								  <input type="text" id="country2" name="country2" value="<?php 
								  
     echo $country2;

								  ?>"  readonly = "readonly" required>
							
							</div>
						</div>
<!-- table 4 angka mulai -->
<label style="color:maroon;">Table #1 data</label>
<br>
<div class="table-responsive">
<table class="table table-striped" cellspacing="0" border="1" cellpadding="3">
  <tbody id="calculation">
    <tr class="row">
	<tr>
							<td> country </td>
							<td>test2 (4 digits)</td>
							<td>test21 (4 digits)</td>
							<td id="myelement">price</td>
							<td>test22 (4 digits)</td>
							<td>Del</td>
						
						</tr>
						
<td><input class="underline-input" style="width: 10rem" type="text" id="country1" name="country1[0]" value="<?php 
								  echo $country; ?>"  readonly = "readonly">
															   </td>
<td><input class="underline-input" style="width: 10rem" type="text" id="test2" name="test2[0]" maxlength="4"  pattern="\d{4}"/></td>
<td><input class="underline-input multi" style="width: 10rem" type="number" id="test21" name="test21[0]" /></td>
<td id="myelement"><input class="underline-input multi" style="width: 10rem" type="number" id="price" name="price[0]" value="<?php echo $pricebsa; ?>"/></td>
<td><input class="underline-input amount"  style="width: 10rem" type="number" id="test22" name="test22[0]" readonly="readonly"/></td>
<td><button type="button" class="del">Del</button></td>

					
	</tr>
    <tr id="last">
        <td colspan="4" align="left"><button type="button" id="addRow">Add</button></td>
    </tr>
	</tbody>	
	<script>
	$(document).ready(function(){
$('#calculation').on("keyup",".multi",function(){
  var parent = $(this).closest('tr');
  var quant= $(parent).find('#test21').val();
  var price= $(parent).find('#price').val();

  $(parent).find('#test22').val(quant* price);
  GrandTotal();
  });

   function GrandTotal(){
     var sum='';

     $('.amount').each(function(){
       sum+=Number($(this).val());
     });

     $('#total').val(sum);
   }
    
});
var template = '';
		
	$(function(){
		
		$("#addRow").click(function(){
		
			row = '<tr>'+
		
			'<td><input class="underline-input" type="text" style="width: 10rem" id="country1" name="country1['+template+']" maxlength="4"  value="<?php 
								  echo $country; ?>"  readonly = "readonly"/></td>'+

			'<td><input class="underline-input" type="text" style="width: 10rem" id="test2" name="test2['+template+']" maxlength="4"  "/></td>'+
		
			'<td><input class="underline-input multi" type="number" style="width: 10rem" id="test21" name="test21['+template+']"/></td>'+

			'<td id="myelement"><input class="underline-input multi" type="number" style="width: 10rem" id="price" name="price[0]" name="price['+template+']" value="<?php echo $pricebsa; ?>"/></td>'+
		
			'<td><input class="underline-input amount" type="number" style="width: 10rem" id="test22"  name="test22['+template+']" readonly="readonly"/></td>'+
		
			'<td><button type="button" class="del">Del</button></td>'+
		
			'</tr>';
		
			$(row).insertBefore("#last");
		
			i++;
		
			});
		
		});
		
		
		$(".del").live('click', function(){
		
			$(this).parent().parent().remove();
		
			});

   $("#calculation").append(template);

 
</script>
</table>
</div>

sample php code:

<?php
	include_once("db.php");
  
    if(!$_SESSION['id']) { 
        header("location: addform.php");
    
    }
 
 if(!$_POST){
        
        die('No data!');
        
    }

  //current time

    $timestamp = time();
    $today = date('Y-m-d h:m:s');
    $now = new DateTime('now');
    $district = '';
    $day = $now->format('D');
    
    $date = new DateTime("now", new DateTimeZone('Asia/Jakarta') );
    
    
    // Set timezone ke SGP
    date_default_timezone_set('Asia/Singapore');
    
    // Current datetime
    $current_time = strtotime(Date('H:i:s'));

    // country
    $country1 = '';

    // Rules untuk value Country
if ($current_time >= strtotime('10:00:00') && $current_time < strtotime('15:45:00')) {
    $country1 = 'JPN';
} elseif ($current_time >= strtotime('16:00:00') && $current_time < strtotime('18:45:00')) {
    $country1 = 'SGP';
} elseif ($current_time >= strtotime('19:00:00') && $current_time < strtotime('21:45:00')) {
    $country1 = 'AUS';
} else {
    $country1 = 'PNG';
}

    //db connection database
        
    $db = new mysqli("127.1.0","admin","admin_131");
    if($db->connect_errno > 0){
          die('Unable to connect to database [' . $db->connect_error . ']');  } 
      
          
              mysqli_select_db($db,"appnamedb");
    // header

    $resultExec1 = mysqli_query($db, "insert into header " . 
        "(user_id,
        buyer, 
		country,
         trxid,
         total
        )  " .
			"VALUES ('" . $_SESSION['id'] . "', " .
            "'" . $_POST['name'] . "',  " .
               "'" . $_POST['country2'] . "',  " .
                     "'" . $_POST['trxid'] . "',  " .
		"'" . $_POST['total1'] . "')");
       

    $query1 = mysqli_query($db, "SELECT max(Alt_Id) AS id_header FROM header limit 1");
    $data  = mysqli_fetch_array($query1);       
    $id_header = $data['id_header'];

foreach($_POST['country1'] as $key => $ctry){
    $country1 = $ctry;

    $resultExec2 = mysqli_query($db,
    "insert into detail " . 
        "(
        user_id,
         country,
        id_header, 
       test2,
		test21,
        test22,
        test3,
        test31,
        test33,
         test3,
        test31,
        test32,
        test4,
        test41,
         test42,
      test5,
        test51,
         test52,
 test6,
        test61,
         test62
        )  " .
			"VALUES (
           '" . $_SESSION['id'] . "', " .   
            "'" . $ctry . "',  " .       
            "'" . $id_header . "', " .
            "'" . $_POST['test2'][$key] . "',  " .   
            "'" . $_POST['test21'][$key] . "',  " .
            "'" . $_POST['test22'][$key] . "',  " .   
            "'" . $_POST['test3'][$key] . "',  " .
            "'" . $_POST['test31'][$key] . "',  " .   
            "'" . $_POST['test33'][$key] . "',  " .
            "'" . $_POST['test4'][$key] . "',  " .   
            "'" . $_POST['test41'][$key] . "',  " .
            "'" . $_POST['test42'][$key] . "',  " .   
            "'" . $_POST['test5'][$key] . "',  " .
            "'" . $_POST['test51'][$key] . "',  " .   
            "'" . $_POST['test52'][$key] . "',  " .
            "'" . $_POST['test6'][$key] . "',  " .   
            "'" . $_POST['test61'][$key] . "',  " .
		"'" . $_POST['test62'][$key] . "')");
	
}
 
echo 'Data are saved';

header("location:addform.php");

have to insert all fields data by foreach loop but when I insert data through foreach loop, some blank entries also inserts in database and also I am getting this PHP error:

PHP Notice: Undefined offset: 1 in C:\xampp5\htdocs\appname\processform.php on line 107 to xxxx

Can anybody help me ?

mac_gyver · April 1

your dynamic addRow javascript only adds a row to the current html table, but the form processing code assumes that all the array form fields have the same number of elements.

since your example, using name-number elements, provides no context upon which to help you, you need to decide if you should change the form to dynamically add a row to every html table at the same time or if your form processing code should handle the data from each html table separately, possibly even storing related data in separate database tables.

if you care to provide some real world context to this data, we would be better able to help.

mac_gyver · April 1

here's a separate list of points for the posted code -

use 'require' for things your code must have.
include_once, require_once, require are not functions. the () around the path/filename don't do anything and should be removed.
every redirect needs and exit/die statement to stop php code execution. the current login check code still allows the rest of the code on the page to run.
your form processing code and form need to be on the same page. this simplifies all the code, provides a better User eXperience (UX), and allows you to repopulate the form fields with any existing data so that the user doesn't need to keep reentering values over and over upon an error. this will also let you easily edit existing data when you get to that point.
if db.php creates a database connection, why are you also creating a database connection in-line in the code?
modern php (8+) uses exceptions for database statement errors by default. with exceptions, there's no need for discrete logic to test if a statement worked or failed and any existing discrete logic should be removed.
you should be using prepared queries to prevent any sql special characters from being able to break the sql query syntax, which is how sql injection is accomplished. this will also greatly simplify the sql query syntax. if it seems that the mysqli extension is overly complicated, especially when dealing with prepared queries, it is. this would be a good time to switch to the much simpler and better designed PDO extension.
do not query to get the current max() value for a column and use it. this is not concurrent safe. you need to the 'last insert id' function/method/property to get the autoincrement id from the first insert query.
do not use any calculated total submitted from the browser. the submitted data can be altered and cannot be trusted. perform any such calculation on the server using data that is on the server.
the redirect you perform upon successful completion of the post method form processing code needs to be the exact same URL of the current page to cause a get request for that page. this will prevent the browser from trying to resubmit the form data should that page get browsed back to or reloaded.
you need to validate the resulting web pages at validator.w3.org
ids in the markup must be unique. you should NOT include the id attributes in the addRow markup. if you are not using the id attributes, simply leave them out of all the code.
the <label></label> tags are incomplete and not associated with the corresponding form field. the simplest way of correcting this is to put the closing </label> tag after the form field the label corresponds to.

admien · April 1

1 hour ago, Perplexity 🤖 said:

your dynamic addRow javascript only adds a row to the current html table, but the form processing code assumes that all the array form fields have the same number of elements.

since your example, using name-number elements, provides no context upon which to help you, you need to decide if you should change the form to dynamically add a row to every html table at the same time or if your form processing code should handle the data from each html table separately, possibly even storing related data in separate database tables.

if you care to provide some real world context to this data, we would be better able to help.

your reply is helpful so much. all main columns, i.e. test2, test3, test4, test5 and test6 have different max/min of lengths each other. That's why I split them into be 5 tables. test2 max/min length is 4 digits. test3 is 3 digits, test4 is 2 digits, test 5 is 1 digit and test6 is 2 digits but it has different price value with test4. So, I split both of them into different table.

I will consider store them in separate database tables if it is not possible using code. my previous code has splited the php code $resultExec2 from $resultExec2 until $resultExec6 but there are always 6 empty rows after successful inserting. I still don't know how it could be like that

admien · April 1

55 minutes ago, Perplexity 🤖 said:

here's a separate list of points for the posted code -

use 'require' for things your code must have.

include_once, require_once, require are not functions. the () around the path/filename don't do anything and should be removed.

every redirect needs and exit/die statement to stop php code execution. the current login check code still allows the rest of the code on the page to run.

your form processing code and form need to be on the same page. this simplifies all the code, provides a better User eXperience (UX), and allows you to repopulate the form fields with any existing data so that the user doesn't need to keep reentering values over and over upon an error. this will also let you easily edit existing data when you get to that point.

if db.php creates a database connection, why are you also creating a database connection in-line in the code?

modern php (8+) uses exceptions for database statement errors by default. with exceptions, there's no need for discrete logic to test if a statement worked or failed and any existing discrete logic should be removed.

you should be using prepared queries to prevent any sql special characters from being able to break the sql query syntax, which is how sql injection is accomplished. this will also greatly simplify the sql query syntax. if it seems that the mysqli extension is overly complicated, especially when dealing with prepared queries, it is. this would be a good time to switch to the much simpler and better designed PDO extension.

do not query to get the current max() value for a column and use it. this is not concurrent safe. you need to the 'last insert id' function/method/property to get the autoincrement id from the first insert query.

do not use any calculated total submitted from the browser. the submitted data can be altered and cannot be trusted. perform any such calculation on the server using data that is on the server.

the redirect you perform upon successful completion of the post method form processing code needs to be the exact same URL of the current page to cause a get request for that page. this will prevent the browser from trying to resubmit the form data should that page get browsed back to or reloaded.

you need to validate the resulting web pages at validator.w3.org

ids in the markup must be unique. you should NOT include the id attributes in the addRow markup. if you are not using the id attributes, simply leave them out of all the code.

the <label></label> tags are incomplete and not associated with the corresponding form field. the simplest way of correcting this is to put the closing </label> tag after the form field the label corresponds to.

Thanks for the 13 points from you. I have reviewed it and some of them is applied but i consider the previous answer that is using separate database tables to store the data from table #1 to table #5. Do you have any idea if I stil can use one table for all of data from all rows of the table #1 to table #5 ?

mac_gyver · April 1

you still have not provided any context (meaning) of this data. name-numbered, labels and variables, are meaningless to us.

if the mix of rows shown in the example picture is valid, i.e. you can have have any number of rows from each html table section, you should (probably) store the data from each row in each html table as a separate row in the detail database table, with an item_id column to indicate the meaning of each row of data.

i have a recommendation for the dynamically added markup. don't write out the markup in the javascript yourself, where you have to keep it updated to match any changes or corrections (you are going to need to eliminate the use of duplicate ids) you make to the markup being output on the page. instead, define/store the output being output on the page in a php variable, so that you can echo it on the page and echo it as the markup inside the javascript. if you use back-ticks (template literals) around what you echo in the javascript, you can use the exact same markup in both cases. see this link - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

admien · April 1

I totally changed the php of my app. it is resolved by creating 5 difference foreach loops and 5 difference keys that gonna be used in the foreach loops.

I did that because I have to have 5 separated tables to input different data but need to be inserted into one detail table and one header table. Thank you

admien · April 1

9 minutes ago, Perplexity 🤖 said:

you still have not provided any context (meaning) of this data. name-numbered, labels and variables, are meaningless to us.

if the mix of rows shown in the example picture is valid, i.e. you can have have any number of rows from each html table section, you should (probably) store the data from each row in each html table as a separate row in the detail database table, with an item_id column to indicate the meaning of each row of data.

i have a recommendation for the dynamically added markup. don't write out the markup in the javascript yourself, where you have to keep it updated to match any changes or corrections (you are going to need to eliminate the use of duplicate ids) you make to the markup being output on the page. instead, define/store the output being output on the page in a php variable, so that you can echo it on the page and echo it as the markup inside the javascript. if you use back-ticks (template literals) around what you echo in the javascript, you can use the exact same markup in both cases. see this link - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

sorry I did not read your reply.

I actually do not understand yet what context of this data is needed here. Instead, base on my understanding, you may be refer to the table columns, don't you. One of the table columns as follows:

<label style="color:blue;">table #4</label>
<br>
<div class="table-responsive">
<table class="table table-striped" cellspacing="0" border="1" cellpadding="3">
  <tbody id="calculation3">
    <tr class="row">
	<tr>
	<td> country </td>
							<td>country</td>
      						<td>test5</td>
							<td>test51</td>
							<td id="myelement">price</td>
							<td>test52</td>
							<td>Del</td>
						
						</tr>
						
						<td><input class="underline-input" style="width: 10rem" type="text" id="country1" name="country1[0]" value="<?php 
								  echo $country; ?>"  readonly = "readonly">
															   </td>
<td><input class="underline-input" style="width: 10rem" type="text" id="test5" name="test5[0]" maxlength="1"  pattern="\d{1}"/></td>
<td><input class="underline-input multi" style="width: 10rem" type="number" id="test51" name="test51[0]" /></td>
<td id="myelement"><input class="underline-input multi" style="width: 10rem" type="number" id="price" name="price[0]" value="<?php echo $priceclk; ?>"/></td>
<td><input class="underline-input amount"  style="width: 10rem" type="number" id="test52" name="test52[0]" readonly="readonly"/></td>
<td><button type="button" class="del3">Del</button></td>

						
				
	</tr>
    <tr id="last3">
        <td colspan="4" align="left"><button type="button" id="addRow3">Add</button></td>
    </tr>
	</tbody>	
	<script>
	$(document).ready(function(){
$('#calculation3').on("keyup",".multi",function(){
  var parent = $(this).closest('tr');
  var quant= $(parent).find('#test51').val();
  var price= $(parent).find('#price').val();

  $(parent).find('#test52').val(quant* price);
  GrandTotal();
  });

   function GrandTotal(){
     var sum='';

     $('.amount').each(function(){
       sum+=Number($(this).val());
     });

     $('#total').val(sum);
   }
    
});
var template = '';
		
	$(function(){
		
		$("#addRow3").click(function(){
		
			row = '<tr>'+
			'<td><input class="underline-input" type="text" style="width: 10rem" id="country1" name="country1['+template+']" maxlength="4"  value="<?php 
								  echo $country; ?>"  readonly = "readonly"/></td>'+
			'<td><input class="underline-input" type="text" style="width: 10rem" id="test5" maxlength="1" pattern="\\d{1}" name="test5['+template+']"/></td>'+
		
			'<td><input class="underline-input multi" type="number" style="width: 10rem" id="test51" name="test51['+template+']"/></td>'+

			'<td id="myelement"><input class="underline-input multi" type="number" style="width: 10rem" id="price" name="price[0]" name="price['+template+']" value="<?php echo $priceclk; ?>"/></td>'+
		
			'<td><input class="underline-input amount" type="number" style="width: 10rem" id="test52"  name="test52['+template+']"/></td>'+
		
			'<td><button type="button" class="del3">Del</button></td>'+
		
			'</tr>';
		
			$(row).insertBefore("#last3");
		
			i++;
		
			});
		
		});
		
		
		$(".del3").live('click', function(){
		
			$(this).parent().parent().remove();
		
			});

   $("#calculation3").append(template);

 
</script>
</table>
</div>

our clients sell some number products to their customers. One product price is $SGP 0.2. The number is input in the test5 column. For this table #4, the user only can input one digit length number product. The other table can be 4 digits, 3 digits and 2 digits.

The customer can also buy quantity of the product. the quantity is input in the test51 column. The test52 column is multiplication of test51 column and price column. I hide the price column. The customer can also buy more than one number product per each table. The header field is country. I also save the header field country to the detail table. So, that's why there is country column for all tables (table #1 to table #5).

Total sales is the accumulation of each table amounts which column name for each table is test22, test32, until test52. I use JS to calculate it.

Please kindly let me know if you need is difference with my explanation above. thank you

admien · April 1

Here is the result of inserting multiple rows from separated tables in the database table. My goal is to put the data in one line together but not separated line of detail table. Can some one give an idea how to improve the php of my apps ?

mac_gyver · April 1

you are trying to store the data like it is in a spreadsheet, not a database. doing this makes all the code and queries to perform any action on the data overly complicated.

it appears that each html table section is for a different type/category of products? within each type/category of product, the testx field is the item id, the testx1 field is the quantity, and the testx2 field is the total? if so, when you store the data in the detail table, you should have a category_id column (that indicates which html table section that data is for), an item_id column, a quantity column, and a total column.

admien · April 2

11 hours ago, Perplexity 🤖 said:

you are trying to store the data like it is in a spreadsheet, not a database. doing this makes all the code and queries to perform any action on the data overly complicated.

it appears that each html table section is for a different type/category of products? within each type/category of product, the testx field is the item id, the testx1 field is the quantity, and the testx2 field is the total? if so, when you store the data in the detail table, you should have a category_id column (that indicates which html table section that data is for), an item_id column, a quantity column, and a total column.

very nice.. correct that it will be similar like excel spreadsheet. it is because the user is not familiar yet with web application. I didn't think about that before. so, I will make a category_id column and it will be available in all tables. but I think I just need one table only if the category_id is used to split each product. I mean it will be option columns. Currently we have only 3 category products. but how to arrange it so that it can properly directly insert into the columns i.e. testx untul testx2 ?

Edited April 2 by Copilot 🤖
typo

Sign In

PHP Notice: Undefined offset: 1 in C:\xampp5\htdocs\appname\processform.php on line 107 to total number of columns to be inserted

Recommended Posts

admien

Link to comment

Share on other sites

mac_gyver

Link to comment

Share on other sites

mac_gyver

Link to comment

Share on other sites

admien

Link to comment

Share on other sites

admien

Link to comment

Share on other sites

mac_gyver

Link to comment

Share on other sites

admien

Link to comment

Share on other sites

admien

Link to comment

Share on other sites

admien

Link to comment

Share on other sites

mac_gyver

Link to comment

Share on other sites

admien

Link to comment

Share on other sites

Join the conversation

Browse

Activity

Important Information