Security Issue

[astronaut]

Hi, recently I was told that my website could get hacked because of poorly written code. I am a novice newbie programmer, so all I know is to write simple if/else statements for now.

Is this code truely vulnerable to a hacker, and is there a better way of coding this?

[color=red]<?php
if ($result=='1'){
include("result.php");
}
?>
  <a href="<? echo $PHP_SELF?>?result=1">Click here to see page 2</a>[/color]

[Tandem]

You don't need quotes for the number, and parentheses for the include.

[code]<?php
if ($result == 1){
include "result.php";
}
?>
  <a href="<? echo $PHP_SELF?>?result=1">Click here to see page 2[/url][/code]

There is nothing "hackable" about it though.

[dgiberson]

if ($result === 1) {
  do something
} else {
  do something else
}

===  is a strict comparison for type

for example
$x = 1;
$y = "1";

if ($y == $x) {
  echo "This matches";
} else {
  echo "No match";
}

if ($y === $x) {
  echo "match";
} else {
  echo "no match";
}

[astronaut]

case closed, thanks. Looks like I'm in the clear. Also learned that the === sign means that it also makes sure the variable is strickly a number instead of either number or letter value.

Thanks  alot!!