n8w Posted March 5, 2006 Share Posted March 5, 2006 I have been getting an error lately on my site that says too many connections are open to the databaseI think this is because I am not properly opening and closing my db connections .. is there anything I need to do to my code?connection script[code]<?php$usr = "username";$pwd = "password";$db = "database_name";$host = "localhost";$cid = mysql_connect($host,$usr,$pwd);if (!$cid) { die(mysql_error());}mysql_select_db($db,$cid) or die ("Could not open database");?>[/code]then when I query the database I have this[code] # execute SQL statement $retid = mysql_db_query($db, $sql, $cid) or die(mysql_error());# check for errorsif (!$retid) { die(mysql_error()); } else {[/code]and then at the end of my page I have this[code]mysql_close();[/code]Thanks for your help Quote Link to comment https://forums.phpfreaks.com/topic/4144-the-right-way-to-connect-and-close-db-connections/ Share on other sites More sharing options...
JasperBosch Posted March 5, 2006 Share Posted March 5, 2006 Hi n8w,Do you have any reason to use mysql_db_query instead of mysql_query?$cid = mysql_connect($host,$usr,$pwd); already creates a connection to your database, the mysql_db_query creates a new connection to your database and you won't use the connection you already made. Read the reference: [a href=\"http://www.phpfreaks.com/phpmanual/page/function.mysql-db-query.html\" target=\"_blank\"]mysql_db_query[/a] and [a href=\"http://www.phpfreaks.com/phpmanual/page/function.mysql-query.html\" target=\"_blank\"]mysql_query[/a]I never close a databaseconnection, it is closed on termination of the script. I think? Quote Link to comment https://forums.phpfreaks.com/topic/4144-the-right-way-to-connect-and-close-db-connections/#findComment-14432 Share on other sites More sharing options...
n8w Posted March 5, 2006 Author Share Posted March 5, 2006 Hey Jasper .. great catch .. I think that was probably the problemthanks! Quote Link to comment https://forums.phpfreaks.com/topic/4144-the-right-way-to-connect-and-close-db-connections/#findComment-14458 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.