Echo problems

[stevewar]

Your help is greatly appreciated:

 

I have the need to take this static code and turn it into a function that takes the input "name" as an argument and echos out this entire bit of code with only the input "name"  changed. The reason is that there are 28 different inputs and I don't want to repeat this code all over the place. If there is a better solution please feel free.  Thanks!

 

<input name="tricepsSkinfold1" type="text" size="10" maxlength="2" value="

 

<?php

            if( isset( $_SESSION['bValidated']['tricepsSkinfold1']['value'] ) )

{

echo $_SESSION['bValidated']['tricepsSkinfold1']['value'];

} ?>"

 

<?php

if( -1 == $_SESSION['bValidated']['tricepsSkinfold1']['valid'] )

{

echo "style=\"background:#FFFF00\"";

}

?>

  />

<?php

if( -1 == $_SESSION['bValidated']['tricepsSkinfold1']['valid'] )

{

echo "<br/>".$_SESSION['errors']['tricepsSkinfold1'];

}

?>

[per1os]

Damn dude talk about a hard way of doing stuff. Maybe this will help.

 

<?php

echo createInput('tricepsSkinfold1');

function createInput($name) {
    $return = '<input name="'.$name.'" type="text" size="10" maxlength="2"';

    if (isset($_SESSION['bValidated'][$name]['value'])) {
         $return .= 'value="'.$_SESSION['bValidated'][$name]['value'] . '" ';
    }else {
         $return .= 'value="" ';
    }

    if (isset($_SESSION['bValidated'][$name]['valid']) && $_SESSION['bValidated'][$name]['valid'] == -1) {
        $return .= 'style="background: #FFFF00" ' . $_SESSION['errors'][$name];
    }

    return $return . ' />';
}

?>

 

Then if you have an array of the names, just loop them with that function. Simple as that.

 

--FrosT

[Barand]

or

 

<?php
function print_input ($name)  {

    $value = isset( $_SESSION['bValidated'][$name]['value'] ) ? $_SESSION['bValidated'][$name]['value'] : '';
    $style = $error = '';
    if( -1 == $_SESSION['bValidated'][$name]['valid'] ) {
        $style = "style=\"background:#FFFF00\"";
        $error = $_SESSION['errors'][$name]; 
    }
    return "<input name=\"$name\" type=\"text\" size=\"10\" maxlength=\"2\" value=\"$value\" $style /> $error";    

}

echo print_input('tricepsSkinfold1') ;
?>

[per1os]

Theres more than one way to skin a cat =)

 

--FrosT

[stevewar]

Thanks guys. I'm not really a php developer. Actually I'm a nutritionist trying to develop php applications, and I just started messing with it this week. I've got user management working and tested, now I'm working on this progress tracker application. I appreciate your help as it will improve my efficiency!

 

-Steve

[Barand]

Theres more than one way to skin a cat =)

 

--FrosT

 

I'd written it as you were posting so as the style was significantly different I thought I may as well post the alternative.

 

BTW, the error message should be outside the input field tag

[per1os]

Ah, its all good =) Either way there is never 1 right answer to any question in coding. There are always 10 different ones =)

 

--FrosT