[SOLVED] check if username is unique

[Trium918]

Problem: write a basic script that will check

if username is unique. This script works but I

am puzzled by the fact the script only works

like it is. Why?

 

Note: Just ideas

 

<?php
if ($reg_result) // will not work
if ($reg_result == true) // will not work

if ($reg_result == "true")
   {
     echo "<p class=\"genmed\">Your registration was successful.  Go to the members page "
          ."to start setting up your bookmarks!</p>";
   }
?>

 

<?php
// check if username is unique 
  $user_name = $_POST['user_name'];
  $result = mysql_query("select * from members_info where user_name='$user_name'"); 
  if (!$result)
     return "Could not execute query". mysql_error();
  if (mysql_num_rows($result)>0) 
     return "<p class=\"genmed\">That username is taken - go back and choose another one.</p>";
?>

[shaunrigby]

How do you mean the script only works "like this", what do you change to make it "not" work?

[Trium918]

How do you mean the script only works "like this", what do you change to make it "not" work?

 

Sorry about that

 

if ($reg_result) // will not work

if ($reg_result == true) // will not work

[sanfly]

when using true or false, you should use 3 =

 

eg:

 

if ($reg_result === true)

 

But anyway, where do you come up with $reg_result, I dont see it anywhere else in the code you supplied.

[Trium918]

when using true or false, you should use 3 =

 

eg:

 

if ($reg_result === true)

 

But anyway, where do you come up with $reg_result, I dont see it anywhere else in the code you supplied.

 

<?php
// attempt to register
   $reg_result = register($user_name,$first_name,$last_name,$gender,$birth_month,$birth_day,
   $birth_year,$contact_number,$email_address,$password,$street_address, $city_county, $state, $postal_code);
   if ($reg_result == "true")
   {
          echo "<p class=\"genmed\">Your registration was successful.  Go to the members page "
          ."to start setting up your bookmarks!</p>";
   }
?>

[shaunrigby]

 if($reg_result === TRUE){
//INSERT PROCESSING HERE
} else {
//UL DUMBA$$ SOMEBODY HAS YOUR PREFERRED NAME
}

[sanfly]

I take it somewhere in your register function when registration is successful you have

 

return true;

 

If not, you better post your function

 

If so, did you try the 3= ?

 

if ($reg_result === true)

 

 

 

 

[MadTechie]

do a

<?php
var_dump($reg_result);
die;
if ($reg_result == "true")
?>

 

i think your find register() is returning a string not a boolean,

 

as for the ===, this forces the check to be of the same type

 

ie

if(1=="1") // works

if(1==="1")//fails

 

 

[shaunrigby]

do a

<?php
var_dump($reg_result);
die;
if ($reg_result == "true")
?>

 

i think your find register() is returning a string not a boolean,

 

as for the ===, this forces the check to be of the same type

 

ie

if(1=="1") // works

if(1==="1")//fails

 

 

 

that is if s/he uses return true;  and in what context (1/0, true/false)

[Trium918]

do a

<?php
var_dump($reg_result);
die;
if ($reg_result == "true")
?>

 

i think your find register() is returning a string not a boolean,

 

as for the ===, this forces the check to be of the same type

 

ie

if(1=="1") // works

if(1==="1")//fails

 

 

You're right it is returning a string!

<?php
return "<p class=\"genmed\">That username is taken - go back and choose another one.</p>";
?>

[MadTechie]

yeah but as shaunrigby pointed out when using booleans === is important as

 

<?php
$test="false"
if($test) // will pass
if($test == true) // will pass
if($test === true) // will fails

?>

[Trium918]

Well, I got this

 

var_dump($reg_result);

die;

 

result = NULL

[Trium918]

yeah but as shaunrigby pointed out when using booleans === is important as

 

<?php
$test="false"
if($test) // will pass
if($test == true) // will pass
if($test === true) // will fails

?>

 

So what you are saying is that it is better

to use the method that I already have than

if($test === true) // will fails

[shaunrigby]

did that appear on your screen?

 

please wrap [ code][ /code] tags around your code to make it easier for us to understand, and also plus post the function to work out why it is returning NULL

[MadTechie]

null means nothing returning (i believe thats a unique name)

 

 

EDIT:

wait a minute thats not right!!

 

can you post the register function code please

 

LOL

 

i hope  no one said that dumb mistake of mine LOL

[shaunrigby]

Lets make it easier for ourselves, Trium, please post the function wrapped in code tags

[Trium918]

<?php
function register($user_name,$first_name,$last_name,$gender,$birth_month,$birth_day,
   $birth_year,$contact_number,$email_address,$password,$street_address, $city_county, $state, $postal_code)
// register new person with db
// return true or error message
{
// connect to db
  $conn = db_connect();
  if (!$conn)
    return "Could not connect to database server - please try later.";

  // check if username is unique 
  $user_name = $_POST['user_name'];
  $result = mysql_query("select * from members_info where user_name='$user_name'"); 
  if (!$result)
     return "Could not execute query". mysql_error();
  if (mysql_num_rows($result)>0) 
     return "<p class=\"genmed\">That username is taken - go back and choose another one.</p>";

?>

[Trium918]

<?php
function register($user_name,$first_name,$last_name,$gender,$birth_month,$birth_day,
   $birth_year,$contact_number,$email_address,$password,$street_address, $city_county, $state, $postal_code)
// register new person with db
// return true or error message
{
// connect to db
  $conn = db_connect();
  if (!$conn)
    return "Could not connect to database server - please try later.";

  // check if username is unique 
  $user_name = $_POST['user_name'];
  $result = mysql_query("select * from members_info where user_name='$user_name'"); 
  if (!$result)
     return "Could not execute query". mysql_error();
  if (mysql_num_rows($result)>0) 
     return "<p class=\"genmed\">That username is taken - go back and choose another one.</p>";

?>

[sanfly]

so you need to have in there somewhere

 

if (mysql_num_rows($result) == 0){
return true;
}

[MadTechie]

<?php
if (mysql_num_rows($result)>0)
{
     return false;
}else{
     return true;
}
?>

 

 

 

 

 

 

<?php
// attempt to register
   $reg_result = register($user_name,$first_name,$last_name,$gender,$birth_month,$birth_day,
   $birth_year,$contact_number,$email_address,$password,$street_address, $city_county, $state, $postal_code);
   if ($reg_result === true)
   {
          echo "<p class=\"genmed\">Your registration was successful.  Go to the members page "
          ."to start setting up your bookmarks!</p>";
   }else{
echo "<p class=\"genmed\">That username is taken - go back and choose another one.</p>";
}
?>

[shaunrigby]

Change :

$conn = db_connect();
 if (!$conn)
   return "Could not connect to database server - please try later.";

 // check if username is unique 
 $user_name = $_POST['user_name'];
 $result = mysql_query("select * from members_info where user_name='$user_name'"); 
 if (!$result)
    return "Could not execute query". mysql_error();
 if (mysql_num_rows($result)>0) 
    return "<p class=\"genmed\">That username is taken - go back and choose another one.</p>";

 

To:

 

$conn = mysql_connect($host,$username,$password)
or die("Could not connect to database server - please try later." . mysql_error());//Remove . mysql_error() after you have finished developing your code

mysql_select_db($dbname)
or die(mysql_error());

 // check if username is unique 
//  $user_name = $_POST['user_name'];//Why you setting this? you are obtaining it VIA your function,
 $query = mysql_query("SELECT * FROM `members_info` WHERE `user_name` = '" . $user_name . "'")
or die(mysql_error());

$result = mysql_num_rows($query);

 if ($result > 0 ) {
    return true;
} else {
return false;
}

[Trium918]

Thanks

 

MadTechie, shaunrigby, and sanfly

 

[shaunrigby]

It all work now m8?

[MadTechie]

who cares the solve button has been pressed, lets get out of here lol

 

Good to know Trium918

 

your welcome