[SOLVED] Making a function

[graham23s]

Hey Guys,

 

there is a piece of code i use a lot in the sites i make lately it's this:

 

     // Get the users details from mysql...//////////////////////////////////////////////
     $query1 = "SELECT * FROM `membership` WHERE `username`='$member'";
     $result1 = mysql_query($query1) or die (mysql_error());
     $row = mysql_fetch_array($result1);
     
     $id = $row['id'];
     $username = $row['username'];

 

just to find out the username and id of the logged in user, is there anyway i can make this a function, functions is one thing i haven't really mastered yet

 

any help would be great

 

cheers

 

Graham

[pocobueno1388]

<?php

function userName($member){

     $query1 = "SELECT * FROM `membership` WHERE `username`='$member'";
     $result1 = mysql_query($query1) or die (mysql_error());
     $row = mysql_fetch_array($result1);
     
     $id = $row['id'];
     $username = $row['username'];

     echo "$username ($id)";

}


?>

 

Now just call it like this:

 

userName(persons_username);

[JakeTheSnake3.0]

function getUserInfo($memberID) {
    $infoArray = array();
    // Get the users details from mysql...//////////////////////////////////////////////
    $query = "SELECT * FROM membership WHERE username='$memberID'";
    $result = mysql_query($query) or die (mysql_error());
    $row = mysql_fetch_array($result);
    
    $infoArray['id'] = $row['id'];
    $infoArray['username'] = $row['username'];
    
    return $infoArray;
}

 

What this function does, is that it accepts a single argument; it then takes that argument and does an SQL query using it.  In the end, it 'returns' an array holding the appropriate information.

 

When a function 'returns' something, it's basically the equivalent of storing variable data.....

 

ex) $userInfo = getUserInfo('100454998');

 

This will make $userInfo an array....so now if you want to access the username, do this....echo($userInfo['username']);

[Wildbug]

I'm not sure that $id and $username will be updated outside of that function.  (Variable scope.)  You may need to declare them "global $id,$username" at the beginning of the function.

 

Otherwise, you could also return the two values and capture them with a "list($id,username) = yourFunction($member)".

[graham23s]

Thanks for the quick replies guys,

 

that has given me a lot to work on.

 

thanks again

 

Graham

[per1os]

Or you could pass them by reference, just another option.

 

<?php
function getUserInfo($memberID, &$username, &$id) {
   // Get the users details from mysql...//////////////////////////////////////////////
   $query = "SELECT * FROM membership WHERE username='$memberID'";
   $result = mysql_query($query) or die (mysql_error());
   $row = mysql_fetch_array($result);
   
   $id = $row['id'];
   $username = $row['username'];
    
   return true;
}

getUserInfo($memberID, $username, $id);

echo 'The username is: ' . $username . ' The ID is ' . $id;
?>

 

Fun stuff this programming is.

[graham23s]

lol that's very true, everytime i do something on my own (and it works) i get paranoid i have done it wrong (even though it works) incase there was a better way of doing things or later on down the line it would have been better doing it another way lol

 

cheers

 

Graham

[Wildbug]

I don't think it was mentioned above, but include()s are also an option for oft-repeated code.