[SOLVED] Question?

[Trium918]

Is this legitimate?

 

<?php
session_start();
if(!$_SESSION['id'] && !$_SESSION['valid_user']){
 header("Location: login.php"); 
}
?>

[per1os]

I would go about it this way:

 

<?php
session_start();
if((!isset($_SESSION['id']) || !$_SESSION['id']) && (!isset($_SESSION['valid_user']) || !$_SESSION['valid_user'])){
 header("Location: login.php"); 
}
?>

 

To avoid notice's etc.

[The Little Guy]

Yes, if $_SESSION['id'] and $_SESSION['valid_user'] are both boolean values (TRUE or FALSE)

[Trium918]

Yes, if $_SESSION['id'] and $_SESSION['valid_user'] are both boolean values (TRUE or FALSE)

 

What exactly do you mean?

[Barand]

Even if they're booleans it's better to check if they exist, as in frost's post.

[The Little Guy]

in order for that code to work, it is looking for the value of these two variable:

$_SESSION['id']

$_SESSION['valid_user']

 

to either be TRUE or FALSE;

 

-----

 

$_SESSION['id'] = FALSE;

or

$_SESSION['id'] = TRUE;

 

-----

 

$_SESSION['valid_user'] = FALSE;

or

$_SESSION['valid_user'] = TRUE;

 

-----

 

if the variable isn't set, it will automatically be set to FALSE.

[Trium918]

in order for that code to work, it is looking for the value of these two variable:

$_SESSION['id']

$_SESSION['valid_user']

 

to either be TRUE or FALSE;

 

-----

 

$_SESSION['id'] = FALSE;

or

$_SESSION['id'] = TRUE;

 

-----

 

$_SESSION['valid_user'] = FALSE;

or

$_SESSION['valid_user'] = TRUE;

 

-----

 

if the variable isn't set, it will automatically be set to FALSE.

 

Both scripts are redirecting back to login if the user isn't

logged in. That will make it true if the user logs in, and

false if the user isn't logged in, correct?

<?php
session_start();
if(!$_SESSION['id'] && !$_SESSION['valid_user']){
 header("Location: login.php"); 
}
?>

 

<?php
session_start();
if((!isset($_SESSION['id']) || !$_SESSION['id']) && (!isset($_SESSION['valid_user']) || !$_SESSION['valid_user'])){
 header("Location: login.php"); 
}
?>